Skip to content

feat: Add CMAKE_SOURCE_DIR parameter to install-remote-tar to support installing projects whose CMakeLists.txt isn't in the root directory. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bill-hbrhbr merged 6 commits into from
Jul 25, 2025
Merged

feat: Add CMAKE_SOURCE_DIR parameter to install-remote-tar to support installing projects whose CMakeLists.txt isn't in the root directory. #72

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ffb80b
feat: Add CMAKE_SOURCE_DIR variable to install-remote-tar task.
jackluo923 Jul 14, 2025
2a38c76
Update param description
Bill-hbrhbr Jul 14, 2025
7552645
Resolved code review comments.
jackluo923 Jul 15, 2025
a090859
Fixed bug where the OUT_DIR is not updated after renaming SOURCE_DIR …
jackluo923 Jul 15, 2025
dc5ec6c
Address review comments on extraction dir
Bill-hbrhbr Jul 25, 2025
3756cc8
Merge branch 'main' into add-cmake-source-path
Bill-hbrhbr Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion exports/taskfiles/utils/cmake.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ tasks:
# should be stored.
# @param {string[]} [CMAKE_TARGETS] A list of specific targets to build instead of the default
# target.
# @param {string} [CMAKE_SOURCE_DIR] Optional path, relative to SRC_DIR, specifying a custom
# CMake source directory to pass to the CMake generate command.
install-remote-tar:
internal: true
label: "{{.TASK}}:{{.CMAKE_PACKAGE_NAME}}-{{.TAR_URL}}-{{.INSTALL_PREFIX}}"
Expand All @@ -174,6 +176,8 @@ tasks:
{{default "" .CMAKE_SETTINGS_DIR}}
CMAKE_TARGETS:
ref: "default (list) .CMAKE_TARGETS"
CMAKE_SOURCE_DIR: >-
Comment thread
Bill-hbrhbr marked this conversation as resolved.
{{default "." .CMAKE_SOURCE_DIR}}
Comment thread
Bill-hbrhbr marked this conversation as resolved.

Comment thread
Bill-hbrhbr marked this conversation as resolved.
# Directory parameters
BUILD_DIR: "{{.WORK_DIR}}/{{.CMAKE_PACKAGE_NAME}}-build"
Expand All @@ -194,7 +198,7 @@ tasks:
BUILD_DIR: "{{.BUILD_DIR}}"
EXTRA_ARGS:
ref: ".CMAKE_GEN_ARGS"
SOURCE_DIR: "{{.SOURCE_DIR}}"
SOURCE_DIR: "{{.SOURCE_DIR}}/{{.CMAKE_SOURCE_DIR}}"
- task: "build"
Comment thread
Bill-hbrhbr marked this conversation as resolved.
Outdated
vars:
BUILD_DIR: "{{.BUILD_DIR}}"
Expand Down