Skip to content

fix(taskfiles)!: Remove quotes when evaluating EXTRA_ARGS in CMake tasks, properly treating them as command flags. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidlion merged 5 commits into from
Jun 16, 2025
Merged

fix(taskfiles)!: Remove quotes when evaluating EXTRA_ARGS in CMake tasks, properly treating them as command flags. #66

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4bfd39
fix(taskfiles): Remove unnecessary double quotes when evaluating
PacificViking Jun 11, 2025
a123ba9
Merge branch 'main' into john_extra_args_fix
PacificViking Jun 12, 2025
245a1ea
add components as possible argument to cmake:install
PacificViking Jun 12, 2025
40445c9
Revert "add components as possible argument to cmake:install"
PacificViking Jun 12, 2025
7b23e40
unquote other EXTRA_ARGS lists in cmake
PacificViking Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exports/taskfiles/utils/cmake.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ tasks:
--target="{{.}}"
{{- end}}
{{- range .EXTRA_ARGS}}
"{{.}}"
{{.}}
{{- end}}

# Runs the CMake clean target for the given build directory. The caller must have previously
Expand Down Expand Up @@ -81,7 +81,7 @@ tasks:
-S "{{.SOURCE_DIR}}"
-B "{{.BUILD_DIR}}"
{{- range .EXTRA_ARGS}}
"{{.}}"
{{.}}
{{- end}}

# Runs the CMake install step for the given build directory. The caller must have previously
Expand Down Expand Up @@ -123,7 +123,7 @@ tasks:
--install "{{.BUILD_DIR}}"
--prefix "{{.INSTALL_PREFIX}}"
{{- range .EXTRA_ARGS}}
"{{.}}"
{{.}}
Comment thread
davidlion marked this conversation as resolved.
{{- end}}
- >-
{{- if .CMAKE_SETTINGS_DIR}}
Expand Down