Skip to content

fix(lint-configs): Relax clang-tidy misc-include-cleaner check to a warning. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidlion merged 4 commits into from
May 8, 2025
Merged

fix(lint-configs): Relax clang-tidy misc-include-cleaner check to a warning. #47

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5feb1a0
fix(lint-configs): Relax clang-tidy `misc-include-cleaner` to a warning
davidlion May 7, 2025
d84f2fd
Improve style.
davidlion May 7, 2025
e84e93a
Apply suggestions from code review.
davidlion May 7, 2025
d6f841c
Add comma.
davidlion May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion exports/lint-configs/.clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
FormatStyle: "file"
WarningsAsErrors: "*"

# Left as warnings:
# - `misc-include-cleaner` because it's difficult to resolve IWYU issues for external libraries
# without facade headers.
WarningsAsErrors: >-
*,
-misc-include-cleaner
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

# Disabled checks:
# - `bugprone-easily-swappable-parameters` because it's difficult to mitigate.
Expand Down