Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Copyright (c) Facebook, Inc. and its affiliates.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
language: "en-CA"
reviews:
path_instructions:
- path: "**/*.{cpp,h,hpp,java,js,jsx,tpp,ts,tsx}"
instructions: >-
- Prefer `false == <expression>` rather than `!<expression>`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Refine instruction text
The instructions field is a free-form string; drop the leading - to avoid it looking like a list item.

- instructions: >-
-   - Prefer `false == <expression>` rather than `!<expression>`.
+ instructions: >-
+   Prefer `false == <expression>` rather than `!<expression>`.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
path_instructions:
- path: "**/*.{cpp,h,hpp,java,js,jsx,tpp,ts,tsx}"
instructions: >-
- Prefer `false == <expression>` rather than `!<expression>`.
path_instructions:
- path: "**/*.{cpp,h,hpp,java,js,jsx,tpp,ts,tsx}"
instructions: >-
Prefer `false == <expression>` rather than `!<expression>`.
🤖 Prompt for AI Agents
In .coderabbit.yaml around lines 18 to 21, the instructions field currently
starts with a leading '- ' which makes it appear as a list item. Remove the
leading '- ' from the instructions string so it is treated as a plain free-form
string rather than a list item.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this again, we probably don't want this for the Presto & Velox repos since they don't have the same requirements in their codebase.

profile: "assertive"
poem: false
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved