chore: Upgrade Velox to 59b492 pointed by upstream Presto release-0.297-edge10.

.clang-tidy

@@ -1,20 +1,26 @@
 Checks: >
   *,
   -abseil-*,
+  -altera-struct-pack-align,
+  -altera-unroll-loops,
   -android-*,
-  -cert-err58-cpp,
+  -boost-use-ranges,
+  -bugprone-easily-swappable-parameters,
   -cert-err58-cpp,
   -clang-analyzer-osx-*,
   -cppcoreguidelines-avoid-c-arrays,
+  -cppcoreguidelines-avoid-const-or-ref-data-members,
+  -cppcoreguidelines-avoid-do-while,
   -cppcoreguidelines-avoid-goto,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-avoid-non-const-global-variables,
+  -cppcoreguidelines-non-private-member-variables-in-classes,
   -cppcoreguidelines-owning-memory,
   -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -cppcoreguidelines-pro-bounds-constant-array-index,
   -cppcoreguidelines-pro-bounds-pointer-arithmetic,
   -cppcoreguidelines-pro-type-reinterpret-cast,
   -cppcoreguidelines-pro-type-vararg,
-  -cppcoreguidelines-pro-type-vararg,
   -cppcoreguidelines-special-member-functions,
   -fuchsia-*,
   -google-*,
@@ -25,25 +31,31 @@ Checks: >
   -hicpp-special-member-functions,
   -hicpp-use-equals-default,
   -hicpp-vararg,
-  -hicpp-vararg,
   -llvm-header-guard,
   -llvm-include-order,
+  -llvm-qualified-auto,
   -llvmlibc-*,
   -misc-no-recursion,
-  -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
   -misc-unused-parameters,
   -modernize-avoid-c-arrays,
   -modernize-deprecated-headers,
+  -modernize-use-designated-initializers,
   -modernize-use-nodiscard,
   -modernize-use-trailing-return-type,
   -mpi-*,
   -objc-*,
   -openmp-*,
+  -performance-avoid-endl,
+  -performance-enum-size,
   -readability-avoid-const-params-in-decls,
   -readability-convert-member-functions-to-static,
+  -readability-function-cognitive-complexity,
+  -readability-identifier-length,
   -readability-implicit-bool-conversion,
   -readability-magic-numbers,
+  -readability-math-missing-parentheses,
+  -readability-qualified-auto,
   -zircon-*,
 
 HeaderFilterRegex: '.*'

.dockerignore

@@ -0,0 +1,37 @@
+# Copyright (c) Facebook, Inc. and its affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+<<<<<<<< HEAD:.yamlfmt.yml
+match_type: doublestar
+exclude:
+  - '**/.clang-format'
+  - '**/.clang-tidy'
+formatter:
+  type: basic
+  retain_line_breaks_single: true
+  scan_folded_as_literal: true
+  indent: 2
+========
+
+.git*
+docs/
+static/
+website/
+
+_build/
+
+# Python binary dirs
+.venv/
+dist/
+wheelhouse/
+>>>>>>>> 59b492a9bce45f487f24b5cbae7dc845ea3d0827:.dockerignore

.gersemirc

@@ -0,0 +1,13 @@
+# vim: set filetype=yaml :
+
+line_length: 100
+indent: 2
+definitions:
+  - CMake/third-party/FBCMakeParseArgs.cmake
+  - CMake/third-party/FBThriftCppLibrary.cmake
+  - CMake/FindThrift.cmake
+  - velox/experimental/breeze/cmake
+  - velox/experimental/breeze/test
+  - velox/experimental/breeze/perftest
+extensions:
+  - scripts/ci/gersemi_cmd_definitions.py

.github/CODEOWNERS

@@ -24,14 +24,18 @@
 
 # Build & CI
 CMake/ @assignUser @majetideepak
-*.cmake @assignUser @majetideepak
-**/CMakeLists.txt @assignUser @majetideepak
+/CMakeLists.txt @assignUser
+*.cmake @majetideepak
+**/CMakeLists.txt @majetideepak
 scripts/ @assignUser @majetideepak
 .github/ @assignUser @majetideepak
 
 # Breeze
 velox/experimental/breeze @dreveman
 
+# cuDF
+velox/experimental/cudf/ @bdice @karthikeyann @devavret @mhaseeb123
+
 # Parquet
 velox/dwio/parquet/ @majetideepak
 
@@ -43,3 +47,6 @@ velox/connectors/ @majetideepak
 
 # Caching
 velox/common/caching/ @majetideepak
+
+# Spark Functions
+velox/functions/sparksql/ @jinchengchenghh @rui-mo @zhli1142015

.github/workflows/linux-build-base.yml

@@ -84,7 +84,7 @@ jobs:
             export CC=/usr/bin/clang-15
             export CXX=/usr/bin/clang++-15
           fi
-          make release
+          make release TREAT_WARNINGS_AS_ERRORS=0
 
       - name: Show CCache stats after build
         run: ccache -vs

.github/zizmor.yml

@@ -15,9 +15,6 @@ rules:
   use-trusted-publishing:
     ignore:
       - build_pyvelox.yml
-
   unpinned-images:
     ignore:
-      # linux-build-base.yml builds and publishes a container image which we then use immediately;
-      # so we need to use the images dynamically generated (i.e., unpinned) tag.
       - linux-build-base.yml

.gitignore

@@ -293,8 +293,7 @@ distribute/*
 *.bin
 cmake_build
 .cmake_build
-cmake-build-debug
-cmake-build-release
+cmake-build-*
 
 # tests
 test/test.sql
@@ -325,5 +324,6 @@ src/amalgamation/
 velox/docs/sphinx/source/README_generated_*
 velox/docs/bindings/python/_generate/*
 scripts/bm-report/report.html
+scripts/bm-report/result
 dist/
 wheelhouse/

.pre-commit-config.yaml

@@ -35,22 +35,16 @@ repos:
 
   - repo: local
     hooks:
-      - id: cmake-format
-        name: cmake-format
-        description: Format CMake files.
-        entry: cmake-format
-        language: python
-        files: (CMakeLists.*|.*\.cmake|.*\.cmake.in)$
-        args: [--in-place]
-        require_serial: false
-        additional_dependencies: [cmake-format==0.6.13, pyyaml]
-
       - id: clang-tidy
         name: clang-tidy
-        description: Run clang-tidy on C/C++ files
+        description: >-
+          Run clang-tidy on C/C++ files, requires 'compile_commands.json'
+          to be available in the repo root (e.g. symlinked) or BUILD_PATH
+          set to it's path e.g. _build/release.
         stages:
-          - manual # Needs compile_commands.json
-        entry: clang-tidy
+          - pre-commit
+        entry: ./scripts/checks/run-clang-tidy.py
+        args: [--commit, HEAD]
         language: python
         types_or: [c++, c]
         additional_dependencies: [clang-tidy==18.1.8]
@@ -76,8 +70,14 @@ repos:
           NOTICE.txt
           )$
 
+  - repo: https://github.com/BlankSpruce/gersemi
+    rev: 0.21.0
+    hooks:
+      - id: gersemi
+        name: CMake formatter
+
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: v18.1.3
+    rev: v21.1.2
     hooks:
       - id: clang-format
         # types_or: [c++, c, cuda, metal, objective-c]
@@ -91,6 +91,19 @@ repos:
         args: [--fix]
       - id: ruff-format
 
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.10.0.1
+    hooks:
+      - id: shellcheck
+        args: [-x, --severity=warning]
+
+  - repo: https://github.com/scop/pre-commit-shfmt
+    rev: v3.11.0-1
+    hooks:
+      - id: shfmt
+        # w: write changes, s: simplify, i set indent to 2 spaces
+        args: [-w, -s, -i, '2']
+
   # The following checks mostly target GitHub Actions workflows.
   - repo: https://github.com/adrienverge/yamllint.git
     rev: v1.37.0

CMake/FindArrow.cmake

@@ -25,7 +25,8 @@ find_package_handle_standard_args(
   ARROW_LIB
   ARROW_TESTING_LIB
   ARROW_INCLUDE_PATH
-  Thrift_FOUND)
+  Thrift_FOUND
+)
 
 # Only add the libraries once.
 if(Arrow_FOUND AND NOT TARGET arrow)
@@ -34,10 +35,13 @@ if(Arrow_FOUND AND NOT TARGET arrow)
   add_library(thrift ALIAS thrift::thrift)
 
   set_target_properties(
-    arrow arrow_testing PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
-                                   ${ARROW_INCLUDE_PATH})
-  set_target_properties(arrow PROPERTIES IMPORTED_LOCATION ${ARROW_LIB}
-                                         INTERFACE_LINK_LIBRARIES thrift)
-  set_target_properties(arrow_testing PROPERTIES IMPORTED_LOCATION
-                                                 ${ARROW_TESTING_LIB})
+    arrow
+    arrow_testing
+    PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${ARROW_INCLUDE_PATH}
+  )
+  set_target_properties(
+    arrow
+    PROPERTIES IMPORTED_LOCATION ${ARROW_LIB} INTERFACE_LINK_LIBRARIES thrift
+  )
+  set_target_properties(arrow_testing PROPERTIES IMPORTED_LOCATION ${ARROW_TESTING_LIB})
 endif()