Skip to content

ci: Cherry-pick prestodb/presto#13361 to use pre-commit for quality checks; Fix compilation caching by using cache on runner. - #11

Merged
kirkrodrigues merged 19 commits into
y-scope:presto-0.293-clp-connectorfrom
anlowee:xwei/upgrade-to-precommit
Jun 19, 2025
Merged

ci: Cherry-pick prestodb/presto#13361 to use pre-commit for quality checks; Fix compilation caching by using cache on runner.#11
kirkrodrigues merged 19 commits into
y-scope:presto-0.293-clp-connectorfrom
anlowee:xwei/upgrade-to-precommit

Conversation

@anlowee

@anlowee anlowee commented Jun 18, 2025

Copy link
Copy Markdown

Description

As mentioned in #8 , for header and format check, we will apply this commit, which also uses a new way to implement ccache.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Passed the CI.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced pre-commit hook configuration for automated code formatting, linting, and license checks.
    • Added a new workflow to run pre-commit checks on pull requests.
    • Added an internal Spark function to trim trailing spaces and enforce string length limits.
  • Documentation

    • Updated code style and contribution documentation to reference pre-commit usage.
    • Added and updated license headers in various files.
    • Made minor corrections to documentation formatting and whitespace.
  • Refactor

    • Removed Makefile targets and scripts related to formatting, header checks, and Docker container builds, consolidating these tasks under pre-commit.
    • Updated type annotations in Python stubs to use modern generic types.
  • Style

    • Standardized YAML, CMake, and workflow file formatting.
    • Applied consistent whitespace and formatting across code, configuration, and documentation files.
    • Improved formatting of output stream concatenations in generated code.
  • Chores

    • Added and updated configuration files for static analysis, formatting, and linting tools.
    • Cleaned up unused imports and minor code formatting in scripts and tests.
    • Removed deprecated scripts for git clang-format and code checks.
  • Bug Fixes

    • Fixed minor typographical errors and corrected trailing whitespace in various files.
  • Tests

    • Updated test files with improved variable naming conventions and formatting.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants