Skip to content

ci: Use parallelized clang-tidy task from yscope-dev-utils. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sitaowang1998 merged 2 commits into from
Apr 5, 2025
Merged

ci: Use parallelized clang-tidy task from yscope-dev-utils. #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e41460
Use parallel clang-tidy task from dev-utils
sitaowang1998 Apr 5, 2025
f6d0b6b
Fix task argument
sitaowang1998 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-linting-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@ jobs:
timeout-minutes: 10
run: "task deps:lib_install"

- run: "task lint:check"
- run: "task lint:check -C $(nproc)"
39 changes: 12 additions & 27 deletions lint-tasks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,36 +79,21 @@ tasks:
# When we eventually determine which errors can be safely fixed, we'll allow clang-tidy to
# fix them.
aliases: ["cpp-static-fix"]
sources:
- "{{.G_LINT_VENV_CHECKSUM_FILE}}"
- "{{.G_EXAMPLES_DIR}}/**/*.cpp"
- "{{.G_EXAMPLES_DIR}}/**/*.h"
- "{{.G_EXAMPLES_DIR}}/**/*.hpp"
- "{{.G_SRC_SPIDER_DIR}}/**/*.cpp"
- "{{.G_SRC_SPIDER_DIR}}/**/*.h"
- "{{.G_SRC_SPIDER_DIR}}/**/*.hpp"
- "{{.G_TEST_DIR}}/**/*.cpp"
- "{{.G_TEST_DIR}}/**/*.h"
- "{{.G_TEST_DIR}}/**/*.hpp"
- "{{.G_SPIDER_CMAKE_CACHE}}"
- "{{.G_SPIDER_COMPILE_COMMANDS_DB}}"
- "{{.TASKFILE}}"
- "taskfile.yaml"
- "tools/yscope-dev-utils/exports/lint-configs/.clang-tidy"
sources: *cpp_source_files
deps: [":config-cmake-project", "cpp-configs", "venv"]
cmds:
- task: "clang-tidy"
vars:
FLAGS: "--config-file=.clang-tidy -p {{.G_SPIDER_COMPILE_COMMANDS_DB}}"
SRC_DIR: "{{.G_SRC_SPIDER_DIR}}"
- task: "clang-tidy"
- task: ":utils:cpp-lint:clang-tidy-find"
vars:
FLAGS: "--config-file=.clang-tidy -p {{.G_SPIDER_COMPILE_COMMANDS_DB}}"
SRC_DIR: "{{.G_TEST_DIR}}"
- task: "clang-tidy"
vars:
FLAGS: "--config-file=.clang-tidy -p {{.G_EXAMPLES_COMPILE_COMMANDS_DB}}"
SRC_DIR: "{{.G_EXAMPLES_DIR}}"
FLAGS:
- "--config-file '{{.ROOT_DIR}}/.clang-tidy'"
- "-p '{{.G_SPIDER_COMPILE_COMMANDS_DB}}'"
INCLUDE_PATTERNS:
- "{{.G_EXAMPLES_DIR}}/**"
- "{{.G_SRC_SPIDER_DIR}}/**"
- "{{.G_TEST_DIR}}/**"
OUTPUT_DIR: "{{.G_LINT_CLANG_TIDY_DIR}}"
ROOT_PATHS: *cpp_source_files
VENV_DIR: "{{.G_LINT_VENV_DIR}}"

py-check:
cmds:
Expand Down