refactor: Update yscope-dev-utils and apply latest clang-format settings. - #96
Conversation
WalkthroughThis pull request updates several linting configurations by modifying dependency versions and consolidating task commands. The Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lint-requirements.txt (1)
2-3: Dependency Version Update and Comment Consistency Check
Theclang-formatdependency is now specified as>=20.1.0, which supports the updated formatting rules. However, the comment on line 3 still indicates a lock to v19.x. Please update or remove this comment to avoid any confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (73)
lint-requirements.txt(1 hunks)lint-tasks.yaml(5 hunks)src/spider/client/Data.hpp(0 hunks)src/spider/client/Driver.cpp(0 hunks)src/spider/client/Driver.hpp(2 hunks)src/spider/client/Job.hpp(3 hunks)src/spider/client/TaskContext.cpp(0 hunks)src/spider/client/TaskContext.hpp(2 hunks)src/spider/client/task.hpp(0 hunks)src/spider/client/type_utils.hpp(0 hunks)src/spider/core/Data.hpp(0 hunks)src/spider/core/DataImpl.hpp(0 hunks)src/spider/core/Driver.hpp(0 hunks)src/spider/core/Error.hpp(0 hunks)src/spider/core/JobMetadata.hpp(0 hunks)src/spider/core/Task.hpp(2 hunks)src/spider/core/TaskContextImpl.hpp(1 hunks)src/spider/core/TaskGraph.hpp(4 hunks)src/spider/core/TaskGraphImpl.hpp(3 hunks)src/spider/io/msgpack_message.cpp(2 hunks)src/spider/io/msgpack_message.hpp(1 hunks)src/spider/scheduler/FifoPolicy.cpp(2 hunks)src/spider/scheduler/FifoPolicy.hpp(0 hunks)src/spider/scheduler/SchedulerMessage.hpp(0 hunks)src/spider/scheduler/SchedulerPolicy.hpp(1 hunks)src/spider/scheduler/SchedulerServer.cpp(1 hunks)src/spider/scheduler/SchedulerServer.hpp(0 hunks)src/spider/scheduler/scheduler.cpp(2 hunks)src/spider/storage/DataStorage.hpp(1 hunks)src/spider/storage/MetadataStorage.hpp(1 hunks)src/spider/storage/StorageConnection.hpp(0 hunks)src/spider/storage/StorageFactory.hpp(1 hunks)src/spider/storage/mysql/MySqlConnection.cpp(1 hunks)src/spider/storage/mysql/MySqlConnection.hpp(1 hunks)src/spider/storage/mysql/MySqlJobSubmissionBatch.cpp(0 hunks)src/spider/storage/mysql/MySqlJobSubmissionBatch.hpp(0 hunks)src/spider/storage/mysql/MySqlStorage.cpp(5 hunks)src/spider/storage/mysql/MySqlStorage.hpp(5 hunks)src/spider/storage/mysql/MySqlStorageFactory.cpp(2 hunks)src/spider/storage/mysql/MySqlStorageFactory.hpp(1 hunks)src/spider/utils/LruCache.hpp(0 hunks)src/spider/worker/DllLoader.cpp(0 hunks)src/spider/worker/DllLoader.hpp(0 hunks)src/spider/worker/FunctionManager.cpp(2 hunks)src/spider/worker/FunctionManager.hpp(4 hunks)src/spider/worker/FunctionNameManager.cpp(0 hunks)src/spider/worker/FunctionNameManager.hpp(0 hunks)src/spider/worker/Process.cpp(0 hunks)src/spider/worker/Process.hpp(0 hunks)src/spider/worker/TaskExecutor.cpp(1 hunks)src/spider/worker/TaskExecutor.hpp(0 hunks)src/spider/worker/TaskExecutorMessage.hpp(0 hunks)src/spider/worker/WorkerClient.cpp(1 hunks)src/spider/worker/WorkerClient.hpp(1 hunks)src/spider/worker/message_pipe.cpp(1 hunks)src/spider/worker/message_pipe.hpp(1 hunks)src/spider/worker/task_executor.cpp(0 hunks)src/spider/worker/worker.cpp(7 hunks)taskfile.yaml(1 hunks)test-tasks.yaml(1 hunks)tests/client/client-test.cpp(0 hunks)tests/client/test-Driver.cpp(0 hunks)tests/io/test-MsgpackMessage.cpp(0 hunks)tests/scheduler/test-SchedulerServer.cpp(0 hunks)tests/storage/StorageTestHelper.hpp(0 hunks)tests/storage/test-DataStorage.cpp(0 hunks)tests/storage/test-MetadataStorage.cpp(2 hunks)tests/utils/CoreDataUtils.hpp(0 hunks)tests/utils/CoreTaskUtils.cpp(0 hunks)tests/utils/CoreTaskUtils.hpp(0 hunks)tests/worker/test-Process.cpp(0 hunks)tests/worker/test-TaskExecutor.cpp(1 hunks)tools/yscope-dev-utils(1 hunks)
💤 Files with no reviewable changes (36)
- src/spider/worker/DllLoader.hpp
- src/spider/worker/Process.hpp
- src/spider/client/task.hpp
- src/spider/core/Error.hpp
- src/spider/scheduler/SchedulerServer.hpp
- src/spider/scheduler/SchedulerMessage.hpp
- src/spider/worker/task_executor.cpp
- src/spider/storage/mysql/MySqlJobSubmissionBatch.hpp
- src/spider/worker/DllLoader.cpp
- src/spider/worker/FunctionNameManager.cpp
- tests/utils/CoreTaskUtils.hpp
- tests/utils/CoreDataUtils.hpp
- src/spider/worker/TaskExecutor.hpp
- src/spider/core/DataImpl.hpp
- src/spider/scheduler/FifoPolicy.hpp
- tests/client/test-Driver.cpp
- src/spider/client/type_utils.hpp
- src/spider/core/Data.hpp
- src/spider/core/JobMetadata.hpp
- src/spider/client/TaskContext.cpp
- src/spider/worker/FunctionNameManager.hpp
- src/spider/worker/TaskExecutorMessage.hpp
- src/spider/utils/LruCache.hpp
- src/spider/client/Driver.cpp
- src/spider/storage/StorageConnection.hpp
- tests/scheduler/test-SchedulerServer.cpp
- tests/utils/CoreTaskUtils.cpp
- src/spider/client/Data.hpp
- tests/worker/test-Process.cpp
- src/spider/core/Driver.hpp
- src/spider/storage/mysql/MySqlJobSubmissionBatch.cpp
- src/spider/worker/Process.cpp
- tests/io/test-MsgpackMessage.cpp
- tests/storage/test-DataStorage.cpp
- tests/client/client-test.cpp
- tests/storage/StorageTestHelper.hpp
🧰 Additional context used
🧬 Code Definitions (6)
src/spider/scheduler/scheduler.cpp (1)
src/spider/storage/MetadataStorage.hpp (16)
conn(27-27)conn(29-29)conn(30-30)conn(32-33)conn(37-40)conn(42-48)conn(50-51)conn(53-54)conn(56-57)conn(59-63)conn(66-67)conn(69-73)conn(75-75)conn(76-76)conn(77-78)conn(80-80)
src/spider/storage/mysql/MySqlConnection.cpp (1)
src/spider/storage/mysql/MySqlConnection.hpp (1)
url(34-35)
src/spider/worker/WorkerClient.cpp (1)
src/spider/worker/WorkerClient.hpp (1)
fail_task_id(34-35)
src/spider/storage/DataStorage.hpp (1)
src/spider/storage/MetadataStorage.hpp (16)
conn(27-27)conn(29-29)conn(30-30)conn(32-33)conn(37-40)conn(42-48)conn(50-51)conn(53-54)conn(56-57)conn(59-63)conn(66-67)conn(69-73)conn(75-75)conn(76-76)conn(77-78)conn(80-80)
src/spider/core/Task.hpp (2)
src/spider/core/Data.hpp (8)
Data(14-14)Data(16-16)Data(16-16)Data(18-18)nodiscard(20-20)nodiscard(22-22)nodiscard(24-26)nodiscard(28-28)src/spider/core/TaskGraph.hpp (8)
nodiscard(54-59)nodiscard(61-66)nodiscard(68-77)nodiscard(79-88)nodiscard(91-94)nodiscard(98-100)nodiscard(102-104)nodiscard(110-113)
src/spider/storage/MetadataStorage.hpp (6)
src/spider/client/Job.hpp (2)
conn(180-198)status(91-123)src/spider/core/Task.hpp (4)
client_id(148-148)client_id(148-148)id(186-186)id(186-186)src/spider/storage/mysql/MySqlStorage.hpp (1)
batch(127-132)src/spider/core/TaskGraph.hpp (12)
id(54-54)id(61-61)id(68-69)id(79-80)id(106-106)id(106-106)id(108-108)id(108-108)task(22-38)task(22-22)task(41-48)task(41-41)src/spider/client/Driver.hpp (1)
job_ids(309-317)src/spider/core/TaskGraphImpl.hpp (2)
task(322-344)task(322-322)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: non-storage-unit-tests (ubuntu-24.04)
- GitHub Check: non-storage-unit-tests (ubuntu-22.04)
- GitHub Check: lint
🔇 Additional comments (85)
taskfile.yaml (1)
9-9: Updated Include Path for Utils
The include path for theutilstask has been updated to"tools/yscope-dev-utils/exports/taskfiles/utils/utils.yaml", in line with the restructured directory layout in the updatedyscope-dev-utils. Please verify that all references to this file elsewhere in the project have been adjusted accordingly.test-tasks.yaml (3)
64-67: Consistent Variable Naming for Checksum Validation
The task:utils:checksum:validatenow utilises theINCLUDE_PATTERNSvariable with the value["{{.OUTPUT_DIR}}"]. This update is consistent with the new naming conventions introduced in the project. Ensure that any downstream tasks referencing these variables are updated accordingly.
69-73: Updated Venv Creation Command
The:utils:misc:create-venvtask has been updated with theLABELnow set to"lint"and theREQUIREMENTS_FILEpointing to"{{.ROOT_DIR}}/lint-requirements.txt". This change aligns the environment setup with linting requirements instead of test-related ones. Confirm that no other tasks depend on the previous test requirements file.
75-78: Checksum Compute Task Update
The task:utils:checksum:computenow includes theINCLUDE_PATTERNSconfiguration, which matches the styling used in other tasks. This change maintains consistency across the checksum tasks.lint-tasks.yaml (5)
35-35: Updated Path for C++ Configuration Files
Thecpp-configstask now points to"tools/yscope-dev-utils/exports/lint-configs/symlink-cpp-lint-configs.sh", reflecting the new directory structure inyscope-dev-utils. Ensure that this file exists at the specified location and that all dependent tasks are updated to use this path.
47-64: Refined C++ Formatting Check Task
Thecpp-format-checktask has been modified to use the:utils:cpp-lint:clang-formatcommand with the--dry-runflag. The updatedINCLUDE_FILENAME_PATTERNSandROOT_PATHS(referencing the wildcard patterns) should broaden the scope of files being checked. Please verify that these patterns cover all the necessary file types in your project.
66-74: Refined C++ Formatting Fix Task
Thecpp-format-fixtask now mirrors the check task by using the-iflag for in-place fixes via:utils:cpp-lint:clang-format. Confirm that the file pattern configurations remain appropriate for the project's file structure.
150-150: Updated YAMLLint Configuration Path
Theymltask now references the updated configuration file"tools/yscope-dev-utils/exports/lint-configs/.yamllint.yml". This change ensures consistency with the new exports directory.
202-216: Updated Lint Venv and Checksum Tasks
The lint virtual environment task has been updated as follows:
- The checksum validation task now uses
INCLUDE_PATTERNSwith the output directory.- The venv creation task (
:utils:misc:create-venv) now setsLABELto"lint"and uses"{{.ROOT_DIR}}/lint-requirements.txt".- The checksum computation task similarly adopts the new
INCLUDE_PATTERNSvariable.These changes standardise variable naming and task configurations in line with recent updates. Please ensure compatibility with the CI/CD pipeline.
tools/yscope-dev-utils (1)
1-1: Subproject Commit Update ConfirmedThe subproject commit has been updated to
d22183ffa3fb95745b012eb38a6e13b7e5f06fcaas per the new dependency requirements. This update aligns well with the updatedclang-formatrules and overall objectives of the PR.src/spider/worker/TaskExecutor.cpp (1)
129-137: Formatting update inget_errormethod.
The reformatting of the.value_or()chain and tuple construction now adheres better to the updated clang-format rules, making the code easier to read while leaving the functionality intact.tests/storage/test-MetadataStorage.cpp (1)
1-562: Overall formatting improvements in test cases.
The adjustments to line breaks, indentation, and blank line removals significantly improve readability and consistency across the test file. The logic of the tests remains unchanged.🧰 Tools
🪛 Cppcheck (2.10-2)
[error] 74-74: syntax error
(syntaxError)
src/spider/worker/WorkerClient.hpp (1)
34-36: Refined method signature forget_next_task.
Consolidating the parameter list into a single line improves clarity and consistency with our formatting guidelines. There are no behavioural changes.src/spider/scheduler/scheduler.cpp (2)
93-95: Improved formatting for connection retrieval inheartbeat_loop.
The restructured multiline use ofstd::moveandstd::getenhances readability while preserving the original logic of obtaining the storage connection.
131-133: Enhanced clarity incleanup_loopstorage connection assignment.
The revised formatting for retrieving the storage connection usingstd::movenow fits the updated style guidelines, with no impact on functionality.src/spider/storage/mysql/MySqlStorageFactory.hpp (1)
22-23: Consistent signature formatting inprovide_storage_connection.
Joining the method name with its return type into a single line improves the overall clarity of the declaration. This is a cosmetic change that maintains the method’s functionality.src/spider/worker/message_pipe.hpp (1)
16-17: Reformatted Function Signature Improves Readability.
The updated layout for thereceive_message_asyncfunction declaration — where the parameter and return type now appear on a single line — cleanly adheres to the new clang-format rules while preserving the original functionality.src/spider/client/Job.hpp (1)
1-351: Cosmetic Formatting Adjustments in Job.hpp.
The modifications that reformat exception throw statements (e.g. inwait_complete()andget_status()) enhance overall readability. These changes are cosmetic only and maintain the intended logic and functionality.src/spider/worker/message_pipe.cpp (1)
87-143: Consistent Reformatting for Async Message Reception.
The revised formatting of thereceive_message_asyncfunction signature (lines 87–88) as well as the overall asynchronous read logic improves clarity without altering the execution logic. All asynchronous operations and error handling remain correct.tests/worker/test-TaskExecutor.cpp (2)
1-33: Cosmetic Adjustments in Test File.
Overall formatting improvements—including changes to theget_environment_variablefunction signature—enhance readability. These adjustments are strictly cosmetic and do not affect the underlying test logic or outcomes.
35-37: Enhanced Template Parameter Formatting.
The splitting of the template parameters for the return type ofget_environment_variableonto separate lines (lines 35–37) makes the code easier to read and maintain, aligning with the updated clang-format style.src/spider/storage/mysql/MySqlConnection.cpp (1)
19-20: Reformatted MySqlConnection::create Signature for Consistency.
Consolidating the function signature into a single line improves clarity while matching the declaration in the corresponding header. The functional behaviour remains unchanged, and the new formatting aligns well with project conventions.src/spider/scheduler/SchedulerPolicy.hpp (1)
19-21: Formatting Update forschedule_nextMethod Signature.
The updated formatting of the virtual function declaration improves readability and maintains consistency with the new clang-format rules. No functional changes have been introduced.src/spider/scheduler/SchedulerServer.cpp (1)
117-118: Reformattedprocess_messageSignature.
The changes clearly separate the return type onto a new line, which enhances readability without modifying the method’s functionality.src/spider/io/msgpack_message.cpp (2)
140-142: Enhanced Readability forread_ext_body_sizeCall.
The reformatting on these lines makes the call toread_ext_body_sizeclearer. Functionality remains unchanged as the logic is intact.
167-263: Reformattedreceive_message_asyncFunction.
The function signature and body were reformatted to improve the overall code clarity and consistency with the project’s formatting rules. There are no behavioural changes.src/spider/core/TaskContextImpl.hpp (1)
29-37: Consistent Formatting for Getter Methods.
The updated formatting for bothget_metadata_storeandget_storage_factoryaligns with the new style guidelines and retains the original functionality.src/spider/io/msgpack_message.hpp (1)
20-21: Reformatted Declaration ofreceive_message_async.
This change consolidates the function declaration into a more concise and consistent format with the rest of the codebase. No functional modifications are present.src/spider/worker/FunctionManager.cpp (2)
17-18: Consistent formatting inresponse_get_errorsignature.
The refactoring unifies the return type with the function declaration, improving readability without affecting functionality.
66-67: Improved formatting inresponse_get_result_bufferssignature.
Aligning the return type on the same line enhances consistency across the codebase and follows the updated clang-format conventions.src/spider/scheduler/FifoPolicy.cpp (2)
28-30: Enhanced signature formatting forschedule_next.
Changing the signature to a single-line format increases clarity and ensures consistency with other functions in the project.
43-44: Consistent declaration formatting forpop_next_task.
This cosmetic update simplifies the method declaration without altering its functionality, contributing to uniform style throughout the codebase.src/spider/storage/StorageFactory.hpp (2)
18-20: Streamlined signature forprovide_storage_connection.
Placing the return type on the same line as the function name improves readability and aligns with formatting standards used in other parts of the code.
21-23: Refined formatting forprovide_job_submission_batch.
The unified declaration enhances consistency across the storage interface definitions, making the code easier to read and maintain.src/spider/worker/WorkerClient.cpp (1)
44-45: Reformatted signature forget_next_task.
Removing the extraneous line break results in a cleaner, single-line method signature that is consistent with its header declaration.src/spider/storage/mysql/MySqlStorage.cpp (3)
872-882: Improved Formatting ofparse_timestamp
The reformatting of theparse_timestampfunction now presents the signature and return type in a clear, consistent manner. The logic remains unchanged, and the updated formatting aligns well with the new clang-format rules.
1412-1469: Reformattedcreate_task_instanceMethod
Thecreate_task_instancemethod has been carefully reformatted to enhance readability and bring consistency across the codebase. The function’s logic is untouched, so this change purely improves the visual structure and maintainability.
2248-2252: Refined SQL Query Formatting inremove_dangling_data
The edited segment in theremove_dangling_datamethod now uses a cleaner layout for the SQL query. This makes the query easier to read and maintain, without affecting its functionality.src/spider/storage/mysql/MySqlConnection.hpp (2)
34-36: Consistent Method Signature forcreate
The updated signature for thecreatemethod now conforms to the project's formatting guidelines. Presenting the return type immediately following the parameter list helps improve clarity and consistency.
37-39: Constructor Formatting Revision
TheMySqlConnectionconstructor has been reformatted to remove the extraneous semicolon and to use a braced initializer. This minor change enhances consistency and adheres to the updated code style guidelines.src/spider/core/TaskGraphImpl.hpp (3)
31-32: The formatting update looks good.The method signature formatting has been updated to align the arrow and return type with the method name, which improves readability.
102-106: The function call formatting looks consistent.The multi-line formatting for the
set_data_idcall with the closing parenthesis on its own line follows the updated code style.
136-137: Method signature formatting updated appropriately.This change maintains consistency with the other method signature formatting in the file.
src/spider/storage/mysql/MySqlStorageFactory.cpp (2)
28-29: Method signature formatting looks good.The method signature has been updated to follow the consistent style pattern with the return type arrow on a new line.
38-39: Method signature formatting is consistent.This formatting change aligns with the updated style guidelines and matches other method signatures in the codebase.
src/spider/client/Driver.hpp (2)
186-187: Method signature formatting is appropriately updated.The formatting change for the templated
startmethod improves readability by aligning the return type arrow on a new line.
250-251: Consistent method signature formatting.The formatting of this overloaded
startmethod now matches the style of the first one, maintaining consistency throughout the file.src/spider/core/TaskGraph.hpp (4)
68-69: Method signature formatting updated correctly.The
get_child_tasksmethod signature has been reformatted to follow the consistent code style.
79-80: Consistent method signature formatting.The formatting change for
get_parent_tasksmatches the updated style guidelines.
91-92: Method signature formatting looks good.The formatting of the
get_tasksmethod signature now aligns with the project's code style.
110-111: Method signature formatting is consistent.The
get_dependenciesmethod signature formatting has been updated to match the style used throughout the codebase.src/spider/client/TaskContext.hpp (2)
132-138: Formatting Update forstart(TaskFunction) Method:
The function signature for starting a task (using a TaskFunction) has been reformatted so that the return type is cleanly aligned with the method name and parameters. This enhances readability while preserving functionality.
190-226: Formatting Update forstart(TaskGraph) Method:
The signature for starting a task graph now aligns the return type with the rest of the declaration. This consistent formatting improves maintainability without altering the logic.src/spider/worker/FunctionManager.hpp (4)
90-92: Consistent Formatting forresponse_get_error:
The updated declaration now places the return type on a new line with proper alignment. This minor reformatting increases clarity while maintaining the original functionality.
164-166: Reformattedresponse_get_result_buffers:
The return type has been realigned for consistency with other function declarations. This change is purely cosmetic and improves code readability.
220-231: Updated Overloadedcreate_args_requestSignature:
Moving the return type to a new aligned line enhances clarity and consistency across the file. No functional changes have been introduced.
238-240: Formatting Update forapplyin FunctionInvoker:
The refactored function signature now has its return type separated and aligned, which improves readability. The core logic remains unaffected.src/spider/core/Task.hpp (4)
21-29: Formatting Update for TaskInput Constructors:
The constructors forTaskInputhave been reformatted to use brace-enclosed definitions (with{}) instead of trailing semicolons. This change results in a cleaner and more consistent style.
31-33: Consistent Constructor Formatting in TaskInput:
The explicit constructor handling aboost::uuids::uuidnow unambiguously sets bothm_data_idandm_type. This minor reformatting improves overall code clarity.
35-39: Reformattedget_task_outputMethod:
The method declaration now places the return type on the same line as the method declaration, fostering consistency and easier comprehension.
150-153: Updated Formatting forset_job_creation_time:
The signature for setting the job creation time is now formatted with the return type aligned on the same line. This adjustment improves uniformity with other method declarations.src/spider/worker/worker.cpp (6)
82-84: Reformatted Return Type forget_environment_variable:
The return type declaration now spans multiple, aligned lines. This consistency with updated clang-format rules aids readability across the file.
123-125: Clearer Connection Retrieval inheartbeat_loop:
Splitting thestd::moveandstd::getcall over several lines clarifies the connection extraction process without affecting functionality.
144-146: Reformattedfetch_taskFunction Signature:
Reorganising the function signature to separate the function name from the return type enhances clarity and aligns with the overall formatting improvements.
160-161: Consistent Signature Formatting forget_args_buffers:
The adjusted declaration now aligns the return type on a new line. This maintains uniformity with similar functions and improves code clarity.
191-193: Updated Formatting forparse_outputs:
The refactored signature with the return type aligned on a new line makes the declaration more legible without causing any functional changes.
437-439: Consistent Connection Retrieval inmain:
Breaking up thestd::moveandstd::getcalls into separate lines creates a clearer, more maintainable connection retrieval.src/spider/storage/DataStorage.hpp (9)
25-28: Reformatted Signature foradd_driver_data:
The updated formatting aligns the return type on its own line, enhancing clarity and consistency with other virtual method declarations.
29-32: Reformatted Signature foradd_task_data:
Changing to a multi-line declaration with aligned return type improves readability without altering the underlying functionality.
37-40: Reformatted Signature foradd_task_reference:
The new formatting style clearly separates parameters and the return type, which assists in long-term maintainability.
41-46: Reformatted Signature forremove_task_reference:
Aligning the return type with the closing parenthesis improves the overall consistency of the virtual method declarations.
47-52: Reformatted Signature foradd_driver_reference:
The method signature has been updated to a multi-line format that enhances clarity while preserving its original intent.
53-58: Reformatted Signature forremove_driver_reference:
This adjustment aligns the parameters and return type neatly, contributing to a uniform code style in the abstract class.
61-62: Reformatted Signature foradd_client_kv_data:
The declaration now features a neatly aligned return type, which aids in consistent code style without any functional changes.
65-71: Reformatted Signature forget_client_kv_data:
The multi-line format for this method improves readability by clearly separating the parameters from the return type.
72-78: Reformatted Signature forget_task_kv_data:
Aligning the return type and parameters in a multi-line declaration furthers consistency across similar methods, raising overall code clarity.src/spider/storage/mysql/MySqlStorage.hpp (8)
78-79: Reformatting of 'get_task' Signature
The method signature forget_taskhas been consolidated into a single line, which is in keeping with the new clang-format guidelines. Please ensure this formatting style is used consistently across similar methods in the codebase.
87-88: Reformatting of 'add_task_instance' Signature
The signature foradd_task_instancehas been reformatted to a more compact, single-line structure. This cosmetic change does not affect functionality and adheres to the updated clang-format rules.
100-102: Reformatting of 'get_child_tasks' Signature
Theget_child_tasksmethod signature has been adjusted to reduce unnecessary line breaks. This reformatting improves readability while preserving the original functionality.
106-108: Reformatting of 'heartbeat_timeout' Signature
The layout for theheartbeat_timeoutmethod has been updated to spread the signature over multiple lines, enhancing clarity. No changes to the business logic have been made.
111-116: Reformatting of Scheduler Methods
Both theget_scheduler_addrandset_scheduler_statemethod signatures have been reformatted according to the new clang-format rules. This update improves consistency and readability across the scheduler-related interfaces.
133-134: Reformatting of 'fetch_full_task' Function
The private static functionfetch_full_tasknow utilizes a concise, single-line signature format. This change is purely cosmetic and aligns with the updated formatting standards.
151-152: Reformatting of 'get_data' Signature
In theMySqlDataStoragesection, theget_datamethod signature has been reformatted to match the new style guidelines. All changes are aesthetic and do not alter the underlying logic.
175-176: Reformatting of 'add_client_kv_data' Signature
Theadd_client_kv_datamethod has been updated to a more succinct signature format as per the new clang-format rules. This enhances consistency across the storage interfaces without impacting functionality.src/spider/storage/MetadataStorage.hpp (1)
31-138: Uniform Reformatting of Method Signatures
All changed segments in this file reflect a systematic reformatting of method signatures—fromadd_schedulertoset_scheduler_state—to comply with the updated clang-format rules introduced by the newyscope-dev-utilsversion. These alterations are purely cosmetic. Please verify that the revised formatting aligns with the overall project style guidelines and maintains readability in all storage interfaces.
davidlion
changed the title
yscope-dev-utils version and reformat source filesyscope-dev-utils and apply latest clang-format settings.
2 participants
Description
This pr updates
yscope-dev-utilsdependency tod22183ffa3fb95745b012eb38a6e13b7e5f06fca. The new version ofyscope-dev-utilsintroduces newclang-formatrules, so we reformat the source files accordingly. This pr also uses the newclang-formattask provided byyscope-dev-utils.Checklist
breaking change.
Validation performed
clang-format-checkpass in dev containerSummary by CodeRabbit
clang-formattool to version>=20.1.0for improved code formatting.