Skip to content

fix: Scheduler fetch task when no task to schedule #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sitaowang1998 merged 1 commit into from
Mar 28, 2025
Merged

fix: Scheduler fetch task when no task to schedule #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/spider/scheduler/FifoPolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "FifoPolicy.hpp"

#include <algorithm>
#include <cstddef>
#include <iterator>
#include <memory>
#include <optional>
Expand Down Expand Up @@ -29,12 +30,20 @@ auto FifoPolicy::schedule_next(
boost::uuids::uuid const /*worker_id*/,
std::string const& worker_addr
) -> std::optional<boost::uuids::uuid> {
if (m_tasks.empty()) {
fetch_tasks();
if (m_tasks.empty()) {
return std::nullopt;
}
std::optional<boost::uuids::uuid> const next_task = pop_next_task(worker_addr);
if (next_task.has_value()) {
return next_task;
}
size_t const num_tasks = m_tasks.size();
fetch_tasks();
if (m_tasks.size() == num_tasks) {
return std::nullopt;
}
return pop_next_task(worker_addr);
}

auto FifoPolicy::pop_next_task(std::string const& worker_addr
) -> std::optional<boost::uuids::uuid> {
auto const reverse_begin = std::reverse_iterator(m_tasks.end());
auto const reverse_end = std::reverse_iterator(m_tasks.begin());
auto const it
Expand Down
2 changes: 2 additions & 0 deletions src/spider/scheduler/FifoPolicy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ class FifoPolicy final : public SchedulerPolicy {
private:
auto fetch_tasks() -> void;

auto pop_next_task(std::string const& worker_addr) -> std::optional<boost::uuids::uuid>;

std::shared_ptr<core::MetadataStorage> m_metadata_store;
std::shared_ptr<core::DataStorage> m_data_store;
std::shared_ptr<core::StorageConnection> m_conn;
Expand Down