fix: Add ${CMAKE_DL_LIBS} to linking flags for task worker and task executor.

[gibber9809]

Description

When trying to build spider using g++-11 I found that the task executor and task worker could not build because they were missing symbols for dlopen and dlclose during linking. According to the cmake docs the CMAKE_DL_LIBS variable holds the appropriate linking flags to maker sure dlopen and dlcose are available.

I found some sources claiming that newer versions of libc contain these symbols directly (instead of them being in libdl as with my g++-11 based toolchain), so that may have been hiding this issue previously.

Checklist

• The PR satisfies the contribution guidelines.
• This is a breaking change and that has been indicated in the PR title, OR this isn't a
  breaking change.
• Necessary docs have been updated, OR no docs need to be updated.

Validation performed

• Validated that build now succeeds when compiling with g++-11.

Summary by CodeRabbit

• Chores
  • Updated the build configuration to improve dynamic runtime operations, enhancing system robustness and flexibility. While there are no visible changes to user-facing features, these enhancements contribute to a more stable and reliable experience overall.

[coderabbitai]

Walkthrough

The changes update the CMake configuration for the spider_task_executor and spider_worker executables by adding the ${CMAKE_DL_LIBS} variable to their linking configuration. This update enables the dynamic loading capabilities required during runtime. No other modifications or deletions were made.

Changes

File	Summary
src/spider/CMakeLists.txt	Added ${CMAKE_DL_LIBS} to the target_link_libraries command for both executables

Possibly related PRs

• build: Add dependency between worker and task_executor #53: This PR redefines the spider_worker executable and establishes a dependency on spider_task_executor, affecting the linking process in the same CMakeLists.txt file.

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9df1095 and 8bd2b8f.

📒 Files selected for processing (1)

• src/spider/CMakeLists.txt (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: non-storage-unit-tests (ubuntu-24.04)
• GitHub Check: non-storage-unit-tests (ubuntu-22.04)
• GitHub Check: lint

🔇 Additional comments (2)

src/spider/CMakeLists.txt (2)

87-89: Ensure dynamic loading symbols are linked for spider_task_executor.

The addition of ${CMAKE_DL_LIBS} in the target_link_libraries block for spider_task_executor correctly addresses the missing symbols (dlopen and dlclose) encountered with g++-11. The placement right after Boost libraries and prior to spdlog is appropriate.

---

102-105: Ensure dynamic loading symbols are linked for spider_worker.

The inclusion of ${CMAKE_DL_LIBS} in the linking command for spider_worker resolves potential issues with dynamic loading functions. This change aligns with the PR's objective and is correctly placed within the linking order.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.