Skip to content

feat(docker-compose): Remove top level folder in published Docker Compose artifact. - #446

Merged
sitaowang1998 merged 3 commits into
y-scope:mainfrom
sitaowang1998:docker-compose-publish-no-dir
Aug 20, 2026
Merged

feat(docker-compose): Remove top level folder in published Docker Compose artifact.#446
sitaowang1998 merged 3 commits into
y-scope:mainfrom
sitaowang1998:docker-compose-publish-no-dir

Conversation

@sitaowang1998

@sitaowang1998 sitaowang1998 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Background

As pointed out in y-scope/clp#2481 (comment), the Docker Compose artifact puts everything under a spider-compose directory. This might be a surprise to users.

Solution

This PR removes the top level spider-compose folder in the Docker Compose artifact.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Summary by CodeRabbit

  • Bug Fixes
    • Updated Compose artifact publishing to use the correct working directory and file paths.
    • Publishing now reliably includes the Compose file, configuration directory, and environment template.

@sitaowang1998
sitaowang1998 requested a review from a team as a code owner August 19, 2026 20:32
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 73bc7eb7-2f3f-44e8-b19b-7a64b71ee52e

📥 Commits

Reviewing files that changed from the base of the PR and between 4399e64 and 7298bf4.

📒 Files selected for processing (1)
  • taskfiles/docker.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The compose:publish task now runs from the spider-compose directory. Its oras push arguments use paths relative to that directory. The artifact type, reference requirement, and validation dependency remain unchanged.

Changes

Compose publish task

Layer / File(s) Summary
Update compose publish paths
taskfiles/docker.yaml
The task changes its working directory to {{.G_SPIDER_COMPOSE_DIR}} and removes the spider-compose/ prefix from the published artifact paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7298b

This localized change removes the extra top-level directory from the published Docker Compose artifact; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: davidlion

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the top-level folder from the published Docker Compose artifact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sitaowang1998
sitaowang1998 merged commit 94455ee into y-scope:main Aug 20, 2026
26 checks passed
@sitaowang1998
sitaowang1998 deleted the docker-compose-publish-no-dir branch August 20, 2026 04:01
20001020ycx added a commit to 20001020ycx/clp that referenced this pull request Aug 20, 2026
…ment.

Spider's Compose artifact no longer prefixes its layer titles with
`spider-compose/` (y-scope/spider#446), so oras writes into `--output` directly
and the pull no longer has to target the parent directory.

Repoints the pinned digest at the artifact carrying that change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants