Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ edition = "2024"
[workspace.dependencies]
anyhow = "1.0.104"
async-channel = "2.5.0"
async-trait = "0.1.91"
async-trait = "0.1.92"
bincode = "1.3.3"
bytes = "1.12.1"
clap = { version = "4.6.4", features = ["derive"] }
Expand Down
4 changes: 2 additions & 2 deletions components/spider-core/src/types/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ mod tests {
assert_eq!(wire, 0u32.to_le_bytes());

let decoded: Vec<TaskOutput> = TaskOutputsSerializer::deserialize(&wire)?;
assert!(decoded.is_empty());
assert_eq!(decoded, [] as [std::vec::Vec<u8>; 0]);
Ok(())
}

Expand Down Expand Up @@ -801,7 +801,7 @@ mod tests {
fn serialize_from_empty_tuple() -> anyhow::Result<()> {
let wire = TaskOutputsSerializer::from_tuple(&())?;
let payloads: Vec<TaskOutput> = TaskOutputsSerializer::deserialize(&wire)?;
assert!(payloads.is_empty());
assert_eq!(payloads, [] as [std::vec::Vec<u8>; 0]);
Ok(())
}

Expand Down
2 changes: 1 addition & 1 deletion components/spider-storage/src/ready_queue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ mod tests {
let entries = receiver.recv_tasks(5, wait).await?;
let elapsed = start.elapsed();

assert!(entries.is_empty());
assert_eq!(entries, [] as [ReadyQueueEntry<TaskIndex>; 0]);
assert!(
elapsed >= wait,
"recv should block for the full wait duration when no entries arrive",
Expand Down
2 changes: 0 additions & 2 deletions components/spider-storage/tests/scheduling_infra.rs
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ where
}

/// Creates a [`NoopDbConnector`] with default [`JobId`] and [`ResourceGroupId`].
#[must_use]
pub fn noop_db_connector_factory() -> impl DbConnectorFactory<NoopDbConnector> {
async |_: &ValidatedJobSubmission| {
(
Expand Down Expand Up @@ -458,7 +457,6 @@ pub async fn run_workload<DbConnectorType: InternalJobOrchestration + 'static>(
/// # Panics
///
/// Panics if job registration fails.
#[must_use]
pub fn mariadb_db_connector_factory(
storage: MariaDbStorageConnector,
rg_id: ResourceGroupId,
Expand Down
Loading