Skip to content

fix(spider-execution-manager): Send prev_assignment at most once per next_task call (fixes #429). #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinZhihao-723 merged 3 commits into from
Aug 7, 2026
Merged

fix(spider-execution-manager): Send prev_assignment at most once per next_task call (fixes #429). #430

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1399d91
fix(spider-execution-manager): Send `prev_assignment` at most once pe…
jackluo923 Aug 6, 2026
892efa6
test(spider-execution-manager): Drop the `next_task` long-poll regres…
jackluo923 Aug 6, 2026
60203b6
docs(spider-execution-manager): Name `prev_assignment` explicitly in …
jackluo923 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions components/spider-execution-manager/src/client/grpc/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,18 @@ impl SchedulerClient for GrpcSchedulerClient {
async fn next_task(
&self,
em_id: ExecutionManagerId,
prev_assignment: Option<TaskAssignmentRecord>,
mut prev_assignment: Option<TaskAssignmentRecord>,
wait_time_ms: u64,
) -> Result<SchedulerResponse, SchedulerError> {
// Completing an assignment removes it from the scheduler's registry, so `prev_assignment`
// must be sent at most once; every later poll iteration sends `None`.
loop {
let response = self
.connection_pool
.get_client()
.next_task(scheduler::NextTaskRequest {
execution_manager_id: em_id.get(),
prev_assignment: prev_assignment.map(Into::into),
prev_assignment: prev_assignment.take().map(Into::into),
wait_time_ms,
})
.await
Expand Down
Loading