Skip to content

feat(helm)!: Add env/volume injection hooks to the worker Deployment. #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
20001020ycx merged 1 commit into from
Jul 27, 2026
+11 −6
Merged

feat(helm)!: Add env/volume injection hooks to the worker Deployment. #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/deployment/spider-helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: "v2"
name: "spider"
description: "A Helm chart for the Spider Huntsman deployment"
type: "application"
version: "0.1.3"
version: "0.1.4"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
appVersion: "0.1.0"
home: "https://github.com/y-scope/spider"
sources: ["https://github.com/y-scope/spider"]
Expand Down
11 changes: 7 additions & 4 deletions tools/deployment/spider-helm/templates/worker-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,20 @@ spec:
command: ["spider-execution-manager", "--config", "/etc/spider/execution-manager.yaml"]
{{- with .Values.spiderConfig.worker.extra_envs }}
env:
{{- range $name, $value := . }}
- name: {{ $name | quote }}
value: {{ $value | quote }}
{{- end }}
{{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
volumeMounts:
- name: "config"
mountPath: "/etc/spider/execution-manager.yaml"
subPath: "execution-manager.yaml"
readOnly: true
{{- with .Values.spiderConfig.worker.extra_volume_mounts }}
{{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
volumes:
- name: "config"
configMap:
name: {{ include "spider.componentFullname" (dict "root" . "component" "config") }}
{{- with .Values.spiderConfig.worker.extra_volumes }}
{{- tpl (toYaml .) $ | nindent 8 }}
{{- end }}
4 changes: 3 additions & 1 deletion tools/deployment/spider-helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,7 @@ spiderConfig:
task_capacity: 1048576

worker:

@junhaoliao junhaoliao Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future, we can consider adding something like this as well (these days reading secrets from files are as prevalent as from env vars, and it has a few advantages over the env var approach):

    # Mount existing Kubernetes Secret objects in the worker container.
    # Each entry requires `secretName` and `mountPath`; `readOnly` defaults to true.
    extra_secret_mounts: []
       - secretName: "worker-credentials"
         mountPath: "/var/run/secrets/worker"
         defaultMode: 0440
         items:
           - key: "username"
             path: "username"
           - key: "password"
             path: "password"
         readOnly: true

extra_envs: {}
extra_envs: []
extra_volume_mounts: []
extra_volumes: []
replicas: 4
Loading