Skip to content

fix(gh-workflow): Use install-dev-wolf.sh for the lint-python for libmariadb-dev installation. - #386

Merged
LinZhihao-723 merged 1 commit into
y-scope:mainfrom
20001020ycx:ci/2026-07-10-lint-python-libmariadb
Jul 10, 2026
Merged

fix(gh-workflow): Use install-dev-wolf.sh for the lint-python for libmariadb-dev installation.#386
LinZhihao-723 merged 1 commit into
y-scope:mainfrom
20001020ycx:ci/2026-07-10-lint-python-libmariadb

Conversation

@20001020ycx

@20001020ycx 20001020ycx commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

When running task lint:py-check, CI job fails with OSError: mariadb_config not found. if built without any cache. This is because install-dev-common.sh does not include libmariadb-dev.

Why it passed before but breaks now: This is a long-standing latent gap, not a recent upstream/runner change. We never hit it because the setup-uv cache served a pre-built mariadb wheel — until caught bt #383 which edited requirements-dev.txt, invalidating the cache and forcing uv to rebuild mariadb from source (which needs the missing mariadb_config).

This change points lint-python at install-dev-wolf.sh, which installs libmariadb-dev.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Reproduced on a branch whose requirements-dev.txt edit forced the cold-cache path, toggling only the installer script:

All jobs on the "after" run completed successfully (15/15 checks green: lint-python, lint-cpp, lint-rust, lint-common, huntsman-tests, wolf-tests, build-and-push, and the code-generation checks).

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@20001020ycx 20001020ycx changed the title ci: Use install-dev-wolf.sh for the lint-python job to provide libmariadb-dev. fix: Use install-dev-wolf.sh for the lint-python job to provide libmariadb-dev. Jul 10, 2026
@20001020ycx 20001020ycx changed the title fix: Use install-dev-wolf.sh for the lint-python job to provide libmariadb-dev. fix(taskfiles): Use install-dev-wolf.sh for the lint-python job to provide libmariadb-dev. Jul 10, 2026
@20001020ycx
20001020ycx marked this pull request as ready for review July 10, 2026 16:39
@20001020ycx
20001020ycx requested review from a team and sitaowang1998 as code owners July 10, 2026 16:39
@LinZhihao-723 LinZhihao-723 changed the title fix(taskfiles): Use install-dev-wolf.sh for the lint-python job to provide libmariadb-dev. fix(gh-workflow): Use install-dev-wolf.sh for the lint-python for libmariadb-dev installation. Jul 10, 2026

@LinZhihao-723 LinZhihao-723 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly modified the PR title.

@LinZhihao-723
LinZhihao-723 merged commit d4125c0 into y-scope:main Jul 10, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants