Repository navigation
build(helm): Set up Spider Huntsman Helm chart scaffolding and linting. #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
16b7737
f9b5fc8
aeb7287
a2e6edc
51a562f
ecc2e92
bcc37c9
edb74e7
7890676
3b800c9
d81726b
7bb7d90
51c4020
6233765
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| version: "3" | ||
|
|
||
| set: ["pipefail"] | ||
|
|
||
| includes: | ||
| build: "taskfiles/build.yaml" | ||
| deps: "taskfiles/deps.yaml" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Patterns to ignore when building packages. | ||
| # This supports shell glob matching, relative path matching, and | ||
| # negation (prefixed with !). Only one pattern per line. | ||
| .DS_Store | ||
| # Common VCS dirs | ||
| .bzr/ | ||
| .bzrignore | ||
| .git/ | ||
| .gitignore | ||
| .hg/ | ||
| .hgignore | ||
| .svn/ | ||
| # Common backup files | ||
| *.bak | ||
| *.orig | ||
| *.swp | ||
| *.tmp | ||
| *~ | ||
| # Various IDEs | ||
| *.tmproj | ||
| .idea/ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For RustRover, we probably need to ignore
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, just dived a bit more on the .helmignore: this ignore file is controlling what files are put into the So, I will just use the version inherited from the CLP package for consistency then. |
||
| .project | ||
| .vscode/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| apiVersion: "v2" | ||
| name: "spider" | ||
| description: "A Helm chart for the Spider Huntsman deployment" | ||
| type: "application" | ||
| version: "0.1.0" | ||
| appVersion: "0.1.0" | ||
| home: "https://github.com/y-scope/spider" | ||
| sources: ["https://github.com/y-scope/spider"] | ||
| maintainers: [{name: "y-scope", email: "dev@yscope.com", url: "https://yscope.com"}] | ||
| keywords: | ||
| - "distributed-scheduler" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad.
xxx-checkis an obsolete convention. The latest convention is to usecheck-xxx. For examplecheck-rust. I am ok with both in this PR. @LinZhihao-723 Shall we create a cleanup PR after this one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, thanks for the catch, good to know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually prefer
check-xxx, as we should always use the latest convention when both exist.fyi, Rust linting is called
fix-rustandcheck-rust.