Repository navigation
feat(spider-client): Add user-facing client library for job orchestration and resource group management. #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 16 commits
27c0701
a1ee868
b98b085
b241c34
429fdbb
25fc42d
86fe70a
11381cd
697c49a
24fb358
e0cf5da
391ed65
44c1b81
40c55a9
add524c
ec89ff5
3a3f712
ac3f9da
4e1d1d8
ccdb787
a342b49
dcbefaa
16b7a0e
6b7207e
54b6941
dc83db0
e3cc8d8
78d7726
252fbcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [package] | ||
| name = "spider-client" | ||
| version = "0.1.0" | ||
| edition = "2024" | ||
|
|
||
| [lib] | ||
| name = "spider_client" | ||
| path = "src/lib.rs" | ||
|
|
||
| [dependencies] | ||
| spider-core = { path = "../spider-core" } | ||
| spider-proto-rust = { path = "../spider-proto-rust" } | ||
| spider-utils = { path = "../spider-utils" } | ||
| thiserror = "2.0.18" | ||
| tonic = "0.14.6" | ||
|
|
||
| [dev-dependencies] | ||
| anyhow = "1.0.102" | ||
| async-trait = "0.1.89" | ||
| tokio = { version = "1.52.3", features = ["macros", "net", "rt-multi-thread"] } |
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,202 @@ | ||||
| //! [`SpiderClient`] — the top-level handle holding the gRPC connection pools. | ||||
|
|
||||
| use std::num::NonZeroUsize; | ||||
|
|
||||
| use spider_core::{ | ||||
| job::JobState, | ||||
| task::TaskGraph, | ||||
| types::{ | ||||
| id::{JobId, ResourceGroupId}, | ||||
| io::{TaskInput, TaskOutput}, | ||||
| }, | ||||
| }; | ||||
| use tonic::transport::Endpoint; | ||||
|
|
||||
| use crate::{ | ||||
| error::ClientError, | ||||
| job::JobOrchestrationClient, | ||||
| resource_group::ResourceGroupManagementClient, | ||||
| }; | ||||
|
|
||||
| /// User-facing client for the Spider storage gRPC services. | ||||
| /// | ||||
| /// Wraps a [`JobOrchestrationClient`] and a [`ResourceGroupManagementClient`] against the same | ||||
| /// storage endpoint, so callers who need both job-lifecycle and resource-group operations get a | ||||
| /// single handle and one [`SpiderClient::connect`] call. Callers who need only one service may | ||||
| /// construct the inner client directly. | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the actual user-facing type. I don't think user needs to know about the underlying client types, right? |
||||
| #[derive(Debug, Clone)] | ||||
| pub struct SpiderClient { | ||||
| job_orchestration: JobOrchestrationClient, | ||||
| resource_group: ResourceGroupManagementClient, | ||||
| } | ||||
|
|
||||
| impl SpiderClient { | ||||
| /// Connects pools of `pool_size` connections to the storage gRPC endpoint. | ||||
| /// | ||||
| /// Both the job-orchestration and resource-group-management services are reached through the | ||||
| /// same `endpoint`. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// A new [`SpiderClient`] connected to `endpoint` on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// Returns [`ClientError::Transport`] if tonic cannot establish a connection to `endpoint`. | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Read this again and tell me if this matches the docstring format, lol
|
||||
| pub async fn connect(endpoint: Endpoint, pool_size: NonZeroUsize) -> Result<Self, ClientError> { | ||||
| let job_orchestration = | ||||
| JobOrchestrationClient::connect(endpoint.clone(), pool_size).await?; | ||||
| let resource_group = ResourceGroupManagementClient::connect(endpoint, pool_size).await?; | ||||
|
|
||||
| Ok(Self { | ||||
| job_orchestration, | ||||
| resource_group, | ||||
| }) | ||||
| } | ||||
|
|
||||
| /// Serializes and zstd-compresses the task graph and inputs, registers the job, and returns | ||||
| /// its assigned id. Delegates to [`JobOrchestrationClient::submit_job`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The [`JobId`] the storage server assigned to the registered job on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`JobOrchestrationClient::submit_job`]. | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||
| pub async fn submit_job( | ||||
| &self, | ||||
| resource_group_id: ResourceGroupId, | ||||
| task_graph: &TaskGraph, | ||||
| inputs: Vec<TaskInput>, | ||||
| ) -> Result<JobId, ClientError> { | ||||
| self.job_orchestration | ||||
| .submit_job(resource_group_id, task_graph, inputs) | ||||
| .await | ||||
| } | ||||
|
|
||||
| /// Starts a registered job. Delegates to [`JobOrchestrationClient::start_job`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The job's [`JobState`] after the start request is accepted on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`JobOrchestrationClient::start_job`]. | ||||
| pub async fn start_job(&self, job_id: JobId) -> Result<JobState, ClientError> { | ||||
| self.job_orchestration.start_job(job_id).await | ||||
| } | ||||
|
|
||||
| /// Cancels a job. Delegates to [`JobOrchestrationClient::cancel_job`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The job's [`JobState`] after the cancellation request is accepted on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`JobOrchestrationClient::cancel_job`]. | ||||
| pub async fn cancel_job(&self, job_id: JobId) -> Result<JobState, ClientError> { | ||||
| self.job_orchestration.cancel_job(job_id).await | ||||
| } | ||||
|
|
||||
| /// Gets the current state of a job. Delegates to [`JobOrchestrationClient::get_job_state`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The job's current [`JobState`] on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`JobOrchestrationClient::get_job_state`]. | ||||
| pub async fn get_job_state(&self, job_id: JobId) -> Result<JobState, ClientError> { | ||||
| self.job_orchestration.get_job_state(job_id).await | ||||
| } | ||||
|
|
||||
| /// Gets a job's task outputs. Delegates to [`JobOrchestrationClient::get_job_outputs`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The job's outputs, deserialized from the storage wire format into opaque msgpack payloads, | ||||
| /// on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`JobOrchestrationClient::get_job_outputs`]. | ||||
| pub async fn get_job_outputs(&self, job_id: JobId) -> Result<Vec<TaskOutput>, ClientError> { | ||||
| self.job_orchestration.get_job_outputs(job_id).await | ||||
| } | ||||
|
|
||||
| /// Gets a job's error message. Delegates to [`JobOrchestrationClient::get_job_error`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The job's error message on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`JobOrchestrationClient::get_job_error`]. | ||||
| pub async fn get_job_error(&self, job_id: JobId) -> Result<String, ClientError> { | ||||
| self.job_orchestration.get_job_error(job_id).await | ||||
| } | ||||
|
|
||||
| /// Registers an external resource group and returns its server-assigned id. Delegates to | ||||
| /// [`ResourceGroupManagementClient::add_resource_group`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// The [`ResourceGroupId`] the storage server assigned to the registered resource group on | ||||
| /// success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`ResourceGroupManagementClient::add_resource_group`]. | ||||
| pub async fn add_resource_group( | ||||
| &self, | ||||
| external_resource_group_id: String, | ||||
| password: Vec<u8>, | ||||
| ) -> Result<ResourceGroupId, ClientError> { | ||||
| self.resource_group | ||||
| .add_resource_group(external_resource_group_id, password) | ||||
| .await | ||||
| } | ||||
|
|
||||
| /// Verifies a resource group's password. Delegates to | ||||
| /// [`ResourceGroupManagementClient::verify_resource_group`]. | ||||
| /// | ||||
| /// # Returns | ||||
| /// | ||||
| /// `Ok(())` on success. | ||||
| /// | ||||
| /// # Errors | ||||
| /// | ||||
| /// See [`ResourceGroupManagementClient::verify_resource_group`]. | ||||
| pub async fn verify_resource_group( | ||||
| &self, | ||||
| resource_group_id: ResourceGroupId, | ||||
| password: Vec<u8>, | ||||
| ) -> Result<(), ClientError> { | ||||
| self.resource_group | ||||
| .verify_resource_group(resource_group_id, password) | ||||
| .await | ||||
| } | ||||
| } | ||||
|
|
||||
| #[cfg(test)] | ||||
| mod tests { | ||||
| use super::*; | ||||
|
|
||||
| #[tokio::test] | ||||
| async fn connect_maps_unreachable_endpoint_to_transport_error() -> anyhow::Result<()> { | ||||
| // Port 1 is privileged with no listener, so the eager connect fails immediately with | ||||
| // ECONNREFUSED. The facade propagates the first inner client's transport error. | ||||
| let endpoint = Endpoint::from_static("http://127.0.0.1:1"); | ||||
| let pool_size = NonZeroUsize::new(1).expect("one is nonzero"); | ||||
|
|
||||
| match SpiderClient::connect(endpoint, pool_size).await { | ||||
| Err(ClientError::Transport(_)) => Ok(()), | ||||
| result => panic!("expected transport error, got {result:?}"), | ||||
| } | ||||
| } | ||||
| } | ||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will probably rewrite the docstring in this mod myself since it's user-facing.
But you should really review the docstrings carefully. I don't want to waste more time on catching these types of errors.