-
Notifications
You must be signed in to change notification settings - Fork 12
feat(tdl): Add helper classes for parser error handling. #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| #ifndef SPIDER_TDL_ERROR_HPP | ||
| #define SPIDER_TDL_ERROR_HPP | ||
|
|
||
| #include <optional> | ||
| #include <string> | ||
| #include <string_view> | ||
| #include <system_error> | ||
| #include <utility> | ||
|
|
||
| #include <spider/tdl/parser/SourceLocation.hpp> | ||
|
|
||
| namespace spider::tdl { | ||
| /** | ||
| * Represents a generic error in the TDL compiler. | ||
| */ | ||
| class Error { | ||
| public: | ||
| // Constructor | ||
| Error(std::string message, | ||
| parser::SourceLocation source_location, | ||
| std::optional<std::error_code> error_code = std::nullopt) | ||
| : m_message{std::move(message)}, | ||
| m_source_location{source_location}, | ||
| m_error_code{error_code} {} | ||
|
|
||
| // Methods | ||
| [[nodiscard]] auto get_message() const noexcept -> std::string_view { return m_message; } | ||
|
|
||
| [[nodiscard]] auto get_source_location() const noexcept -> parser::SourceLocation { | ||
| return m_source_location; | ||
| } | ||
|
|
||
| [[nodiscard]] auto get_error_code() const noexcept -> std::optional<std::error_code> { | ||
| return m_error_code; | ||
| } | ||
|
|
||
| private: | ||
| // Variables | ||
| std::string m_message; | ||
| parser::SourceLocation m_source_location; | ||
| std::optional<std::error_code> m_error_code; | ||
| }; | ||
| } // namespace spider::tdl | ||
|
|
||
| #endif // SPIDER_TDL_ERROR_HPP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| #ifndef SPIDER_TDL_PARSER_ERRORLISTENER_HPP | ||
| #define SPIDER_TDL_PARSER_ERRORLISTENER_HPP | ||
|
|
||
| #include <cstddef> | ||
| #include <exception> | ||
| #include <optional> | ||
| #include <string> | ||
| #include <utility> | ||
|
|
||
| #include <antlr4-runtime.h> | ||
| #include <fmt/format.h> | ||
|
|
||
| #include <spider/tdl/Error.hpp> | ||
| #include <spider/tdl/parser/SourceLocation.hpp> | ||
|
|
||
| namespace spider::tdl::parser { | ||
| class ErrorListener : public antlr4::BaseErrorListener { | ||
| public: | ||
| // Constructor | ||
| explicit ErrorListener(std::string tag) : m_tag{std::move(tag)} {} | ||
|
|
||
| // Methods implementing `antlr4::BaseErrorListener` | ||
| auto syntaxError( | ||
| [[maybe_unused]] antlr4::Recognizer* recognizer, | ||
| [[maybe_unused]] antlr4::Token* offending_symbol, | ||
| size_t line, | ||
| size_t char_position_in_line, | ||
| std::string const& msg, | ||
| [[maybe_unused]] std::exception_ptr e | ||
| ) -> void override { | ||
| m_error.emplace( | ||
| fmt::format("{}: {}", m_tag, msg), | ||
| SourceLocation{line, char_position_in_line}, | ||
| std::nullopt | ||
| ); | ||
| } | ||
|
|
||
| // Methods | ||
| [[nodiscard]] auto has_error() const -> bool { return m_error.has_value(); } | ||
|
|
||
| /** | ||
| * @return A reference to the error. The caller must ensure that `has_error()` is true before | ||
| * calling this method. | ||
| */ | ||
| [[nodiscard]] auto error() const -> Error const& { | ||
| // We require the caller to check `has_error()` before calling this method, which ensures | ||
| // the optional var has a value. | ||
| // NOLINTNEXTLINE(bugprone-unchecked-optional-access) | ||
| return m_error.value(); | ||
| } | ||
|
|
||
| private: | ||
| std::string m_tag; | ||
| std::optional<Error> m_error; | ||
| }; | ||
| } // namespace spider::tdl::parser | ||
|
|
||
| #endif // SPIDER_TDL_PARSER_ERRORLISTENER_HPP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.