refactor(taskfiles): Reorganize non-main taskfiles into a single directory. - #200
Conversation
WalkthroughUpdated Taskfile includes to reference files under Changes
Sequence Diagram(s)No sequence diagram — changes are file/path reorganization and documentation updates only, with no control-flow or runtime behavior changes to illustrate. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
taskfile.yaml (1)
4-8: Optional consistency clean-up: align include file locations.Consider moving docs/tasks.yaml into taskfiles/ as well (or conversely keeping all non-main includes in their respective domains) to keep all secondary Taskfiles co-located. This is non-functional and purely for discoverability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
taskfile.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: non-storage-unit-tests (ubuntu-22.04)
- GitHub Check: non-storage-unit-tests (ubuntu-24.04)
- GitHub Check: lint
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
README.md(1 hunks)taskfiles/lint.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- README.md
| lint-tasks.yaml \ | ||
| taskfile.yaml \ | ||
| test-tasks.yaml | ||
| taskfiles/ |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Directory-wide yamllint target looks good; verify there are no lingering “-task.yml” files and that top-level includes align.*
Switching to lint the whole taskfiles/ directory is aligned with the reorg. As a quick consistency check, ensure there are no remaining files using the deprecated “-task” suffix and that the root Taskfile includes reference the new locations.
Run this script from the repo root to verify:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "YAML files under taskfiles/:"
fd -t f -e yaml -e yml '.*' taskfiles | sort
echo
echo "Checking for legacy *-task*.ya?ml files anywhere:"
fd -t f -E .git -E node_modules '(?i).*-tasks?\.ya?ml$' || echo "No legacy *-task*.ya?ml files found."
echo
echo "References to legacy filenames in Taskfiles and docs:"
rg -nP -C2 '(?i)-tasks?\.ya?ml' -g '!**/.git/**' -g '!**/node_modules/**' || echo "No references found."
echo
echo "Root Taskfile references to taskfiles/ entries:"
if [ -f taskfile.yaml ]; then
rg -nP -C2 '(?i)taskfiles/' taskfile.yaml || echo "No explicit references to taskfiles/ found in taskfile.yaml (may be fine if using directory includes elsewhere)."
else
echo "taskfile.yaml not found at repo root."
fiLength of output: 1945
Fix legacy deps-task.yaml references in quick-start guide
Verified no lingering *-task*.ya?ml files under taskfiles/ and root Taskfile includes (taskfiles/build.yaml, taskfiles/deps.yaml, taskfiles/lint.yaml, taskfiles/test.yaml) are correct. However, the user guide still points to the deprecated filename:
• docs/src/user-docs/guides-quick-start.md, line 80:
• Replace link text [deps-task.yaml] with [deps.yaml] (or a direct path to taskfiles/deps.yaml).
• docs/src/user-docs/guides-quick-start.md, line 260:
• Update the link definition from
[deps-task.yaml]: https://github.com/y-scope/spider/blob/main/dep-tasks.yaml
to
[deps.yaml]: https://github.com/y-scope/spider/blob/main/taskfiles/deps.yaml.
🤖 Prompt for AI Agents
In taskfiles/lint.yaml around line 181 (note: the review points to
docs/src/user-docs/guides-quick-start.md lines 80 and 260), update the
quick-start guide to stop referencing the deprecated deps-task.yaml: change the
inline link text at line ~80 from [deps-task.yaml] to [deps.yaml] (or replace it
with the direct path taskfiles/deps.yaml), and change the link definition at
line ~260 from `[deps-task.yaml]:
https://github.com/y-scope/spider/blob/main/dep-tasks.yaml` to `[deps.yaml]:
https://github.com/y-scope/spider/blob/main/taskfiles/deps.yaml` so the guide
points to the correct, current file.
2 participants
Description
As the title suggests. We also drop
-taskfrom the taskfile names since they're now located inside thetaskfiledirectory already.Checklist
breaking change.
Validation performed
Summary by CodeRabbit