Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
d2ac198
Update yscope-dev-utils
sitaowang1998 Jul 15, 2025
cc8a097
Use boost install task
sitaowang1998 Jul 15, 2025
7f68bdc
Update install task variable names
sitaowang1998 Jul 15, 2025
2394649
Set CMP0074 to NEW to find boost
sitaowang1998 Jul 15, 2025
6ff3e33
Add uv to install script
sitaowang1998 Jul 15, 2025
7ae8a78
Fix cpp-lint root paths
sitaowang1998 Jul 15, 2025
56502f9
Fix clang-tidy file pattern
sitaowang1998 Jul 15, 2025
6f6becf
Limit build parallelism
sitaowang1998 Jul 17, 2025
a74523d
Bug fix
sitaowang1998 Jul 17, 2025
2345d22
Merge branch 'dep-concurrency' into yscope-dev-utils
sitaowang1998 Jul 17, 2025
77ee494
Bug fix
sitaowang1998 Jul 17, 2025
38b86c8
Merge branch 'dep-concurrency' into yscope-dev-utils
sitaowang1998 Jul 17, 2025
3698339
Bug fix
sitaowang1998 Jul 17, 2025
369e9f1
Rename variables to mirror CLP core
sitaowang1998 Aug 4, 2025
90aa5a2
Rename variables to mirror clp core
sitaowang1998 Aug 4, 2025
1769c95
Merge branch 'dep-concurrency' of github.com:sitaowang1998/spider int…
sitaowang1998 Aug 4, 2025
edaa834
Merge branch 'dep-concurrency' into yscope-dev-utils
sitaowang1998 Aug 4, 2025
7faac8f
Revert "Merge branch 'dep-concurrency' of github.com:sitaowang1998/sp…
sitaowang1998 Aug 4, 2025
f494a90
Add comment for deps parallelism default value
sitaowang1998 Aug 4, 2025
eb01bb2
Merge branch 'dep-concurrency' into yscope-dev-utils
sitaowang1998 Aug 4, 2025
ff2fe1c
Update yscope-dev-utils
sitaowang1998 Aug 4, 2025
d476e42
Merge branch 'main' into yscope-dev-utils
sitaowang1998 Aug 4, 2025
850126d
Merge branch 'yscope-dev-utils' into python_lint
sitaowang1998 Aug 4, 2025
65841a0
Add latest python lint config files
sitaowang1998 Aug 4, 2025
8564fc2
Update ruff lint tasks
sitaowang1998 Aug 4, 2025
a6e7d29
Fix ruff lint
sitaowang1998 Aug 4, 2025
573b448
Fix ruff lint
sitaowang1998 Aug 4, 2025
6ad72c3
Bug fix
sitaowang1998 Aug 4, 2025
ba7c6e5
Fix ruff
sitaowang1998 Aug 4, 2025
209acb1
Fix ruff
sitaowang1998 Aug 4, 2025
406b514
Reformat files
sitaowang1998 Aug 4, 2025
66892f5
Remove .inc from cpp linting
sitaowang1998 Aug 4, 2025
80f0a10
Merge branch 'yscope-dev-utils' into python_lint
sitaowang1998 Aug 4, 2025
3186a42
Add mypy and merge lint and test requirements.txt
sitaowang1998 Aug 4, 2025
0925938
Fix mysql connection type
sitaowang1998 Aug 4, 2025
6936a9b
Fix socket name type
sitaowang1998 Aug 4, 2025
7407090
Fix return type from db cursor
sitaowang1998 Aug 4, 2025
6a95b24
Fix db cursor return type
sitaowang1998 Aug 4, 2025
f29dcba
Fix mypy import untyped
sitaowang1998 Aug 4, 2025
453f209
Fix mypy and Popen
sitaowang1998 Aug 5, 2025
d1011c7
Fix generator type hint
sitaowang1998 Aug 5, 2025
a7dc642
Fix mypy
sitaowang1998 Aug 5, 2025
a7d92c2
Fix ruff
sitaowang1998 Aug 5, 2025
1c6213b
Simply socket return types.
sitaowang1998 Aug 5, 2025
0f13d07
Merge branch 'main' into python_lint
sitaowang1998 Aug 5, 2025
14d6326
Merge branch 'python_lint' into mypy_lint
sitaowang1998 Aug 5, 2025
55a727a
Add tombi lint tasks
sitaowang1998 Aug 5, 2025
c98fea1
Rename cpp build tasks
sitaowang1998 Aug 5, 2025
ef64454
Merge branch 'main' into mypy_lint
sitaowang1998 Aug 5, 2025
09ba8ad
Merge branch 'main' into tombi
sitaowang1998 Aug 5, 2025
4e7237e
Add basic python structure
sitaowang1998 Aug 5, 2025
1f944d0
Fix code structure
sitaowang1998 Aug 5, 2025
68992fc
Fix ruff lint
sitaowang1998 Aug 5, 2025
1127b22
Extend lint tasks to python directory
sitaowang1998 Aug 5, 2025
4c51c91
Add python build tasks
sitaowang1998 Aug 5, 2025
56878b2
Merge branch 'main' into mypy_lint
sitaowang1998 Aug 5, 2025
bb428c9
Merge branch 'mypy_lint' into tombi
sitaowang1998 Aug 5, 2025
944bd5e
Merge branch 'tombi' into build-task
sitaowang1998 Aug 5, 2025
d75bc15
Merge branch 'build-task' into python_structure
sitaowang1998 Aug 5, 2025
4b7eca2
Merge branch 'main' into tombi
sitaowang1998 Aug 5, 2025
8ddbda7
Merge branch 'tombi' into build-task
sitaowang1998 Aug 5, 2025
0d998ec
Merge branch 'build-task' into python_structure
sitaowang1998 Aug 5, 2025
6004d64
Fix yaml lint error
sitaowang1998 Aug 5, 2025
bcab5db
Fix tombi lint
sitaowang1998 Aug 5, 2025
a50d25a
Remove wrong mypy config
sitaowang1998 Aug 5, 2025
fbebb96
Fix typo and format file
sitaowang1998 Aug 5, 2025
0322bd5
Use typed msgpack and remove mypy config for msgpack from pyproject
sitaowang1998 Aug 6, 2025
2a08155
Update uv lock
sitaowang1998 Aug 6, 2025
0b62f73
Merge branch 'main' into tombi
sitaowang1998 Aug 6, 2025
7384158
Merge branch 'main' into build-task
sitaowang1998 Aug 6, 2025
70ef90a
Merge branch 'main' into python_structure
sitaowang1998 Aug 6, 2025
b09515c
Increase min version of tombi
sitaowang1998 Aug 6, 2025
bad9675
Merge branch 'tombi' into build-task
sitaowang1998 Aug 6, 2025
e009ff4
Merge branch 'tombi' into python_structure
sitaowang1998 Aug 6, 2025
a0407a7
Merge branch 'main' into tombi
sitaowang1998 Aug 6, 2025
aa9a8de
Merge branch 'tombi' into build-task
sitaowang1998 Aug 6, 2025
3c7e794
Merge branch 'tombi' into python_structure
sitaowang1998 Aug 6, 2025
b4d6576
Add uv in README
sitaowang1998 Aug 6, 2025
23f31cd
Merge branch 'main' into build-task
sitaowang1998 Aug 6, 2025
0167ac0
Merge branch 'build-task' into python_structure
sitaowang1998 Aug 6, 2025
f447614
Fix redenduncy caused by merge
sitaowang1998 Aug 6, 2025
a84de83
Merge branch 'build-task' into python_structure
sitaowang1998 Aug 6, 2025
2d1b6fc
Merge branch 'main' into python_structure
sitaowang1998 Aug 7, 2025
061d101
Merge branch 'main' into python_structure
sitaowang1998 Aug 7, 2025
de149ee
Add integral types
sitaowang1998 Aug 7, 2025
d332dbe
Revert "Add integral types"
sitaowang1998 Aug 7, 2025
8c27b16
Restructure under src/spider
sitaowang1998 Aug 8, 2025
95b98c8
Merge branch 'main' into python_structure
sitaowang1998 Aug 8, 2025
427dd6b
Merge branch 'main' into python_structure
sitaowang1998 Aug 8, 2025
854cd11
Fix missing link
sitaowang1998 Aug 8, 2025
5565c9e
Merge branch 'python_structure' of github.com:sitaowang1998/spider in…
sitaowang1998 Aug 8, 2025
01dd0c6
Fix task executor path
sitaowang1998 Aug 8, 2025
e022404
Merge branch 'main' into python_structure
sitaowang1998 Aug 8, 2025
7753153
Merge branch 'main' into python_structure
sitaowang1998 Aug 9, 2025
526482c
Rename project
sitaowang1998 Aug 10, 2025
539738f
Rename project source root to match the new project name
sitaowang1998 Aug 10, 2025
2a36054
Bug fix
sitaowang1998 Aug 10, 2025
05f9c57
Merge branch 'main' into python_structure
sitaowang1998 Aug 12, 2025
2c96e13
Merge branch 'main' into python_structure
sitaowang1998 Aug 13, 2025
bc0c3b1
Add another level spider-py under python dir
sitaowang1998 Aug 13, 2025
af6da1c
Update python src dir
sitaowang1998 Aug 13, 2025
f38feb3
Split python lint tasks
sitaowang1998 Aug 13, 2025
9e61e88
Rename build tasks
sitaowang1998 Aug 13, 2025
eb31097
Add readme and fix pyproject.toml.
LinZhihao-723 Aug 14, 2025
9a05967
Formatting..
LinZhihao-723 Aug 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Follow the steps below to develop and contribute to the project.
## Requirements
* Python 3.10 or higher
* [Task] 3.40.0 or higher
* [uv] 0.7.0 or higher

## Set up
Run dependency installation task:
Expand Down Expand Up @@ -67,3 +68,4 @@ in the table below.

[spider-docs]: https://docs.yscope.com/spider/main/
[Task]: https://taskfile.dev
[uv]: https://docs.astral.sh/uv/
4 changes: 4 additions & 0 deletions build-tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@ tasks:
deps: [":config-cmake-project"]
cmds:
- "cmake --build {{.G_BUILD_SPIDER_DIR}} --target clean --parallel {{numCPU}}"

spider-py:
cmds:
- "uv build --directory {{.G_SRC_PYTHON_DIR}} -o {{.G_BUILD_PYTHON_DIR}}"
26 changes: 26 additions & 0 deletions lint-tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,14 @@ tasks:
- task: "py"
vars:
RUFF_FORMAT_FLAGS: "--diff"
- task: "spider-py-check"

py-fix:
cmds:
- task: "py"
vars:
RUFF_CHECK_FLAGS: "--fix"
- task: "spider-py-fix"

py:
internal: true
Expand All @@ -137,6 +139,30 @@ tasks:
ruff check {{.RUFF_CHECK_FLAGS}} "{{.ITEM}}"
ruff format {{.RUFF_FORMAT_FLAGS}} "{{.ITEM}}"

spider-py-check:
cmds:
- task: "spider-py"
vars:
RUFF_FORMAT_FLAGS: "--diff"

spider-py-fix:
cmds:
- task: "spider-py"
vars:
RUFF_CHECK_FLAGS: "--fix"

spider-py:
internal: true
vars:
RUFF_CHECK_FLAGS: "{{.RUFF_CHECK_FLAGS | default \"\"}}"
RUFF_FORMAT_FLAGS: "{{.RUFF_FORMAT_FLAGS | default \"\"}}"
cmds:
- cmd: |-
cd "{{.G_SRC_PYTHON_DIR}}"
uv run mypy .
uv run ruff check {{.RUFF_CHECK_FLAGS}}
uv run ruff format {{.RUFF_FORMAT_FLAGS}}
Comment thread
sitaowang1998 marked this conversation as resolved.

yml:
aliases:
- "yml-check"
Expand Down
1 change: 1 addition & 0 deletions python/spider-py/.python-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.13
41 changes: 41 additions & 0 deletions python/spider-py/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# spider-py

This project is a Python package that provides access to Spider, a distributed task execution
framework, enabling seamless integration and task management in Python applications.

## Building/Packing

To manually build a package for distribution, follow the steps below.

### Requirements

* [Task] >= 3.40.0
* [uv] >= 0.7.0

Comment on lines +12 to +14

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add Python to the prerequisites to align with project standards.

Per the project’s convention, Python should be documented alongside Task and uv. The repo pins Python to 3.13; make that explicit here.

 ### Requirements
 
 * [Task] >= 3.40.0
 * [uv] >= 0.7.0
+* Python 3.13 (see .python-version)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* [Task] >= 3.40.0
* [uv] >= 0.7.0
* [Task] >= 3.40.0
* [uv] >= 0.7.0
* Python 3.13 (see .python-version)
🤖 Prompt for AI Agents
In python/spider-py/README.md around lines 12 to 14, the prerequisites list
includes Task and uv but omits Python; add an explicit Python entry pinned to
the repo version (Python >= 3.13) alongside the existing entries so the
prerequisites read include Python >= 3.13, Task >= 3.40.0, and uv >= 0.7.0.

### Build Commands

* Build a Python wheel:

```shell
task build:spider-py
```

The command above will generate both a `.tar.gz` and a `.whl` package in the `build/spider-py`
directory at the Spider project root.

## Linting

To run all linting checks:

```shell
task lint:spider-py-check
```

To run all linting checks AND automatically fix any fixable issues:

```shell
task lint:spider-py-fix
```

[Task]: https://taskfile.dev
[uv]: https://docs.astral.sh/uv/
65 changes: 65 additions & 0 deletions python/spider-py/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
[project]
name = "spider-py"
version = "0.0.1"
description = "A distributed task execution framework."
readme = "README.md"
requires-python = ">=3.10"
authors = [
{ name = "Sitao Wang", email = "sitao.wang@yscope.com" },
{ name = "Zhihao Lin", email = "lin.zhihao@yscope.com" },
]
dependencies = [
"mariadb>=1.1.13",
"msgpack-types>=0.5.0",
]

[project.scripts]
spider_task_executor = "spider_py.task_executor.task_executor:main"

[dependency-groups]
dev = [
"mypy>=1.12.0",
"ruff>=0.4.4",
]

[build-system]
requires = ["hatchling>=1.18.0"]
build-backend = "hatchling.build"

[tool.mypy]
strict = true
# Additional output
pretty = true
show_error_code_links = true
show_error_context = true

[tool.ruff]
line-length = 100

[tool.ruff.format]
docstring-code-format = true
docstring-code-line-length = 100

[tool.ruff.lint]
select = ["ALL"]
extend-select = ["PT"]
ignore = [
"COM812", # Redundant and conflicts with ruff format
"D203", # No blank line before docstrings (D211)
"D205", # Breaks if summary is larger than one line due to wrapping or if no summary exists
"D212", # Enforce docstring summary line on the next line after quotes (D213)
"D400", # First line of docstrings may not end in period
"D401", # Docstrings should be written in present tense (not imperative)
"D415", # First line of docstrings may not end in a period, question mark, or exclamation point
"FA102", # Allow use of PEP 604 union in type annotations
"FBT", # Allow bool positional parameters since other value positions are allowed
"FIX002", # Allow todo statements
"PERF401", # Allow for loops when creating lists
"PERF403", # Allow for loops when creating dicts
"S311", # Allow usage of `random` package
"SIM102", # Allow collapsible if statements for readability
"TD002", # Author unnecessary for todo statement
"TD003", # Issue link unnecessary for todo statement
"UP015", # Explicit open modes are helpful
]
isort.order-by-type = false
1 change: 1 addition & 0 deletions python/spider-py/src/spider_py/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""Spider package root."""
1 change: 1 addition & 0 deletions python/spider-py/src/spider_py/client/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""Spider python client."""
1 change: 1 addition & 0 deletions python/spider-py/src/spider_py/core/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""Spider core package."""
5 changes: 5 additions & 0 deletions python/spider-py/src/spider_py/core/task.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"""Task module for Spider."""


class Task:
"""Represents a task in Spider."""
1 change: 1 addition & 0 deletions python/spider-py/src/spider_py/task_executor/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""Python task executor for running Python task function."""
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
"""Executes a Spider Python task."""


def main() -> None:
"""Main function to execute the task."""


if __name__ == "__main__":
main()
Loading