Skip to content

doc: Add architeucture document in developer guide. - #162

Closed
sitaowang1998 wants to merge 7 commits into
y-scope:mainfrom
sitaowang1998:architecture_doc
Closed

doc: Add architeucture document in developer guide.#162
sitaowang1998 wants to merge 7 commits into
y-scope:mainfrom
sitaowang1998:architecture_doc

Conversation

@sitaowang1998

@sitaowang1998 sitaowang1998 commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

Description

As title.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

task docs:site builds successfully and local website from task docs:serve looks as expected.

Summary by CodeRabbit

  • New Features

    • Added a new developer documentation page outlining the architecture of the Spider system.
    • Introduced a Bash script to automate installation of a specific CMake version from source.
  • Chores

    • Updated CMake integration to use an installed ystdlib package instead of building from source.
    • Improved dependency installation process for ystdlib with a more standardized, CMake-based workflow.
    • Modified development setup scripts to install CMake via the new script rather than the system package manager.
  • Documentation

    • Added an "Architecture" section to the developer documentation index for easier navigation.

@sitaowang1998
sitaowang1998 requested a review from a team as a code owner July 14, 2025 02:29
@coderabbitai

coderabbitai Bot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the integration of the ystdlib-cpp dependency from a local subdirectory build to a CMake-installed package using find_package. Dependency installation tasks are refactored for consistency and CMake-centric workflows. New documentation on system architecture is added, and scripts for precise CMake installation are introduced and updated.

Changes

File(s) Change Summary
CMakeLists.txt Updated minimum CMake version, switched ystdlib-cpp integration to find_package, removed local build logic, and added a status message for the found version.
dep-tasks.yaml Renamed and refactored ystdlib install task, updated dependencies, switched to a CMake installation method, updated URL and checksum, and adjusted paths and arguments.
docs/src/dev-docs/architecture.md Added new architecture documentation describing system components, design, and fault tolerance.
docs/src/dev-docs/index.md Added a grid card and navigation entry for the new architecture documentation.
tools/scripts/lib_install/install-cmake.sh Introduced a new Bash script to download, build, and install a specified CMake version from source.
tools/scripts/lib_install/linux/install-dev.sh Changed CMake installation from apt-get to the new install-cmake.sh script with a specific version argument.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant install-dev.sh
    participant install-cmake.sh
    participant System

    Developer->>install-dev.sh: Run script
    install-dev.sh->>install-cmake.sh: Call with version 3.23.5
    install-cmake.sh->>System: Download, build, and install CMake 3.23.5
    install-cmake.sh-->>install-dev.sh: Return control
    install-dev.sh->>System: Run check-cmake-version.sh
Loading
sequenceDiagram
    participant BuildSystem
    participant CMakeLists.txt
    participant ystdlib (as Installed Package)

    BuildSystem->>CMakeLists.txt: Configure project
    CMakeLists.txt->>ystdlib: find_package(ystdlib REQUIRED)
    ystdlib-->>CMakeLists.txt: Provide version and targets
    CMakeLists.txt-->>BuildSystem: Status message and continue build
Loading

Possibly related PRs

Suggested reviewers

  • kirkrodrigues

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdfd8f2 and 3fcfd19.

⛔ Files ignored due to path filters (1)
  • docs/src/dev-docs/arch.png is excluded by !**/*.png
📒 Files selected for processing (6)
  • CMakeLists.txt (2 hunks)
  • dep-tasks.yaml (2 hunks)
  • docs/src/dev-docs/architecture.md (1 hunks)
  • docs/src/dev-docs/index.md (2 hunks)
  • tools/scripts/lib_install/install-cmake.sh (1 hunks)
  • tools/scripts/lib_install/linux/install-dev.sh (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sitaowang1998
sitaowang1998 deleted the architecture_doc branch July 14, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant