fix: Update the velox submodule's URL and commit to the latest from y-scope/velox:presto-0.293-clp-connector. - #44
Conversation
WalkthroughThe submodule for "presto-native-execution/velox" was updated to reference a new commit and its source URL was changed from "facebookincubator/velox.git" to "y-scope/velox.git". No other configuration or public entity declarations were altered. Changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings.gitmodules (1)🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
kirkrodrigues
left a comment
There was a problem hiding this comment.
For the PR title, how about:
fix: Update the velox submodule's URL and commit to the latest from y-scope/velox:presto-0.293-clp-connector.
Description
When PR y-scope/velox#18 merged, it generated a new squash commit that I forgot to sync in the Presto repo. This PR is to sync the Velox submodule commit hash to make sure it is of the latest.
We also forgot to update the
.gitmodulesto replace facebook's main repo with our fork.Checklist
breaking change.
Validation performed
Clone the repo and checkout the branch, then run
make submodules -C presto-native-exeuctionandmake velox-submodule -C presto-native-executionto check if the Velox is of correct version.Summary by CodeRabbit