Skip to content

fix: Update the velox submodule's URL and commit to the latest from y-scope/velox:presto-0.293-clp-connector. - #44

Merged
anlowee merged 1 commit into
y-scope:release-0.293-clp-connectorfrom
anlowee:xwei/fix-velox-submodule
Jul 18, 2025
Merged

fix: Update the velox submodule's URL and commit to the latest from y-scope/velox:presto-0.293-clp-connector.#44
anlowee merged 1 commit into
y-scope:release-0.293-clp-connectorfrom
anlowee:xwei/fix-velox-submodule

Conversation

@anlowee

@anlowee anlowee commented Jul 18, 2025

Copy link
Copy Markdown

Description

When PR y-scope/velox#18 merged, it generated a new squash commit that I forgot to sync in the Presto repo. This PR is to sync the Velox submodule commit hash to make sure it is of the latest.

We also forgot to update the .gitmodules to replace facebook's main repo with our fork.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Clone the repo and checkout the branch, then run make submodules -C presto-native-exeuction and make velox-submodule -C presto-native-execution to check if the Velox is of correct version.

Summary by CodeRabbit

  • Chores
    • Updated the source and version of a key submodule dependency to ensure continued access and compatibility. No changes to user-facing features or functionality.

@coderabbitai

coderabbitai Bot commented Jul 18, 2025

Copy link
Copy Markdown

Walkthrough

The submodule for "presto-native-execution/velox" was updated to reference a new commit and its source URL was changed from "facebookincubator/velox.git" to "y-scope/velox.git". No other configuration or public entity declarations were altered.

Changes

File(s) Change Summary
.gitmodules Updated submodule URL for "presto-native-execution/velox" from "facebookincubator" to "y-scope"
presto-native-execution/velox Updated submodule commit reference to a new commit hash

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f7da77 and 46fbb58.

📒 Files selected for processing (2)
  • .gitmodules (1 hunks)
  • presto-native-execution/velox (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: anlowee
PR: y-scope/presto#7
File: .github/workflows/hive-tests.yml:33-35
Timestamp: 2025-06-04T14:50:43.554Z
Learning: In the y-scope/presto repository, GitHub workflows are extended from OSS Presto and should maintain consistent formatting with the upstream patterns, including YAML indentation styles for workflow steps.
.gitmodules (1)
Learnt from: anlowee
PR: y-scope/presto#7
File: .github/workflows/hive-tests.yml:33-35
Timestamp: 2025-06-04T14:50:43.554Z
Learning: In the y-scope/presto repository, GitHub workflows are extended from OSS Presto and should maintain consistent formatting with the upstream patterns, including YAML indentation styles for workflow steps.
🔇 Additional comments (2)
.gitmodules (1)

3-3: Confirm accessibility and sync local clones after URL switch

The fork URL looks correct, but please verify that:
• the y-scope/velox repo is publicly accessible so CI and external contributors don’t break,
• team members run git submodule sync && git submodule update --init --recursive to refresh existing checkouts.

No code changes needed—just operational follow-up.

presto-native-execution/velox (1)

1-1: Confirmed commit exists on remote submodule
The hash 27ee4bcaad449fd1c8b90c48787f4eaf8e92395f is present as HEAD and on refs/heads/presto-0.293-clp-connector in the y-scope/velox repository. CI and local developers will be able to fetch this commit without issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anlowee
anlowee requested a review from kirkrodrigues July 18, 2025 19:36

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

fix: Update the velox submodule's URL and commit to the latest from y-scope/velox:presto-0.293-clp-connector.

@anlowee anlowee changed the title fix: Update the submodule URL and match the Velox submodule version to the latest. fix: Update the velox submodule's URL and commit to the latest from y-scope/velox:presto-0.293-clp-connector. Jul 18, 2025
@anlowee
anlowee merged commit 56b7211 into y-scope:release-0.293-clp-connector Jul 18, 2025
@anlowee
anlowee deleted the xwei/fix-velox-submodule branch July 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants