Skip to content

Commit

Permalink
Minor edits to spotbugs-exclude.xml
Browse files Browse the repository at this point in the history
  • Loading branch information
kirkrodrigues committed Nov 5, 2024
1 parent 021e704 commit 01336a1
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions spotbugs-exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,48 +2,48 @@
<Match>
<Bug category="BAD_PRACTICE" code="CT" value="CT_CONSTRUCTOR_THROW" />
<Class name="com.yscope.logging.log4j2.AbstractBufferedRollingFileAppender" />
<Justification>Log4j2 should throw immediately if configurations are wrong</Justification>
<Justification>Log4j2 should throw immediately if configurations are wrong.</Justification>
</Match>

<Match>
<Bug category="BAD_PRACTICE" code="CT" value="CT_CONSTRUCTOR_THROW" />
<Class name="com.yscope.logging.log4j2.ClpIrFileAppender" />
<Justification>Log4j2 should throw immediately if configurations are wrong</Justification>
<Justification>Log4j2 should throw immediately if configurations are wrong.</Justification>
</Match>

<Match>
<Bug category="BAD_PRACTICE" code="CT" value="CT_CONSTRUCTOR_THROW" />
<Class name="com.yscope.logging.log4j2.CompressionPatternLayoutContainer" />
<Justification>Log4j2 should throw immediately if configurations are wrong</Justification>
<Justification>Log4j2 should throw immediately if configurations are wrong.</Justification>
</Match>

<Match>
<Bug category="MALICIOUS_CODE" code="EI" value="EI_EXPOSE_REP" />
<Class name="com.yscope.logging.log4j2.PatternLayoutBufferDestination" />
<Justification>Simply returning the buffer. No security check required. False positive</Justification>
<Justification>False positive: Simply returning the buffer. No security check required.</Justification>
</Match>

<Match>
<Bug category="PERFORMANCE" code="UrF" value="URF_UNREAD_FIELD" />
<Class name="com.yscope.logging.log4j2.AbstractBufferedRollingFileAppender$Builder" />
<Justification>Log4j2 plugin attributes. False positive</Justification>
<Justification>False positive: Log4j2 plugin attributes.</Justification>
</Match>

<Match>
<Bug category="PERFORMANCE" code="UrF" value="URF_UNREAD_FIELD" />
<Class name="com.yscope.logging.log4j2.AbstractClpIrBufferedRollingFileAppender$Builder" />
<Justification>Log4j2 plugin attributes. False positive</Justification>
<Justification>False positive: Log4j2 plugin attributes.</Justification>
</Match>

<Match>
<Bug category="PERFORMANCE" code="UrF" value="URF_UNREAD_FIELD" />
<Class name="com.yscope.logging.log4j2.ClpIrFileAppender$Builder" />
<Justification>Log4j2 plugin attributes. False positive</Justification>
<Justification>False positive: Log4j2 plugin attributes.</Justification>
</Match>

<Match>
<Bug category="MT_CORRECTNESS" code="IS" value="IS2_INCONSISTENT_SYNC" />
<Class name="com.yscope.logging.log4j2.AbstractBufferedRollingFileAppender" />
<Justification>Custom synchronization is for shutdown after all user threads</Justification>
<Justification>Custom synchronization is for shutdown after all user threads.</Justification>
</Match>
</FindBugsFilter>
</FindBugsFilter>

0 comments on commit 01336a1

Please sign in to comment.