Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate concept tags from captures and store capture-to-tag mapping in the lexer. #72

Merged
merged 581 commits into from
Feb 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
581 commits
Select commit Hold shift + click to select a range
e2aee66
Remove Register class and use uint32_t instead; Rename vers to xxx_re…
SharafMohamed Dec 3, 2024
36c1810
Rename to reg_id.
SharafMohamed Dec 3, 2024
48df8b0
Remove unused header.
SharafMohamed Dec 3, 2024
a8605fc
Change pred index to be optional and nullopt for root.
SharafMohamed Dec 3, 2024
15cb1b6
Add and use node_id_t.
SharafMohamed Dec 3, 2024
6b787d0
Add position_t.
SharafMohamed Dec 3, 2024
cd8f4e3
Change to id_t.
SharafMohamed Dec 3, 2024
72da50c
Add is_root().
SharafMohamed Dec 4, 2024
3fc7ea7
Add missing header.
SharafMohamed Dec 4, 2024
6443d66
Update PrefixTree docstring.
SharafMohamed Dec 4, 2024
63aec4d
Removing node docstring as its redundant.
SharafMohamed Dec 4, 2024
295f3ee
Combine private section in PrefixTree.
SharafMohamed Dec 4, 2024
1186666
Add missing header; Remove copy paste error.
SharafMohamed Dec 4, 2024
06ee38e
Rename to node_id and parent_node_id.
SharafMohamed Dec 4, 2024
e103011
Update get_reversed_positions' docstring.
SharafMohamed Dec 4, 2024
31b0346
Update get_reversed positions' docstring to clarify exlcusivity of th…
SharafMohamed Dec 4, 2024
4005e41
Grammar fix.
SharafMohamed Dec 4, 2024
e38940c
Add maybe_unusued.
SharafMohamed Dec 4, 2024
d71368d
Update src/log_surgeon/finite_automata/RegisterHandler.hpp
SharafMohamed Dec 4, 2024
dd4b6e1
Update test case names to document code names better.
SharafMohamed Dec 4, 2024
7322852
Implicitily use auto in vectors.
SharafMohamed Dec 4, 2024
dba1a18
Explicitily use position_t for vectors.
SharafMohamed Dec 4, 2024
ee6efab
Update tests/test-register-handler.cpp
SharafMohamed Dec 4, 2024
9ba980c
Switch to size_t.
SharafMohamed Dec 4, 2024
27b324c
Clang-tidy: Remove magic numbers + Fix headers.
SharafMohamed Dec 4, 2024
f651a24
Reduce complexity for clang-tidy.
SharafMohamed Dec 4, 2024
fc6f426
Add negative pos test case in test-register-handler.cpp.
SharafMohamed Dec 4, 2024
c8fb570
Alternate b/w positive and negative positions in test-prefix-tree neg…
SharafMohamed Dec 4, 2024
1f66918
Add cRootId and size() to PrefixTree.
SharafMohamed Dec 4, 2024
a388c80
Update note.
SharafMohamed Dec 4, 2024
340eaf7
Update docstring.
SharafMohamed Dec 4, 2024
22cf931
Fix typo.
SharafMohamed Dec 4, 2024
e75c888
Merge branch 'register' into individual-dfa-files
SharafMohamed Dec 4, 2024
d5b20fe
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 4, 2024
69a7ad1
Merge branch 'remove-redundant-typenames' into remove-regex-prefix
SharafMohamed Dec 4, 2024
0b7ef3c
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Dec 4, 2024
ada697f
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Dec 4, 2024
4e08e2c
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Dec 4, 2024
5916d33
Fix errors created by merge, need to still double check all the funct…
SharafMohamed Dec 5, 2024
c61f2d9
Update header for size_t.
SharafMohamed Dec 5, 2024
417bde8
Update src/log_surgeon/finite_automata/PrefixTree.hpp
SharafMohamed Dec 5, 2024
738876d
Update src/log_surgeon/finite_automata/PrefixTree.hpp
SharafMohamed Dec 5, 2024
93c03a0
Update src/log_surgeon/finite_automata/RegisterHandler.hpp
SharafMohamed Dec 5, 2024
6481e5f
Update tests/test-prefix-tree.cpp
SharafMohamed Dec 5, 2024
6a9a4a4
Clean up register initialization helper; Fix typo.
SharafMohamed Dec 5, 2024
052d86f
Update get_parent_id to clarify its unsafe and suppress warning.
SharafMohamed Dec 5, 2024
ed70bd5
Move constants in test-register-handler.hpp to minimize scope.
SharafMohamed Dec 5, 2024
fab801f
Merge branch 'register' into individual-dfa-files
SharafMohamed Dec 5, 2024
db84cb7
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 5, 2024
7f6fcd9
Merge branch 'remove-redundant-typenames' into remove-regex-prefix
SharafMohamed Dec 5, 2024
a346104
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Dec 5, 2024
e90ae14
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Dec 5, 2024
4d30509
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Dec 5, 2024
1671e39
Move constants into scope for test-prefix-tree.cpp.
SharafMohamed Dec 5, 2024
748dfc5
Rename to handler_init and return handler.
SharafMohamed Dec 5, 2024
8abf35a
Add docstring for get_parent_id_unsafe().
SharafMohamed Dec 5, 2024
1e5fdcc
Linter.
SharafMohamed Dec 5, 2024
effac53
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 5, 2024
43aa3be
Linter + Merge branch 'remove-redundant-typenames' into remove-regex-…
SharafMohamed Dec 5, 2024
c0920bf
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Dec 5, 2024
19fe130
Linter.
SharafMohamed Dec 5, 2024
61ceba6
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Dec 5, 2024
0e1e2b2
Linter.
SharafMohamed Dec 5, 2024
9302ecb
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Dec 5, 2024
71d926d
Merge branch 'register' into individual-dfa-files
SharafMohamed Dec 6, 2024
66ed13b
Merge branch 'main' into individual-dfa-files
SharafMohamed Dec 6, 2024
a12a360
Fix comment length.
SharafMohamed Dec 6, 2024
244d122
Initialize byte transitions.
SharafMohamed Dec 6, 2024
176391b
Use const* in place of unique_ptr reference; Update docstrings.
SharafMohamed Dec 7, 2024
012f61f
Update intersect test to compile.
SharafMohamed Dec 7, 2024
96a6363
Update next() docstring.
SharafMohamed Dec 7, 2024
7cd39f0
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 7, 2024
a4a93b4
Rename to state_type.
SharafMohamed Dec 8, 2024
421c3de
Update headers.
SharafMohamed Dec 8, 2024
ecd4e4e
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 8, 2024
1b945a1
Update Lexer headers.
SharafMohamed Dec 8, 2024
70cd43d
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 8, 2024
78c4125
Add header for conditional_t.
SharafMohamed Dec 8, 2024
3ce0b30
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 8, 2024
33623fa
Linter.
SharafMohamed Dec 8, 2024
bae0557
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 8, 2024
5bbeafc
Linter.
SharafMohamed Dec 8, 2024
0decaf5
Change ! to false ==.
SharafMohamed Dec 8, 2024
0e2d593
Merge branch 'individual-dfa-files' into remove-redundant-typenames
SharafMohamed Dec 8, 2024
cf5980d
Merge branch 'remove-redundant-typenames' into remove-regex-prefix
SharafMohamed Dec 8, 2024
6e65a3e
LALR1Parser to Lalr1Parser.
SharafMohamed Dec 8, 2024
9c2ad81
Linter.
SharafMohamed Dec 8, 2024
c4fc96b
Rename templates to TypedDfaState and TypedNfaState.
SharafMohamed Dec 8, 2024
a6bbaef
Rename to Utf8*State and Byte*State.
SharafMohamed Dec 8, 2024
ff2dac3
Remove RegexDFAStateType.hpp.
SharafMohamed Dec 8, 2024
7a8982d
Linter.
SharafMohamed Dec 8, 2024
7b0a86c
Linter again.
SharafMohamed Dec 8, 2024
2632616
Add missing alogrithm header; Update test-NFA.
SharafMohamed Dec 8, 2024
992a2ec
Update intersect-test.cpp with new names.
SharafMohamed Dec 8, 2024
a5419f0
Linter on intersect-test.cpp.
SharafMohamed Dec 8, 2024
ae64f64
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Dec 9, 2024
9153a7c
Switch this->m_lexer to m_lexer by using Parser::m_lexer.
SharafMohamed Dec 9, 2024
fa0c098
Linter.
SharafMohamed Dec 9, 2024
845b088
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Dec 9, 2024
2dd6f45
Lint.
SharafMohamed Dec 9, 2024
ee46719
More auto changes.
SharafMohamed Dec 9, 2024
4cebc06
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Dec 11, 2024
827d39c
Merge branch 'main' into remove-redundant-typenames
SharafMohamed Dec 11, 2024
80979de
Remove old epsilon_closure after double checking it matches the moved…
SharafMohamed Dec 11, 2024
b38b6d7
Merge dfa_to_nfa() into Dfa::Dfa().
SharafMohamed Dec 11, 2024
1c2d7b3
Merge branch 'remove-redundant-typenames' into remove-regex-prefix
SharafMohamed Dec 11, 2024
11da5d5
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Dec 11, 2024
3f6966f
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Dec 11, 2024
11eab2b
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Dec 11, 2024
538ae8b
Fix intersect_test compiler errrors.
SharafMohamed Dec 11, 2024
74841b0
Add const.
SharafMohamed Dec 11, 2024
f84cd0b
Add register handler to DFA.
SharafMohamed Dec 12, 2024
efb7932
Add missing headers; Initialize variable.
SharafMohamed Dec 12, 2024
be3d483
Update src/log_surgeon/finite_automata/RegexDFAStatePair.hpp
SharafMohamed Dec 19, 2024
b8afafa
Update src/log_surgeon/finite_automata/RegexNFAState.hpp
SharafMohamed Dec 19, 2024
68ed2b1
Update src/log_surgeon/finite_automata/RegexDFAStatePair.hpp
SharafMohamed Dec 19, 2024
8bebee4
Add maps to lexer; Add lexer test case.
SharafMohamed Jan 6, 2025
beb59aa
NonTerminal::m_all_children to m_all_children.
SharafMohamed Jan 6, 2025
b4d25bb
Merge branch 'remove-redundant-typenames' of https://github.com/Shara…
SharafMohamed Jan 6, 2025
4e07f8d
Merge branch 'remove-redundant-typenames' into remove-regex-prefix
SharafMohamed Jan 6, 2025
8f7a355
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Jan 6, 2025
fe3b704
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Jan 6, 2025
1380e53
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 6, 2025
6d5b920
Merge branch 'main' into remove-regex-prefix
SharafMohamed Jan 7, 2025
9a82620
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Jan 7, 2025
8abd2cf
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Jan 7, 2025
a509323
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 7, 2025
6bf8c01
Fix test-NFA to test-nfa and ByteNFA to ByteNfa.
SharafMohamed Jan 7, 2025
5dc5953
Combine NfaStateType and DfaStateType into StateType.
SharafMohamed Jan 7, 2025
ed631b3
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Jan 7, 2025
8410fb1
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Jan 7, 2025
ff92325
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 7, 2025
b26d22b
Remove out-dated comment.
SharafMohamed Jan 8, 2025
9af72f3
Remove old commented utf8 code.
SharafMohamed Jan 8, 2025
6f3ce6c
Merge branch 'remove-regex-prefix' into remove-uneeded-this
SharafMohamed Jan 8, 2025
1f1d3ea
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Jan 8, 2025
d21e373
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 8, 2025
66cd3b3
Merge branch 'main' into remove-uneeded-this
SharafMohamed Jan 8, 2025
ea78ed2
Merge branch 'remove-uneeded-this' into use-auto
SharafMohamed Jan 8, 2025
25237a2
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 8, 2025
3a94829
Merge branch 'refactor-nfa-to-dfa' into restructure-tagging
SharafMohamed Jan 8, 2025
9902984
Fix file ordering in tests cmake.
SharafMohamed Jan 8, 2025
7ccdfd5
Merge branch 'main' into use-auto
SharafMohamed Jan 8, 2025
013997c
Explicitly use bool for initializations from true/false instead of auto.
SharafMohamed Jan 9, 2025
88e2cc2
Update src/log_surgeon/Lalr1Parser.tpp
SharafMohamed Jan 9, 2025
4ebbc82
Make bool typed explicitly.
SharafMohamed Jan 9, 2025
e6893d9
Update src/log_surgeon/Lalr1Parser.tpp
SharafMohamed Jan 9, 2025
425a8e6
Update src/log_surgeon/Lalr1Parser.tpp
SharafMohamed Jan 9, 2025
fd394af
Update src/log_surgeon/Lalr1Parser.tpp
SharafMohamed Jan 9, 2025
7fe39db
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 9, 2025
6cb5c23
Update src/log_surgeon/Lalr1Parser.tpp
SharafMohamed Jan 10, 2025
239872a
Merge branch 'use-auto' into refactor-nfa-to-dfa
SharafMohamed Jan 10, 2025
8bd9bae
Merge branch 'refactor-nfa-to-dfa' into restructure-tagging
SharafMohamed Jan 10, 2025
473f8e5
Merge branch 'main' into refactor-nfa-to-dfa
SharafMohamed Jan 10, 2025
626ad54
Merge branch 'refactor-nfa-to-dfa' into restructure-tagging
SharafMohamed Jan 10, 2025
0fb0758
Update test code.
SharafMohamed Jan 11, 2025
f7e1718
Switch typedef to using; Remove commented out code.
SharafMohamed Jan 11, 2025
18c3e25
Merge branch 'refactor-nfa-to-dfa' into restructure-tagging
SharafMohamed Jan 11, 2025
af2c8d4
Merge branch 'main' into restructure-tagging
SharafMohamed Jan 11, 2025
3504ffb
Fixed lexer test...the current way of using the lexer is insanely bad.
SharafMohamed Jan 11, 2025
8b43e83
Add capture group test case.
SharafMohamed Jan 12, 2025
719e722
Add getters and setters for lexer maps; Update unit-tests.
SharafMohamed Jan 12, 2025
082145e
Use capture instead of tag.
SharafMohamed Jan 13, 2025
e06cf44
Fix ownership of m_rules.
SharafMohamed Jan 13, 2025
2e99a91
Add tags.
SharafMohamed Jan 13, 2025
94db0d6
Lexer now enforced unique capture names.
SharafMohamed Jan 13, 2025
9731fa3
Update test-nfa to match added tags.
SharafMohamed Jan 13, 2025
bc78c49
Update the last lexer map that can be initialized currently.
SharafMohamed Jan 13, 2025
2c89216
Uniform initialization.
SharafMohamed Jan 13, 2025
f06031d
Indent comment.
SharafMohamed Jan 13, 2025
90ce695
Indent comment.
SharafMohamed Jan 13, 2025
40a90bd
Linter.
SharafMohamed Jan 13, 2025
d9c20fe
Linter.
SharafMohamed Jan 13, 2025
391607d
Linter.
SharafMohamed Jan 13, 2025
e6273b2
Linter.
SharafMohamed Jan 13, 2025
f88a780
Use moe semantics properly for negative transition.
SharafMohamed Jan 13, 2025
0cc6c24
Clean up testing code.
SharafMohamed Jan 13, 2025
54d9181
Move UniqueIdGenerator to its own file.
SharafMohamed Jan 29, 2025
d38393d
Fix accidental deletion.
SharafMohamed Jan 29, 2025
4d911af
Lock Ubuntu to 22.04.
SharafMohamed Feb 1, 2025
71fbb9c
Print unit-test logs when failing on git.
SharafMohamed Feb 1, 2025
0aa0f42
Merge branch 'lock-ubuntu-version' into restructure-tagging
SharafMohamed Feb 1, 2025
55272ef
Merge branch 'lock-ubuntu-version' into print-unit-test-on-git
SharafMohamed Feb 1, 2025
b32cdc8
Linter fixes.
SharafMohamed Feb 1, 2025
0f9ff50
clang-tidy id gen.
SharafMohamed Feb 3, 2025
7dbe2ea
Merge branch 'print-unit-test-on-git' into restructure-tagging
SharafMohamed Feb 3, 2025
004ba66
Merge branch 'linter-fixes' into restructure-tagging
SharafMohamed Feb 3, 2025
22bc8f6
Merge branch 'main' into restructure-tagging
SharafMohamed Feb 9, 2025
727e63e
Use contains()
SharafMohamed Feb 9, 2025
2cf8bde
Some clang-tidy fixes.
SharafMohamed Feb 9, 2025
a17fbf5
rename to get_captures_id_from_var_id.
SharafMohamed Feb 9, 2025
efd78f5
rename to get_reg_id_from_tag_id.
SharafMohamed Feb 9, 2025
f0c8ec8
Rename to get_tag_ids_from_capture_id; Rename to get_reg_ids_from_cap…
SharafMohamed Feb 9, 2025
4183d06
Replace aliasing with directly using the existing type.
SharafMohamed Feb 9, 2025
e45c370
Rename to reg_id_t.
SharafMohamed Feb 9, 2025
13dabb7
Shot-circuit on failure; Don't use [].
SharafMohamed Feb 9, 2025
4a8329f
Merge branch 'restructure-tagging' of https://github.com/SharafMohame…
SharafMohamed Feb 9, 2025
8d427fd
Fix compiler error; Add spacing; Start change for tag_ids to tag_id_p…
SharafMohamed Feb 9, 2025
5370720
Finish rename of tag_ids to tag_id_pair.
SharafMohamed Feb 9, 2025
598dda8
Fix docstring.
SharafMohamed Feb 9, 2025
be10a94
New docstrings.
SharafMohamed Feb 9, 2025
50bf97a
Use const; Replace [] with at().
SharafMohamed Feb 9, 2025
d79ad47
Fix spacing.
SharafMohamed Feb 9, 2025
6af3a86
Update NFA docstring.
SharafMohamed Feb 9, 2025
ea16fd1
Use contains.
SharafMohamed Feb 9, 2025
6a4a440
Add const.
SharafMohamed Feb 9, 2025
be7bef3
Remove space after namespace.
SharafMohamed Feb 9, 2025
3ae1016
Add nodiscard.
SharafMohamed Feb 9, 2025
aacd497
Undo docstring change for prefix tree.
SharafMohamed Feb 9, 2025
e971175
Fix NegativeTaggedTransition docstring,
SharafMohamed Feb 9, 2025
986d767
Replace symbol_id_t with rule_id_t and capture_id_t.
SharafMohamed Feb 9, 2025
439895b
Avoid copy.
SharafMohamed Feb 9, 2025
1efe053
Remove Dfa changes.
SharafMohamed Feb 9, 2025
5c178f6
Remove unused var; Avoid copy.
SharafMohamed Feb 9, 2025
169f21c
Fix std::uint32_t to uint32_t.
SharafMohamed Feb 9, 2025
7ca626e
Fix typo.
SharafMohamed Feb 9, 2025
12ee26f
Replace ! with false.
SharafMohamed Feb 9, 2025
32996b5
Clang-tidy TaggedTransition.hpp.
SharafMohamed Feb 9, 2025
78c9df4
Replace [] with .at() and .emplace(); Use ++i.
SharafMohamed Feb 10, 2025
32f540b
Clean up test-lexer.cpp.
SharafMohamed Feb 10, 2025
cc7c0a6
Clean up test-lexer.cpp.
SharafMohamed Feb 10, 2025
15e1384
Add optional prefix.
SharafMohamed Feb 10, 2025
fab9c42
Fix compiler error,
SharafMohamed Feb 10, 2025
27ef30b
Add const.
SharafMohamed Feb 10, 2025
2d77ee6
Run linter.
SharafMohamed Feb 10, 2025
40cab9d
Rename group to capture.
SharafMohamed Feb 10, 2025
df1c9df
Add Aliases.hpp; Lint.
SharafMohamed Feb 10, 2025
ef3bc8e
Add aliases.
SharafMohamed Feb 10, 2025
58a948e
Rename register to reg.
SharafMohamed Feb 10, 2025
481b997
Remove erroneous const.
SharafMohamed Feb 10, 2025
ea724e6
Use try_emplace.
SharafMohamed Feb 10, 2025
b326a92
Make sure declaration matches definition.
SharafMohamed Feb 10, 2025
0693c1b
Fix typo.
SharafMohamed Feb 10, 2025
85724cb
Rename add_to_nfa_with_negative_captures.
SharafMohamed Feb 10, 2025
5261293
Improve TODO.
SharafMohamed Feb 10, 2025
19856a1
Update initialize lexer docstring.
SharafMohamed Feb 10, 2025
5a72ad5
Update docstring.
SharafMohamed Feb 10, 2025
1217fe6
Improve docstring.
SharafMohamed Feb 10, 2025
d5e2e53
Update diagram with ID.
SharafMohamed Feb 10, 2025
ebb6abc
Add nullptr checks to body of constructor.
SharafMohamed Feb 10, 2025
630749a
Use contains in Lexer.hpp.
SharafMohamed Feb 10, 2025
ddae224
Switch find to contains in TaggedTransition.hpp.
SharafMohamed Feb 10, 2025
a2d1825
Add missing header.
SharafMohamed Feb 10, 2025
983ddcb
Rename Aliases.hpp to types.hpp.
SharafMohamed Feb 11, 2025
303de17
initialize_lexer now creates and returns the lexer.
SharafMohamed Feb 12, 2025
9e99f40
Fix compiler error.
SharafMohamed Feb 12, 2025
574d9df
Rename to create_lexer.
SharafMohamed Feb 12, 2025
75de29a
Fix docstring.
SharafMohamed Feb 12, 2025
ac43cce
Fix docstring again.
SharafMohamed Feb 12, 2025
b9ef282
Fix docstring again again.
SharafMohamed Feb 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linter.
SharafMohamed committed Jan 13, 2025
commit 40a90bd51adc29fd859cc590abe7c19b7272dde2
13 changes: 6 additions & 7 deletions tests/test-nfa.cpp
Original file line number Diff line number Diff line change
@@ -45,7 +45,7 @@ TEST_CASE("Test NFA", "[NFA]") {
vector<ByteLexicalRule> rules;
rules.emplace_back(0, std::move(capture_rule_ast.m_regex_ptr));
ByteNfa const nfa{rules};

// Compare against expected output
// capture order(tags in brackets): letter1(0,1), letter2(2,3), letter(4,5), containerID(6,7)
string expected_serialized_nfa = "0:byte_transitions={A-->1,Z-->2},"
@@ -58,12 +58,11 @@ TEST_CASE("Test NFA", "[NFA]") {
"positive_tagged_start_transitions={3[4]},"
"positive_tagged_end_transitions={},"
"negative_tagged_transition={}\n";
expected_serialized_nfa
+= "2:byte_transitions={},"
"epsilon_transitions={},"
"positive_tagged_start_transitions={},"
"positive_tagged_end_transitions={},"
"negative_tagged_transition={4[0,1,2,3,4,5,6,7]}\n";
expected_serialized_nfa += "2:byte_transitions={},"
"epsilon_transitions={},"
"positive_tagged_start_transitions={},"
"positive_tagged_end_transitions={},"
"negative_tagged_transition={4[0,1,2,3,4,5,6,7]}\n";
expected_serialized_nfa += "3:byte_transitions={},"
"epsilon_transitions={},"
"positive_tagged_start_transitions={5[0],6[2]},"