Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Fix: Add negative tags for RegexMultiplicationAST with min=0; Update README to include intersection-test. #41

Merged
merged 122 commits into from
Oct 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
a6274ec
Bug-fix for unicode array sizes
SharafMohamed Sep 12, 2024
186d239
Merge remote-tracking branch 'upstream/main' into nfa-cleanup-pr
SharafMohamed Sep 12, 2024
4f122c6
Move LexicalRule to its own class; Change name to variable_id; Change…
SharafMohamed Sep 12, 2024
c24f6e1
Additional fix for swapping meaning of tag
SharafMohamed Sep 12, 2024
33582da
Another additional fix for swapping meaning of tag
SharafMohamed Sep 12, 2024
3338ec7
Fix up some comments
SharafMohamed Sep 12, 2024
3cd3c0f
Fix comment grammar
SharafMohamed Sep 12, 2024
e05acbb
Add tags to AST; Serialize AST for testing; Add unit-test for testing…
SharafMohamed Sep 13, 2024
5e61e83
Use using to condense code; Use a unique schema object for each test …
SharafMohamed Sep 13, 2024
082090d
Add has_capture_groups(); Add unit-test for has_capture_groups()
SharafMohamed Sep 13, 2024
2c6d94e
Create and use RegexASTEmpty to split RegexASTgroup with min=0 into R…
SharafMohamed Sep 13, 2024
4e02f24
Add unit-test for 0 repetition regex
SharafMohamed Sep 13, 2024
bb3c543
Add more tests for repetition regex
SharafMohamed Sep 13, 2024
54027ad
Return by value in literal getters; Use const instead of const& for l…
SharafMohamed Sep 16, 2024
e58274f
Refactor new_state()
SharafMohamed Sep 16, 2024
1321871
Rename get_first_matching_variable_ids() to get_matching_variable_ids…
SharafMohamed Sep 16, 2024
c904755
Remove redundant docstrings
SharafMohamed Sep 16, 2024
ffe9a0f
Remove has_capture_groups()
SharafMohamed Sep 16, 2024
913ed1a
Const and auto changes
SharafMohamed Sep 16, 2024
7aa8a92
Changed AST add functions to indicate the AST are being added to the …
SharafMohamed Sep 17, 2024
77e44a5
Merge branch 'nfa-cleanup-pr' into comment-cleanup
SharafMohamed Sep 17, 2024
d1d87e7
Merged with previous PR
SharafMohamed Sep 17, 2024
f386a3b
Merge branch 'tagged-ast' into pre-tagged-nfa-cleanup
SharafMohamed Sep 17, 2024
0c600d7
Merge branch 'pre-tagged-nfa-cleanup' into regex-ast-empty
SharafMohamed Sep 17, 2024
bedad75
Change add in RegexASTEmpty to add_to_nfa
SharafMohamed Sep 17, 2024
053d057
Update src/log_surgeon/finite_automata/RegexAST.hpp
SharafMohamed Sep 18, 2024
a822307
updated examples to use
SharafMohamed Sep 18, 2024
0b9603a
Merge branch 'nfa-cleanup-pr' into comment-cleanup
SharafMohamed Sep 18, 2024
2ef84d1
TODO to clarify RegexAST class is actually nodes in the AST
SharafMohamed Sep 18, 2024
83bd518
Merge branch 'main' into comment-cleanup
SharafMohamed Sep 18, 2024
d3d815e
Merge branch 'comment-cleanup' of https://github.com/SharafMohamed/lo…
SharafMohamed Sep 18, 2024
168adb0
Grammar fix
SharafMohamed Sep 18, 2024
20b3421
Typo fix
SharafMohamed Sep 18, 2024
5231a4a
Fix var references in new comments
SharafMohamed Sep 18, 2024
e4ac215
Move DFA comment to RegexDFA.hpp
SharafMohamed Sep 19, 2024
4b8b13e
Merge branch 'comment-cleanup' into tagged-ast
SharafMohamed Sep 19, 2024
e2d05fa
Merge branch 'main' into tagged-ast
SharafMohamed Sep 19, 2024
660eb9b
Remove duplicate comments from child classes
SharafMohamed Sep 19, 2024
731b9fe
Change capture groups to assign tag when its originally added to the …
SharafMohamed Sep 19, 2024
81b4ffa
Assign negative tags during construction of AST nodes
SharafMohamed Sep 23, 2024
a4d29a5
Added docstring for RegexAST explaining what the class does
SharafMohamed Sep 23, 2024
9379447
Removed serializing AST without tags as this intermediate representat…
SharafMohamed Sep 23, 2024
6c4d933
Fix docstring tense; Add [[nodiscard]] and const to serialize functio…
SharafMohamed Sep 23, 2024
a2fdbf1
Fix linter error
SharafMohamed Sep 23, 2024
b0485f5
Make serialize_with_negative_tags() protected
SharafMohamed Sep 23, 2024
64da95c
Merge branch 'main' into tagged-ast
SharafMohamed Sep 23, 2024
e5bda43
Make it explicitly clear when parent method is used
SharafMohamed Sep 23, 2024
0ac7c43
Use fmt in serialize
SharafMohamed Sep 23, 2024
529dcb2
Have fmt fetched if its not found
SharafMohamed Sep 23, 2024
2e17bee
Remove fetching fmt
SharafMohamed Sep 23, 2024
013765b
Fetch fmt with QUIET
SharafMohamed Sep 23, 2024
14cbe97
Added debug prints to cmake
SharafMohamed Sep 23, 2024
20864d6
Find after fetch
SharafMohamed Sep 23, 2024
72e61f6
Modified fmt fetch to match GSL
SharafMohamed Sep 23, 2024
aadb290
Fix fmt tag in fetch
SharafMohamed Sep 23, 2024
c9d5510
Revert fmt fetch back to how it was before
SharafMohamed Sep 23, 2024
f138527
Switched approach for generating unique capture group ids
SharafMohamed Sep 23, 2024
4cc5e2a
Update fetch fmt
SharafMohamed Sep 23, 2024
e08e345
fmt debug cmake
SharafMohamed Sep 23, 2024
ea5121a
Fixed order of declaring and making available for fetched content in …
SharafMohamed Sep 23, 2024
2ff09b5
Force fmt to generate install rules
SharafMohamed Sep 23, 2024
69cdd1f
Add docstring for FMT_INSTALL; Remove debug prints
SharafMohamed Sep 23, 2024
f580cdd
Copy GSL when fetching fmt
SharafMohamed Sep 23, 2024
c0dd3fe
Fix type in ftm include
SharafMohamed Sep 23, 2024
df12855
Cmake test
SharafMohamed Sep 23, 2024
be00753
Cmake test2
SharafMohamed Sep 23, 2024
2f47770
Cmake test3
SharafMohamed Sep 23, 2024
a15365b
Cmake test4
SharafMohamed Sep 23, 2024
239ff76
Cmake test5
SharafMohamed Sep 23, 2024
2826461
Fix cmake indentation
SharafMohamed Sep 23, 2024
db42bd8
Fix cmake indentation
SharafMohamed Sep 23, 2024
d5eeb5a
Remove space in cmake
SharafMohamed Sep 23, 2024
ce2fc76
Use std::move for set assignment
SharafMohamed Sep 25, 2024
9643138
Update docstrings; Use move and merge for sets.
SharafMohamed Sep 25, 2024
550961e
For serialize functions use const and make nullptr checks explicit; F…
SharafMohamed Sep 25, 2024
74c46ad
Update RegexAST docstring.
SharafMohamed Sep 25, 2024
29e0777
Return raw const* instead of unique_ptr
SharafMohamed Sep 25, 2024
cde19a6
Fix compiler errors in previous commit
SharafMohamed Sep 25, 2024
9837c10
Remove <format>
SharafMohamed Sep 25, 2024
dac2122
Replace bind with a lambda function
SharafMohamed Sep 25, 2024
aa4a4e4
Add fmt to clan-format header libraries; Run clang-format
SharafMohamed Sep 25, 2024
e00fead
Add description of new test
SharafMohamed Sep 25, 2024
63fd9da
Use GIT_SHALLOW ON for fmt in cmakelists
SharafMohamed Sep 25, 2024
a5eae39
Handle 32bit unicode in AST node serialize()
SharafMohamed Sep 26, 2024
7b73929
Remove irrelevent comment from clang-tidy (also fixes the previously …
SharafMohamed Sep 26, 2024
1c62d8c
Merge branch 'main' into tagged-ast
SharafMohamed Sep 26, 2024
033928f
Merge with previous PR
SharafMohamed Sep 26, 2024
1b6cd08
Update to have Catch2 give a nice output for u32strings; Update to me…
SharafMohamed Sep 26, 2024
bc4444a
Use better terminology in new comments
SharafMohamed Sep 26, 2024
48cea41
Merge with previous PR
SharafMohamed Oct 1, 2024
547bef4
Fix formatting
SharafMohamed Oct 1, 2024
c73c72c
Use boost instead of implementing our own u32_to_u8 method; Remove re…
SharafMohamed Oct 1, 2024
f364aac
Fix long string indentation
SharafMohamed Oct 1, 2024
e93ea4f
Remove unused include; Fix typo
SharafMohamed Oct 1, 2024
c2933f3
add default constructor to RegexASTEmpty
SharafMohamed Oct 1, 2024
f195955
move default constructors into class declaration
SharafMohamed Oct 1, 2024
37dfdca
Add docstring for RegexASTEmpty
SharafMohamed Oct 1, 2024
3e64e7c
Add test case for validity; Fix typo in test case name; Fix docstrin…
SharafMohamed Oct 1, 2024
69af073
Add [[maybe_unused]]; Compilation fix for swapping from reference to …
SharafMohamed Oct 1, 2024
14f9f69
Install boost in cmake if not found.
SharafMohamed Oct 1, 2024
e49421a
Remove REQUIRED from boost cmake line so it continues to the install.
SharafMohamed Oct 1, 2024
5ca7b4e
Correct tag for boost.
SharafMohamed Oct 1, 2024
2c72410
Correct tag for boost.
SharafMohamed Oct 1, 2024
f113c19
Fix formatting of GSL linking; Link against Boost::locale.
SharafMohamed Oct 1, 2024
064379c
Enable boost in cmake.
SharafMohamed Oct 1, 2024
bf06d33
Fix typo.
SharafMohamed Oct 1, 2024
34f9e4f
Make sure locale is found.
SharafMohamed Oct 1, 2024
af61ee1
Make sure boost is built.
SharafMohamed Oct 1, 2024
9329cc8
Remove boost::locale and use std::locale instead.
SharafMohamed Oct 1, 2024
ede2a16
Undo cmake changes.
SharafMohamed Oct 1, 2024
083b29d
Move test helper into namespace with docstring declaration at top and…
SharafMohamed Oct 7, 2024
f29cb07
Move u32string_to_string into its own helper function and simplify fu…
SharafMohamed Oct 7, 2024
a3bf94f
Add a more complex repetition case.
SharafMohamed Oct 7, 2024
9cff8ec
Minor fixes.
SharafMohamed Oct 7, 2024
4379bc5
Fix test-interpretation and update READme
SharafMohamed Oct 7, 2024
d12e91f
Update RegexMultiplication serialize to wrap its operand in brackets;…
SharafMohamed Oct 7, 2024
12871f5
Add needed clang-format tags.
SharafMohamed Oct 7, 2024
7623202
Remove redundant use of fmr::format and directly call u32string_to_st…
SharafMohamed Oct 7, 2024
b2308ab
Fix docstring grammar.
SharafMohamed Oct 7, 2024
acbd3f5
Fix docstring grammar and typo.
SharafMohamed Oct 7, 2024
0e99f67
Add [[nodiscard]].
SharafMohamed Oct 7, 2024
5a19cee
Combine test-lexer.cpp helpers into one namespace.
SharafMohamed Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove REQUIRED from boost cmake line so it continues to the install.
SharafMohamed committed Oct 1, 2024
commit e49421a1e27c313f0e31d5d782a72863f1ceec33
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ if (NOT fmt_FOUND)
)
endif()

find_package(Boost 1.74 REQUIRED locale)
find_package(Boost 1.74 COMPONENTS locale)
if(NOT Boost_FOUND)
FetchContent_Declare(boost
GIT_REPOSITORY https://github.com/boostorg/boost.git