Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .clang-tidy from yscope-dev-utils and add instructions for running clang-tidy. #22

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

SharafMohamed
Copy link
Contributor

@SharafMohamed SharafMohamed commented Aug 15, 2024

  • Pull latest yscope-dev-utils
  • Add init.sh script to sym link .clang-tidy from yscope-dev-utils to log-surgeon's root
  • Add README
  • Update workflow
  • Update main CMakeLists to output compile_commands.json

@SharafMohamed SharafMohamed changed the title Use .clang-tidy from yscope-dev-utils Use .clang-tidy from yscope-dev-utils. Aug 15, 2024
Copy link
Member

@LinZhihao-723 LinZhihao-723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add instructions in README or task file to ensure the init script is properly called?

@SharafMohamed
Copy link
Contributor Author

Shall we add instructions in README or task file to ensure the init script is properly called?

Added install and use instructions.

Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

Use .clang-tidy from yscope-dev-utils and add instructions for running clang-tidy.

@SharafMohamed SharafMohamed changed the title Use .clang-tidy from yscope-dev-utils. Use .clang-tidy from yscope-dev-utils and add instructions for running clang-tidy. Aug 16, 2024
@SharafMohamed SharafMohamed merged commit c545db9 into y-scope:main Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants