Skip to content

feat(new-webui): Sort search results by timestamp. #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davemarco merged 6 commits into from
Jun 3, 2025
Merged

feat(new-webui): Sort search results by timestamp. #956

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a4bb7e
latest
Jun 2, 2025
b035cc4
latest
Jun 2, 2025
e306488
Merge branch 'main' into sort
davemarco Jun 2, 2025
e9feb68
latest
Jun 2, 2025
b2b108a
latest
Jun 2, 2025
9719ed1
Merge branch 'main' into sort
davemarco Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...log-viewer-webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/typings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,17 @@ interface SearchResult {
const searchResultsTableColumns: NonNullable<TableProps<SearchResult>["columns"]> = [
{
dataIndex: "timestamp",
defaultSortOrder: "ascend",
key: "timestamp",
render: (timestamp: number) => dayjs(timestamp).format(DATETIME_FORMAT_TEMPLATE),
sorter: true,
sorter: (a, b) => a.timestamp - b.timestamp,

// Specifying a third sort direction removes ability for user to cancel sorting.
sortDirections: [
"ascend",
"descend",
"ascend",
],
title: "Timestamp",
width: 15,
},
Comment on lines 27 to 42

@junhaoliao junhaoliao Jun 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional: utterly nit-picking) since there're many fields already, i'd probably group the fields:

Suggested change
{
dataIndex: "timestamp",
defaultSortOrder: "ascend",
key: "timestamp",
render: (timestamp: number) => dayjs(timestamp).format(DATETIME_FORMAT_TEMPLATE),
sorter: true,
sorter: (a, b) => a.timestamp - b.timestamp,
// Specifying a third sort direction removes ability for user to cancel sorting.
sortDirections: [
"ascend",
"descend",
"ascend",
],
title: "Timestamp",
width: 15,
},
{
dataIndex: "timestamp",
key: "timestamp",
title: "Timestamp",
render: (timestamp: number) => dayjs(timestamp).format(DATETIME_FORMAT_TEMPLATE),
width: 15,
// Specifying a third sort direction removes ability for user to cancel sorting.
defaultSortOrder: "ascend",
sortDirections: [
"ascend",
"descend",
"ascend",
],
sorter: (a, b) => a.timestamp - b.timestamp,
},

@davemarco davemarco Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be happy to do this, but the linter will complain about sort keys

Expand Down