Skip to content

chore(new-webui): Add compatibility patch for Ant Design with React 19. #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junhaoliao merged 1 commit into from
May 28, 2025
Merged

chore(new-webui): Add compatibility patch for Ant Design with React 19. #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions components/log-viewer-webui/client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion components/log-viewer-webui/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,20 @@
"license": "Apache-2.0",
"type": "module",
"dependencies": {
"@ant-design/v5-patch-for-react-19": "^1.0.3",
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.0",
"@mui/joy": "^5.0.0-beta.51",
"@sinclair/typebox": "^0.34.25",
"antd": "^5.24.5",
"axios": "^1.7.9",
"chart.js": "^4.4.9",
"react-chartjs-2": "^5.3.0",
"chartjs-adapter-dayjs-4": "^1.0.4",
"chartjs-plugin-zoom": "^2.2.0",
"dayjs": "^1.11.13",
"highlight.js": "^11.11.1",
"react": "^19.0.0",
"react-chartjs-2": "^5.3.0",

@coderabbitai coderabbitai Bot May 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Optional: Standardise dependency ordering
The moved react-chartjs-2 entry is valid, but consider organising dependencies alphabetically or grouping them by ecosystem for improved maintainability.

🤖 Prompt for AI Agents 
In components/log-viewer-webui/client/package.json at line 30, the dependency
"react-chartjs-2" is correctly added but the dependencies list is not ordered
consistently. To improve maintainability, reorder all dependencies
alphabetically or group them logically by ecosystem. Adjust the entire
dependencies section to follow the chosen ordering scheme.

"react-dom": "^19.0.0",
"react-router": "^7.4.1",
"react-syntax-highlighter": "^15.6.1",
Expand Down
2 changes: 2 additions & 0 deletions components/log-viewer-webui/client/src/AntdApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import {RouterProvider} from "react-router";

import router from "./router";

import "@ant-design/v5-patch-for-react-19";

@coderabbitai coderabbitai Bot May 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Load the compatibility patch before all other imports
The side-effect import must execute prior to any React or component imports to properly patch Ant Design. Please relocate this line to the very top of the file.

- import {RouterProvider} from "react-router";
- import router from "./router";
- import "@ant-design/v5-patch-for-react-19";
+ import "@ant-design/v5-patch-for-react-19";
+ import {RouterProvider} from "react-router";
+ import router from "./router";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
import "@ant-design/v5-patch-for-react-19";
import "@ant-design/v5-patch-for-react-19";
import {RouterProvider} from "react-router";
import router from "./router";
🤖 Prompt for AI Agents 
In components/log-viewer-webui/client/src/AntdApp.tsx at line 5, the import of
the Ant Design compatibility patch must be moved to the very top of the file
before any other imports. This ensures the patch runs first and properly
modifies Ant Design behavior. Relocate the import statement so it is the first
line in the file.



/**
* Renders Web UI app.
Expand Down