-
Notifications
You must be signed in to change notification settings - Fork 92
refactor(clp-s): Add ANTLR-generated parsers to codebase to eliminate need for code dependencies at build time. #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0a2f8bc
5b43788
19f1e80
19a6cc4
8c8a6f3
8ba8191
fc1f64c
cb707a7
a7072be
17e3800
6eda0ee
bd0abcd
d0daacf
ddb047c
b9f16ea
b2ec42f
9d121af
1210f2b
108f61d
f4742f2
b8b804e
7878b3b
f457bff
09faf7c
075ca5b
8b3191c
abcb91d
e88d914
da1523b
4f15581
7cec3fd
399803f
b7a0519
7507fec
4bb484e
cfd48c0
4a8ad65
0c3e5e1
5fee637
10baa2d
51bcf30
6760985
457254e
e30dc2b
7b27d63
0270ef2
c8277a0
4b83336
2980015
3ef0261
7727eed
b5b2909
6da4782
e9c6c36
9d9d91c
c493f54
9a30c0b
3bcf6fe
6b4f74e
616bb69
529787e
0f5cda6
660e2c5
b86cc0a
bcbd0fe
54b73cc
76fd933
37dbe46
b07a57a
9c741d0
8a9449e
b35a0c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: "clp-s-generated-code-checks" | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: "${{github.workflow}}-${{github.ref}}" | ||
| # Cancel in-progress jobs for efficiency | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| antlr-code-committed: | ||
| name: "antlr-code-committed" | ||
| strategy: | ||
| matrix: | ||
| os: ["macos-latest", "ubuntu-latest"] | ||
| runs-on: "${{matrix.os}}" | ||
| steps: | ||
| - uses: "actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" | ||
| with: | ||
| submodules: "recursive" | ||
|
|
||
| - name: "Install task" | ||
| shell: "bash" | ||
| run: "npm install -g @go-task/cli" | ||
|
|
||
|
Comment on lines
+25
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Cache Task CLI install 🤖 Prompt for AI Agents |
||
| - if: "matrix.os == 'macos-latest'" | ||
| name: "Install coreutils (for md5sum)" | ||
| run: "brew install coreutils" | ||
|
|
||
| - name: "Check if the generated parsers are the latest" | ||
| shell: "bash" | ||
| run: | ||
| | | ||
| git status --porcelain \ | ||
| components/core/src/clp_s/search/kql/generated \ | ||
| components/core/src/clp_s/search/sql/generated \ | ||
| | grep . > /dev/null \ | ||
| && exit 1 \ | ||
| || exit 0 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,12 +119,9 @@ if (absl_FOUND) | |
| endif() | ||
|
|
||
| # Find and setup ANTLR Library | ||
| # We build and link to the static library | ||
| find_package(ANTLR REQUIRED) | ||
| if (ANTLR_FOUND) | ||
| message(STATUS "Found ANTLR ${ANTLR_VERSION}") | ||
| else() | ||
| message(FATAL_ERROR "Could not find libraries for ANTLR ${ANTLR4_TAG}") | ||
| find_package(antlr4-runtime REQUIRED) | ||
| if (antlr4-runtime_FOUND) | ||
| message(STATUS "Found antlr4-runtime ${antlr4-runtime_VERSION}") | ||
| endif() | ||
|
Comment on lines
+123
to
125
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Optional: simplify version message 🤖 Prompt for AI Agents |
||
|
|
||
| # Find and setup Boost Library | ||
|
|
||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Sanitise concurrency group
Using
github.refmay include slashes (refs/heads/...), which can cause unexpected grouping. Consider usinggithub.head_reffor PRs or replacing/with_to ensure valid group IDs.🤖 Prompt for AI Agents