-
Notifications
You must be signed in to change notification settings - Fork 92
feat(kv-ir): Implement QueryHandler's evaluate_kv_pair_log_event.
#882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LinZhihao-723
merged 29 commits into
y-scope:main
from
LinZhihao-723:kvir-search-query-handler-evaluation
May 14, 2025
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7b203a6
Add iterative evaluation method
LinZhihao-723 e74e31f
Fix null query issue.
LinZhihao-723 e3636fe
Implement search.
LinZhihao-723 10008b5
Ops, forget to commit this one.
LinZhihao-723 00e2ecc
Fix clang-tidy warnings on the tes files.
LinZhihao-723 ca87b29
Ignore unsupported literal types.
LinZhihao-723 8f51308
WIP
LinZhihao-723 e7a578b
Working on the unit tests...
LinZhihao-723 6791912
Add basic
LinZhihao-723 7ea6075
Merge branch 'oss_main' into kvir-search-query-handler-evaluation
LinZhihao-723 dd35aa2
Finish test dev
LinZhihao-723 bfe5873
Add inverter to the test
LinZhihao-723 ed633bf
Update test case.
LinZhihao-723 8dda41b
Add comments for xor.
LinZhihao-723 fd0c79a
Update components/core/src/clp/ffi/ir_stream/search/ErrorCode.cpp
LinZhihao-723 cc6bdd4
Merge branch 'kvir-search-query-handler-evaluation' of https://github…
LinZhihao-723 d9d27b5
Apply code review comments.
LinZhihao-723 1a6694d
Fix doc strings.
LinZhihao-723 b24af9c
Apply code review comments to move pruned check out of loop.
LinZhihao-723 8667286
Merge branch 'main' into kvir-search-query-handler-evaluation
LinZhihao-723 57568f2
Fix docstrings.
LinZhihao-723 2cad470
Apply suggestions from code review
LinZhihao-723 d7d8a92
Update components/core/src/clp/ffi/ir_stream/search/QueryHandlerImpl.hpp
LinZhihao-723 f32419f
Rename result bitmask type.
LinZhihao-723 66ed01f
Renaming push and pop according to the review comments.
LinZhihao-723 6067998
Fix docstring.
LinZhihao-723 ea1a28c
Use constexpr.
LinZhihao-723 e8e3148
Merge branch 'oss_main' into kvir-search-query-handler-evaluation
LinZhihao-723 620abca
Fix...
LinZhihao-723 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Provide type-safe bitwise helpers for the enum bitmask
AstEvaluationResultis now an unscoped enum so that implicitintegral conversions permit
|/&operations.Consider adding
constexproperator overloads instead and keeping ascoped enum (
enum class) – this preserves type-safety while stillallowing the same ergonomics:
This prevents accidental mixing with unrelated bit-fields and removes
the need for
ast_evaluation_result_bitmask_tcasts in most places.Also applies to: 20-20