refactor(core): Resolve clang-tidy violations in clp/networking/*.{cpp,hpp}.

[kirkrodrigues]

Description

Resolved clang-tidy violations in all files from clp/networking as a part of #764.

Checklist

• The PR satisfies the contribution guidelines.
• This is a breaking change and that has been indicated in the PR title, OR this isn't a
  breaking change.
• Necessary docs have been updated, OR no docs need to be updated.

Validation performed

• task lint:check-cpp-full succeeded.
• ubuntu-jammy-lint workflow passed.

Summary by CodeRabbit

• Refactor
  • Enhanced internal network operations for improved consistency, clarity, and maintainability. These adjustments support a robust overall performance while keeping your experience unchanged.
• Chore
  • Streamlined our development configuration by removing obsolete linting checks, ensuring a cleaner codebase for future improvements.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request updates several C++ function declarations by adopting trailing return type syntax. The modifications affect multiple functions related to socket operations in both header and source files, and include minor improvements to pointer declarations. Additionally, the linting configuration has been adjusted to remove these networking files from source file checks. The functionality remains unchanged despite the stylistic and dependency adjustments.

Changes

File(s)	Change Summary
components/core/src/clp/networking/SocketOperationFailed.hpp	Updated the what method in the SocketOperationFailed class to use trailing return type syntax.
components/core/src/clp/networking/socket_utils.cpp components/core/src/clp/networking/socket_utils.hpp	Changed the function signatures for connect_to_server, try_send, send, try_receive, and receive to use trailing return type syntax; clarified pointer declarations in socket_utils.cpp; updated header dependencies from Defs.h to ErrorCode and TraceableException headers in the source file.
lint-tasks.yml	Removed the networking files (SocketOperationFailed.hpp, socket_utils.cpp, and socket_utils.hpp) from the linting tasks.

Sequence Diagram(s)

(No sequence diagrams generated as the changes are syntactical and do not modify the control flow.)

Possibly related PRs

• fix(core): Resolve clang-tidy violations and compilation errors in GlobalMetadataDBConfig.hpp (fixes #643). #770: Modifications involve the use of trailing return type syntax in C++ classes, which relates directly to the changes introduced in this pull request.

Suggested Reviewers

• davidlion

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.