Skip to content

fix(core): Resolve clang-tidy violations and compilation errors in GlobalMetadataDBConfig.hpp (fixes #643). #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bill-hbrhbr merged 5 commits into from
Mar 15, 2025
Merged

fix(core): Resolve clang-tidy violations and compilation errors in GlobalMetadataDBConfig.hpp (fixes #643). #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e48e227
Add missing headers
Bill-hbrhbr Mar 15, 2025
883c5ea
Clang-tidy
Bill-hbrhbr Mar 15, 2025
dd12efc
Apply suggestions from code review
Bill-hbrhbr Mar 15, 2025
a22803a
Revert suggestion fixes
Bill-hbrhbr Mar 15, 2025
cbe8d75
Use brace init
Bill-hbrhbr Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions components/core/src/clp/GlobalMetadataDBConfig.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef CLP_GLOBALMETADATADBCONFIG_HPP
#define CLP_GLOBALMETADATADBCONFIG_HPP

#include <cstdint>
#include <string>

namespace clp {
Expand All @@ -16,34 +17,43 @@ class GlobalMetadataDBConfig {
};

// Constructors
GlobalMetadataDBConfig()
: m_metadata_db_type(MetadataDBType::SQLite),
m_metadata_db_host("localhost"),
m_metadata_db_port(3306) {}
GlobalMetadataDBConfig() = default;

// Methods
void parse_config_file(std::string const& config_file_path);

MetadataDBType get_metadata_db_type() const { return m_metadata_db_type; }
[[nodiscard]] auto get_metadata_db_type() const -> MetadataDBType { return m_metadata_db_type; }

std::string const& get_metadata_db_host() const { return m_metadata_db_host; }
[[nodiscard]] auto get_metadata_db_host() const -> std::string const& {
return m_metadata_db_host;
}

int get_metadata_db_port() const { return m_metadata_db_port; }
[[nodiscard]] auto get_metadata_db_port() const -> int { return m_metadata_db_port; }

std::string const& get_metadata_db_name() const { return m_metadata_db_name; }
[[nodiscard]] auto get_metadata_db_name() const -> std::string const& {
return m_metadata_db_name;
}

std::string const& get_metadata_db_username() const { return m_metadata_db_username; }
[[nodiscard]] auto get_metadata_db_username() const -> std::string const& {
return m_metadata_db_username;
}

std::string const& get_metadata_db_password() const { return m_metadata_db_password; }
[[nodiscard]] auto get_metadata_db_password() const -> std::string const& {
return m_metadata_db_password;
}

std::string const& get_metadata_table_prefix() const { return m_metadata_table_prefix; }
[[nodiscard]] auto get_metadata_table_prefix() const -> std::string const& {
return m_metadata_table_prefix;
}

private:
// Variables
MetadataDBType m_metadata_db_type;
static constexpr int cDefaultMetadataDbPort{3306};

std::string m_metadata_db_host;
int m_metadata_db_port;
MetadataDBType m_metadata_db_type{MetadataDBType::SQLite};

std::string m_metadata_db_host{"localhost"};
int m_metadata_db_port{cDefaultMetadataDbPort};
std::string m_metadata_db_name;

std::string m_metadata_db_username;
Expand Down
38 changes: 24 additions & 14 deletions components/core/src/glt/GlobalMetadataDBConfig.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef GLT_GLOBALMETADATADBCONFIG_HPP
#define GLT_GLOBALMETADATADBCONFIG_HPP

#include <cstdint>
#include <string>

namespace glt {
Expand All @@ -16,34 +17,43 @@ class GlobalMetadataDBConfig {
};

// Constructors
GlobalMetadataDBConfig()
: m_metadata_db_type(MetadataDBType::SQLite),
m_metadata_db_host("localhost"),
m_metadata_db_port(3306) {}
GlobalMetadataDBConfig() = default;

// Methods
void parse_config_file(std::string const& config_file_path);

MetadataDBType get_metadata_db_type() const { return m_metadata_db_type; }
[[nodiscard]] auto get_metadata_db_type() const -> MetadataDBType { return m_metadata_db_type; }

std::string const& get_metadata_db_host() const { return m_metadata_db_host; }
[[nodiscard]] auto get_metadata_db_host() const -> std::string const& {
return m_metadata_db_host;
}

int get_metadata_db_port() const { return m_metadata_db_port; }
[[nodiscard]] auto get_metadata_db_port() const -> int { return m_metadata_db_port; }

std::string const& get_metadata_db_name() const { return m_metadata_db_name; }
[[nodiscard]] auto get_metadata_db_name() const -> std::string const& {
return m_metadata_db_name;
}

std::string const& get_metadata_db_username() const { return m_metadata_db_username; }
[[nodiscard]] auto get_metadata_db_username() const -> std::string const& {
return m_metadata_db_username;
}

std::string const& get_metadata_db_password() const { return m_metadata_db_password; }
[[nodiscard]] auto get_metadata_db_password() const -> std::string const& {
return m_metadata_db_password;
}

std::string const& get_metadata_table_prefix() const { return m_metadata_table_prefix; }
[[nodiscard]] auto get_metadata_table_prefix() const -> std::string const& {
return m_metadata_table_prefix;
}

private:
// Variables
MetadataDBType m_metadata_db_type;
static constexpr int cDefaultMetadataDbPort{3306};

std::string m_metadata_db_host;
int m_metadata_db_port;
MetadataDBType m_metadata_db_type{MetadataDBType::SQLite};

std::string m_metadata_db_host{"localhost"};
int m_metadata_db_port{cDefaultMetadataDbPort};
std::string m_metadata_db_name;

std::string m_metadata_db_username;
Expand Down
2 changes: 0 additions & 2 deletions lint-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ tasks:
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/FileWriter.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/GlobalMetadataDB.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/GlobalMetadataDBConfig.cpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/GlobalMetadataDBConfig.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/GlobalMySQLMetadataDB.cpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/GlobalMySQLMetadataDB.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/clp/GlobalSQLiteMetadataDB.cpp"
Expand Down Expand Up @@ -567,7 +566,6 @@ tasks:
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/FileWriter.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/GlobalMetadataDB.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/GlobalMetadataDBConfig.cpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/GlobalMetadataDBConfig.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/GlobalMySQLMetadataDB.cpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/GlobalMySQLMetadataDB.hpp"
- "{{.G_CORE_COMPONENT_DIR}}/src/glt/GlobalSQLiteMetadataDB.cpp"
Expand Down