-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add support for ingesting logs from Kafka #547
base: main
Are you sure you want to change the base?
Conversation
…ome syntax errors
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@gibber9809 Hi. any update? |
Hi @dkhwangbo, This pull request is on hold for now while we work on a few higher priority items, but we could reprioritize it depending on your needs. Note that this draft implementation doesn't do much heavy lifting, so some changes may be required depending on your needs. In particular, the implementation just supports consuming a configurable number of messages from a given offset of a Kafka partition. The intention is that an external coordinator handles scheduling, worker failures, etc. We plan to add such a coordinator once a few other components are ready (e.g., a new scheduler), but that work is outside the scope of this PR. We'd be interested to hear more about your specific use case for Kafka support. Feel free to reply here, or send us an email to [email protected]. |
Description
This PR adds support for ingesting log data from Kafka by integrating with the
librdkafka
C library. A user specifies the Kafka topic they want to consume from, the partition, the starting offset, and the number of Kafka messages they would like to consume on the command line. Users must also specify a path to a config file containing configuration options for kafka such as the list of bootstrapping brokers to connect to.This configuration file is written in YAML, and may look something like:
and accepts any configuration option from the global configuration properties here.
The debug option enables internal debug logging from the librdkafka library, and is useful for diagnosing connection issues with Kafka.
Note that while this config file can be used for simple userid/password authentication it can't handle more advanced authentication flows. If we need to support some of the more advanced security options like authenticating with an OAUTH provider it seems like librdkafka requires us to implement some callback functions to reach out to an OAUTH broker on our own.
This PR is marked WIP since the end to end flow of ingesting logs from Kafka has not been fully validated.
Validation performed