core: Add support for building on Centos Stream 9 and drop support for building on Centos 7.4 (fixes #521). #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allelize shared and static library builds.
…sn't affect the other.
LinZhihao-723
requested changes
Sep 6, 2024
components/core/CMakeLists.txt
Outdated
| message( | ||
| AUTHOR_WARNING | ||
| "Building with static libraries is unsupported on \ | ||
| ${CLP_STATIC_LIBS_UNSUPPORTED_PLATFORM}. Switching to shared libraries.") |
There was a problem hiding this comment.
Looking at line 132 in the same file, I feel this line wrapping is inappropriate.
components/core/tools/scripts/lib_install/centos-stream-9/install-packages-from-source.sh
Outdated
Show resolved
Hide resolved
…all-packages-from-source.sh Co-authored-by: Lin Zhihao <[email protected]>
kirkrodrigues
commented
Sep 6, 2024
| message( | ||
| AUTHOR_WARNING | ||
| "Building with static libraries is unsupported on" | ||
| " ${CLP_STATIC_LIBS_UNSUPPORTED_PLATFORM}. Switching to shared libraries.") |
There was a problem hiding this comment.
I put the space on this line to follow our code style of putting operators, etc. at the beginning of a broken line.
LinZhihao-723
approved these changes
Sep 6, 2024
gibber9809
pushed a commit
to gibber9809/clp
that referenced
this pull request
Oct 25, 2024
…r building on Centos 7.4 (fixes y-scope#521). (y-scope#528) Co-authored-by: Lin Zhihao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As #521 mentions, CentOS reached EoL on 2024-Jun-30, so its default mirror list no longer exists. It seems like some folks have moved to CentOS Stream 9.
This PR adds support for building on CentOS Stream 9 and drops support for building on CentOS 7.4. We can't say for sure if this will affect existing users, but hopefully they will file an issue if it does.
Note that:
mysql.hdirectly rather than as a file withinmariadb, so this PR updates all references to do the same.mysql.hbefore was essentially using the include from the system-include directory, bypassing the CMake config script (which sets the include dir to<system-include-dir>/mariadbalready), so this is more correct.Validation performed