Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskfile: Replace utility tasks with ones from yscope-dev-utils. #456

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

kirkrodrigues
Copy link
Member

@kirkrodrigues kirkrodrigues commented Jun 21, 2024

Description

In an effort to simplify the main Taskfile before we add more tasks, this PR replaces the utility tasks for creating a Python venv, checksumming, and replacing text with the ones from yscope-dev-utils.

Validation performed

task clean
task lint:check
task lint:fix
task
task
task docs:site
task docs:site

This validates the lint tasks as well as clean and incremental builds of the package and docs.

@kirkrodrigues kirkrodrigues changed the title Taskfile: Move utility tasks into their own taskfile. Taskfile: Replace utility tasks with ones from yscope-dev-utils. Jun 23, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove L10's shallow = true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's do that in another PR since it wasn't a change introduced by this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. The rest LGTM.

@kirkrodrigues kirkrodrigues merged commit a40a661 into y-scope:main Jun 24, 2024
10 checks passed
@kirkrodrigues kirkrodrigues deleted the split-util-tasks branch June 24, 2024 20:35
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants