package: Rename "search" to "query" in search-cluster related variables to prepare for additional job types. #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
For the PR title and commit body, how about:
package: Rename "search" to "query" in search-cluster related variables to prepare for additional job types:
- Rename search scheduler/worker/job/task to query scheduler/worker/job/task where appropriate.
- Rename
search_configtojob_configin metadata DB. - Add
QueryJobbase class forSearchJob.
haiqi96
changed the title
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
…es to prepare for additional job types: (y-scope#449) - Rename search scheduler/worker/job/task to query scheduler/worker/job/task where appropriate. - Rename search_config to job_config in metadata DB. - Add QueryJob base class for SearchJob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change renames search worker/scheduler to be query worker/scheduler. We plan to let the current search worker handles more types of task (instead of only search). This PR servers as a preparation for our later change.
Most of the changes in this PR are simply replacing "search" with "query", except for the following:
Validation performed
rebuilt package. Confirmed that search worked in both commandline and webui.