-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi: Add WIP Serializer class for the next IR stream format. #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. How about "ffi: Add Serializer class for new IR stream format." for the title?
Co-authored-by: kirkrodrigues <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. How about "ffi: Add Serializer class for new IR stream format." for the title?
How about a slight update:
ffi: Add WIP Serializer class for the next IR stream format.
lgtm |
…#446) Co-authored-by: kirkrodrigues <[email protected]>
Description
When migrating to the next IR stream format, there are two important differences:
To adapt to these changes, we wrap all the necessary data structures into a new class named
Serializer
to keep track of the states, as well as maintain necessary data structures. In details:Note: this class is designed to provide serialization functionalities only. The upper-level caller should be responsible for writing the serialized bytes into IO streams properly. In addition, it doesn't provide a call to terminate the IR stream. The upper-level caller should decide when to terminate the stream by append
clp::ffi::ir_stream::cProtocol::Eof
at the end of the stream.Validation performed
clang-tidy
checks for theSerializer
implementation.clang-tidy
against the unit test file since it is not synchronized with the latest coding guideline.