Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix unreferenced doc. #443

Merged
merged 1 commit into from
Jun 15, 2024
Merged

docs: Fix unreferenced doc. #443

merged 1 commit into from
Jun 15, 2024

Conversation

kirkrodrigues
Copy link
Member

Description

#442 added a new docs page but I forgot to reference it from the index. This PR adds the reference.

Validation performed

  • task docs:serve
  • Verified the no warnings when building the docs.
  • Verified the docs showed up on the site.

junhaoliao
junhaoliao approved these changes Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Sorry for missing this in the previous review

@kirkrodrigues
Copy link
Member Author

Tested. Sorry for missing this in the previous review

Not to worry, it's my mistake. I'll add a workflow to test building the docs.

@kirkrodrigues kirkrodrigues merged commit 22bcd4b into y-scope:main Jun 15, 2024
2 checks passed
@kirkrodrigues kirkrodrigues deleted the fix-unref-doc branch June 15, 2024 03:48
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
@kirkrodrigues
docs: Fix unreferenced doc. (y-scope#443)
bec6191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkrodrigues @junhaoliao