clp-package: Use a server to receive results when searching from the command line. #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/job-orchestration/job_orchestration/executor/search/fs_search_task.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/executor/search/fs_search_task.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/job_config.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
kirkrodrigues
requested changes
Apr 1, 2024
| for unpacked in unpacker: | ||
| print(f"{unpacked[0]}: {unpacked[2]}", end="") | ||
| except asyncio.CancelledError: | ||
| return |
There was a problem hiding this comment.
What's the intent with swallowing the error?
There was a problem hiding this comment.
Do you think it's better not to catch the error and handle it in main?
There was a problem hiding this comment.
In this case, yeah, I think so since we're not doing anything special with the error and asyncio.run should swallow it anyway.
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/job-orchestration/job_orchestration/scheduler/job_config.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
kirkrodrigues
requested changes
Apr 1, 2024
components/job-orchestration/job_orchestration/executor/search/fs_search_task.py
Outdated
Show resolved
Hide resolved
components/clp-package-utils/clp_package_utils/scripts/native/search.py
Outdated
Show resolved
Hide resolved
|
Sorry, missed two points |
kirkrodrigues
approved these changes
Apr 2, 2024
wraymo
changed the title
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#299 and #324
Description
#299 and #324 add support for sending query results to a network destination. This PR adds a network server to the package to receive query results.
Validation performed
sbin/search.sh "org.apache.hadoop.metrics2.impl.MetricsSystemImpl: ReduceTask metrics system shutdown complete". Used WebUI to run the same query. Both returned results as expected.sbin/search.sh "id: 22419". Used WebUI to run the same query. Both returned results as expected.