Skip to content

feat(compression-coordinator): Add the compression coordinator executable scaffolding. #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
20001020ycx merged 4 commits into from
Jul 23, 2026
Merged

feat(compression-coordinator): Add the compression coordinator executable scaffolding. #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc85947
Done.
LinZhihao-723 Jul 22, 2026
0758f40
Update docker file to include compression coordinator.
LinZhihao-723 Jul 22, 2026
5cd57f4
Merge branch 'main' into compression-coordinator-bin
LinZhihao-723 Jul 23, 2026
f99c7f2
Fix.
LinZhihao-723 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion components/compression-coordinator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,14 @@ edition = "2024"
name = "compression_coordinator"
path = "src/lib.rs"

[[bin]]
name = "compression-coordinator"
path = "src/bin/compression_coordinator.rs"

[dependencies]
anyhow = "1.0.100"
async-trait = "0.1.89"
clap = { version = "4.6.4", features = ["derive"] }
clp-rust-utils = { path = "../clp-rust-utils" }
rmp-serde = "1.3.1"
serde = { version = "1.0.228", features = ["derive"] }
Expand All @@ -17,7 +23,7 @@ spider-core = { git = "https://github.com/y-scope/spider.git", branch = "main" }
sqlx = { version = "0.8.6", features = ["runtime-tokio", "mysql"] }
strsim = "0.11.1"
thiserror = "2.0.18"
tokio = { version = "1.52.3", features = ["time"] }
tokio = { version = "1.52.3", features = ["time", "rt-multi-thread"] }

@coderabbitai coderabbitai Bot Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "## Cargo.toml snippet"
sed -n '1,80p' components/compression-coordinator/Cargo.toml

echo
echo "## Target files"
fd -a 'compression_coordinator\.rs$' components/compression-coordinator || true

echo
echo "## Relevant tokio::main usages"
rg -n '#\[tokio::main\]|tokio::main' components/compression-coordinator/src || true

echo
echo "## Direct tokio dep occurrences"
rg -n 'tokio\s*=' components/compression-coordinator/Cargo.toml

Repository: y-scope/clp

Length of output: 2002

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "$(pwd)"
echo "$(git rev-parse --show-toplevel 2>/dev/null || true)"
echo "## tracked compression-coordinator files"
git ls-files | rg '(^|/)compression-coordinator(/Cargo.toml|.*/src/bin/compression_coordinator.rs)$' || true
echo "## local file presence"
for f in \
  components/compression-coordinator/Cargo.toml \
  components/compression-coordinator/src/bin/compression_coordinator.rs
do
  if [ -f "$f" ]; then
    echo "EXISTS $f"
    ls -l "$f"
  else
    echo "MISSING $f"
  fi
done

Repository: y-scope/clp

Length of output: 2002

🌐 Web query:

Tokio documentation main attribute requires macros feature #[tokio::main]

💡 Result:

To use the #[tokio::main] attribute macro, you must enable the "macros" feature and at least one runtime feature ("rt" or "rt-multi-thread") in your Cargo.toml file [1][2][3]. The requirement is structured as follows: 1. Macros Feature: The "macros" feature is strictly required to enable the #[tokio::main] and #[tokio::test] attribute macros [3]. 2. Runtime Feature: Because the #[tokio::main] macro is responsible for setting up and starting a Tokio runtime, it also requires you to enable a runtime implementation [1][4]. You must select at least one of the following [2][3]: - rt: Enables the single-threaded (current-thread) runtime scheduler [3]. - rt-multi-thread: Enables the multi-threaded runtime scheduler [3]. If you attempt to use #[tokio::main] without these required features, the compiler will return an error, typically stating: "The #[tokio::main] macro requires rt or rt-multi-thread" [2][4]. Example configuration for your Cargo.toml: [dependencies] tokio = { version = "1", features = ["macros", "rt-multi-thread"] }

Citations:

Enable Tokio’s macros feature.

#[tokio::main] requires the macros feature in addition to a runtime feature, so the current manifest will fail to compile this binary.

Proposed fix 
-tokio = { version = "1.52.3", features = ["time", "rt-multi-thread"] }
+tokio = { version = "1.52.3", features = ["macros", "time", "rt-multi-thread"] }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
tokio = { version = "1.52.3", features = ["time", "rt-multi-thread"] }
tokio = { version = "1.52.3", features = ["macros", "time", "rt-multi-thread"] }
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/compression-coordinator/Cargo.toml` at line 24, Update the tokio
dependency declaration in the Cargo manifest to include the macros feature
alongside the existing time and rt-multi-thread features, so the binary using
#[tokio::main] can compile.

tracing = "0.1.44"

[dev-dependencies]
Expand Down
19 changes: 19 additions & 0 deletions components/compression-coordinator/src/bin/compression_coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
use std::path::PathBuf;

use clap::Parser;

/// Command-line arguments for the compression coordinator.
#[derive(Debug, Parser)]
#[command(about = "Run the compression coordinator.")]
struct Cli {
/// Path to the configuration file.
#[arg(short, long, value_name = "PATH")]
config: PathBuf,
}

#[tokio::main]
async fn main() -> anyhow::Result<()> {
let _cli = Cli::parse();

Ok(())
}
1 change: 1 addition & 0 deletions tools/docker-images/clp-package/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,6 @@ COPY --link --chown=${UID} ./build/spider/spider-build/src/spider/spider_worker
COPY --link --chown=${UID} ./build/nodejs-22/bin/node bin/node-22
COPY --link --chown=${UID} ./build/python-libs/ lib/python3/site-packages/
COPY --link --chown=${UID} ./build/rust-targets/release/api_server bin/
COPY --link --chown=${UID} ./build/rust-targets/release/compression-coordinator bin/
COPY --link --chown=${UID} ./build/rust-targets/release/log-ingestor bin/
COPY --link --chown=${UID} ./build/webui/ var/www/webui/
Loading