Repository navigation
feat(presto-clp): Add support for custom S3 endpoint URLs and buckets. #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
20001020ycx
merged 16 commits into
y-scope:main
from
20001020ycx:2026-01-27-update-velox-conf
Feb 20, 2026
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2be8401
add code for update clp.properties in the velox worker
20001020ycx 6298bc4
fix error handling
20001020ycx 9319488
delete unused var
20001020ycx 8511646
address comment
20001020ycx f8ee2e5
nit fix
20001020ycx fc402c9
Update tools/deployment/presto-clp/scripts/init.py
20001020ycx 064feb8
Update tools/deployment/presto-clp/scripts/init.py
20001020ycx db8b8f7
address review comment
20001020ycx b1a0881
nit
20001020ycx 469aa3b
Update tools/deployment/presto-clp/scripts/init.py
20001020ycx ae56023
Merge branch 'main' into 2026-01-27-update-velox-conf
junhaoliao 8520ff9
Merge branch 'main' into 2026-01-27-update-velox-conf
junhaoliao 90cc4b5
Merge branch 'main' into 2026-01-27-update-velox-conf
junhaoliao a080de5
Merge branch 'main' into 2026-01-27-update-velox-conf
junhaoliao ed7feb7
Merge branch 'main' into 2026-01-27-update-velox-conf
20001020ycx c859616
Merge branch 'main' into 2026-01-27-update-velox-conf
20001020ycx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is needed to support non-AWS S3 endpoints. However, omitting a region is non-standard for AWS S3. Historically, some AWS SDKs would fall back to
us-east-1when no region was specified, but this behavior should not be relied upon.Should we add a log message when neither
endpoint_urlnorregion_codeis provided (here)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g.
Neither 'endpoint_url' nor 'region_code' specified in S3 config. Using region-less S3 endpoint which may not work for all buckets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested by @gibber9809 , this behavior is followed by generate_s3_url in s3_utils.py so that CLP package always make consistent assumption.
I am okay with adding the log message when neither 'endpoint_url' nor 'region_code' is specified in S3 config as a warnning. But should we keep the same behavior as the changes in this PR?
And thanks for the insight on this S3 support!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see what @gibber9809 decides on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for slow response. Yeah logging a warning in this case sounds reasonable. It probably also makes sense to log the same warning during the package startup whenever 'endpoint_url' and 'region_code' are missing from the package config for the same reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine tackling this in a separate PR though that adds the warning both here and in the package startup script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai we will merge the current PR first and add the warning messages later. let's create an issue about adding a warning message both here and in the package startup script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 42
@junhaoliaoI've created issue#1932to track adding the warning messages for S3 configurations that lack bothendpoint_urlandregion_code. The issue has been assigned to you and includes references back to this PR and discussion.#1932
🧬 Code Graph Analysis Results
<no_relevant_code_snippets>
</no_relevant_code_snippets>
🧠 Learnings used