chore: Bump version for 0.8.0 release and remove edit page button from docs. - #1884
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -85,25 +86,15 @@ | |||
| "navbar_start": ["navbar-logo", "version-switcher"], | |||
| "navbar_end": ["navbar-icon-links", "theme-switcher"], | |||
| "primary_sidebar_end": [], | |||
| "secondary_sidebar_items": ["page-toc", "edit-this-page"], | |||
There was a problem hiding this comment.
do we want to instead keep the edit button but let it point to docs on the main branch?
There was a problem hiding this comment.
The issue is that the docs on the main branch may change significantly, so having an edit button could be confusing. Alternatively, we could make it point at the release branch, but I would prefer not to encourage edits to release docs until we have a better workflow for updating such docs.
junhaoliao
left a comment
There was a problem hiding this comment.
in combination with #1885 , the changes look correct to me
junhaoliao
left a comment
There was a problem hiding this comment.
the title lgtm. (i suppose it's intentional not to mention that we are removing the edit button, since we will apply similar changes on the release branches for every release)
| "version_match": CLP_GIT_REF, | ||
| "version_match": CLP_VERSION, | ||
| }, | ||
| "use_edit_page_button": True, |
There was a problem hiding this comment.
"use_edit_page_button": True,
what's the effect of keeping this? shall we remove?
There was a problem hiding this comment.
Yeah, good point, we can.
Not intentional. Since I follow a runbook for creating the release, I didn't think too much about the title. What do you think of the updated title? |
junhaoliao
left a comment
There was a problem hiding this comment.
sorry for missing this - we should also lock the Helm Chart version?
and the image ref in values.yaml |
Description
This PR updates any version references from 0.7.1-dev to 0.8.0 in preparation for the release.
Checklist
breaking change.
Validation performed
Validated
tasksucceeded.