Drop support for building core on Ubuntu Bionic and add support for building it on Jammy. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding it on Jammy.
README.md
Outdated
| 1. Docker Image `clp/clp-core-dependencies-x86-ubuntu-jammy` | ||
| - A docker image containing all the necessary dependencies to build CLP core in an Ubuntu Jammy x86 environment | ||
| 2. Docker Image `clp/clp-core-dependencies-x86-ubuntu-focal` | ||
| - A docker image containing all the necessary dependencies to build CLP core in an Ubuntu Focal x86 environment |
There was a problem hiding this comment.
There is an extra space before the -
SharafMohamed
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#131 requires building with gcc 10 whereas Ubuntu Bionic's package manager doesn't have gcc 10. We could build gcc 10 from source on Bionic but since Bionic reached end of life over 6 months ago, it seems prudent to drop support for building on it.
This PR also adds support for building on Ubuntu Jammy (22.04).
Validation performed
Workflows passed.