Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate parsing methods from ffi and non-ffi code (fixes #160) #161

Merged
merged 8 commits into from
Sep 17, 2023
Merged

Consolidate parsing methods from ffi and non-ffi code (fixes #160) #161

merged 8 commits into from
Sep 17, 2023

Conversation

kirkrodrigues
Copy link
Member

References

#160

Description

The parsing methods in ffi and those outside were using different delimiters leading which caused #160. This PR finally consolidates the parsing methods from the two into the ir namespace.

Validation performed

@kirkrodrigues kirkrodrigues changed the title Consolidate parsing methods from ffi and clp (fixes #160) Consolidate parsing methods from ffi and non-ffi code (fixes #160) Sep 17, 2023
@kirkrodrigues
Replace LogTypeDictionaryEntry::VarDelim with ir::VariablePlaceholder…
7fd4656 
…; Deduplicate logtype constant escaping method; Replace all instances of variable delimiter with variable placeholder.
LinZhihao-723
LinZhihao-723 requested changes Sep 17, 2023
View reviewed changes
Copy link
Member

@LinZhihao-723 LinZhihao-723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a few comments

components/core/src/ffi/ir_stream/encoding_methods.cpp Show resolved Hide resolved
components/core/src/ir/parsing.cpp Outdated Show resolved Hide resolved
components/core/src/ir/parsing.cpp Outdated Show resolved Hide resolved
components/core/src/ir/parsing.cpp Outdated Show resolved Hide resolved
components/core/src/ir/parsing.hpp Outdated Show resolved Hide resolved
components/core/src/LogTypeDictionaryEntry.cpp Outdated Show resolved Hide resolved
@LinZhihao-723 LinZhihao-723 merged commit 5d0f7b3 into y-scope:main Sep 17, 2023
5 checks passed
@kirkrodrigues kirkrodrigues deleted the fix-160 branch December 16, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinZhihao-723 LinZhihao-723 LinZhihao-723 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkrodrigues @LinZhihao-723