Skip to content

feat(webui): Set up ANTLR tooling for future client-side SQL parsing; Move clp-s parser generation to codegen.yaml; Remove unused client package-lock.json. #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoophalab merged 24 commits into from
Sep 15, 2025
Merged

feat(webui): Set up ANTLR tooling for future client-side SQL parsing; Move clp-s parser generation to codegen.yaml; Remove unused client package-lock.json. #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
86c59aa
feat(webui): Add client-side SQL validation with ANTLR.
hoophalab Sep 9, 2025
8720d9f
disable ts check for antlr generated files
hoophalab Sep 9, 2025
9889def
remove visitor for now
hoophalab Sep 9, 2025
c8fc0ee
address comments
hoophalab Sep 9, 2025
efeeaaf
update ci
hoophalab Sep 9, 2025
73cfa0b
fix output dirs
hoophalab Sep 9, 2025
8930140
update notice
hoophalab Sep 10, 2025
0d517a5
use upper case stream
hoophalab Sep 10, 2025
62919ce
update notice; update codegen.yaml
hoophalab Sep 10, 2025
609dae3
remove unused cmd
hoophalab Sep 10, 2025
466cccf
Merge branch 'main' into sqlparser
hoophalab Sep 10, 2025
6636b5f
Merge branch 'main' into sqlparser
hoophalab Sep 11, 2025
e938132
fix lint in merge
hoophalab Sep 11, 2025
9bba81d
Merge branch 'main' into sqlparser
hoophalab Sep 11, 2025
b2e0607
Merge branch 'main' into sqlparser
junhaoliao Sep 12, 2025
035606c
Update taskfiles/codegen.yaml
hoophalab Sep 14, 2025
bd8813e
Update taskfiles/codegen.yaml
hoophalab Sep 14, 2025
46bf866
Update taskfiles/codegen.yaml
hoophalab Sep 14, 2025
851e38a
Update taskfiles/codegen.yaml
hoophalab Sep 14, 2025
c7da866
Add taskfile to deps
hoophalab Sep 15, 2025
a20c8ab
Merge branch 'main' into sqlparser
hoophalab Sep 15, 2025
f008074
fix merge
hoophalab Sep 15, 2025
b7c990f
Merge branch 'main' into sqlparser
hoophalab Sep 15, 2025
cd1b6b6
Update taskfiles/codegen.yaml
hoophalab Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/clp-s-generated-code-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- name: "Generate parsers"
shell: "bash"
run: "task clp-s-generate-parsers"
run: "task codegen:clp-s-generate-parsers"

- name: "Check if the generated parsers are the latest"
shell: "bash"
Expand Down
2 changes: 2 additions & 0 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
`components/webui/client/sql-parser/SqlBase.g4` was originally authored by the contributors of
https://github.com/prestodb/presto
Comment on lines +1 to +2

@coderabbitai coderabbitai Bot Sep 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

⚠️ Potential issue

Fix path in NOTICE; optionally pin to a commit permalink.

Path should include src. Consider adding a permalink to the exact Presto commit used.

-`components/webui/client/sql-parser/SqlBase.g4` was originally authored by the contributors of
-https://github.com/prestodb/presto
+`components/webui/client/src/sql-parser/SqlBase.g4` was originally authored by the contributors of
+https://github.com/prestodb/presto (permalink to the specific commit).
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
`components/webui/client/sql-parser/SqlBase.g4` was originally authored by the contributors of
https://github.com/prestodb/presto
`components/webui/client/src/sql-parser/SqlBase.g4` was originally authored by the contributors of
https://github.com/prestodb/presto (permalink to the specific commit).
🤖 Prompt for AI Agents 
In NOTICE around lines 1-2, the referenced path to the upstream Presto file is
missing the src directory and should point to the exact source path used; update
the path to include src/components/webui/client/sql-parser/SqlBase.g4 and,
optionally, replace the generic repository URL with a commit permalink (e.g.
https://github.com/prestodb/presto/blob/<commit-hash>/src/components/webui/client/sql-parser/SqlBase.g4)
so the NOTICE points to the exact file version.

1 change: 1 addition & 0 deletions components/webui/client/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const EslintConfig = [
ignores: [
"dist/",
"node_modules/",
"src/sql-parser/generated",
],
Comment on lines +12 to 13

@coderabbitai coderabbitai Bot Sep 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Nit: use a trailing slash in ignore path.

Reduces chance of accidental partial matches on similarly named files.

-            "src/sql-parser/generated",
+            "src/sql-parser/generated/",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"src/sql-parser/generated",
],
"src/sql-parser/generated/",
],
🤖 Prompt for AI Agents 
In components/webui/client/eslint.config.mjs around lines 12 to 13, the ignore
path "src/sql-parser/generated" should include a trailing slash to avoid
accidental partial matches; update the entry to "src/sql-parser/generated/" so
the ignore list targets the directory explicitly.

},
CommonConfig,
Expand Down
Loading
Loading