Skip to content

fix(kv-ir): Fix compiler warnings found in y-scope/velox#29. #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LinZhihao-723 merged 1 commit into from
Sep 5, 2025
Merged

fix(kv-ir): Fix compiler warnings found in y-scope/velox#29. #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/core/src/clp/ffi/ir_stream/Deserializer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ class Deserializer {
nlohmann::json metadata,
QueryHandlerType query_handler
)
: m_ir_unit_handler{std::move(ir_unit_handler)},
m_metadata(std::move(metadata)),
: m_metadata(std::move(metadata)),
m_ir_unit_handler{std::move(ir_unit_handler)},
m_query_handler{std::move(query_handler)} {}

// Variables
Expand Down
2 changes: 1 addition & 1 deletion components/core/src/clp/ffi/ir_stream/search/QueryHandlerImpl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ auto QueryHandlerImpl::update_partially_resolved_columns(
}
}

for (auto const [node_id, token_it] : new_partial_resolutions) {
for (auto const& [node_id, token_it] : new_partial_resolutions) {
auto [it, inserted] = partial_resolutions_to_update.try_emplace(
node_id,
std::vector<ColumnDescriptorTokenIterator>{}
Expand Down
Loading