-
Notifications
You must be signed in to change notification settings - Fork 92
feat(clp-s): Add support for losslessly compressing floating-point numbers; Bump archive format version to v0.4.1. #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2c0a7e3
91b499c
41eee1a
1a3ef60
e4bca46
1c2d47e
32a5375
f6f58be
6bc94cc
8724e11
1f33f98
15e4346
e5717ef
a4cbd89
30c9b08
c56275e
0090052
38d5ae4
87a131f
287b43e
283ce61
b0d083d
3e18f00
bee4fca
71f2fb6
e6ac492
42347c1
284027c
3870058
eff80ce
03506bc
4da57f3
e8db268
5a385c6
c43884d
b6b364a
e72ea13
c0982e7
464f3b6
5425f84
cfc3740
98e0390
b5c1987
091a3fc
731bf83
1d3fd9f
bf9cfb0
18e5aaf
af19cc6
ab38a34
73da7f3
fcea117
7ed2c91
bf9b6cb
0197735
c1bf459
eb9a711
ef79776
05fd52c
1c2a209
d4ef78b
86ed676
c1b2960
c38d22a
0d4b607
0e15df7
6813e1e
200a320
dafb471
f9725db
7c0d698
a2a31b0
b997d17
b8e2d50
2f70218
3894a4d
b37df69
89e9a1f
903e6c2
46983ae
0aca1e2
7da0c1d
5fbdd07
cda2121
f6e1024
2f25beb
66a7e8e
1504898
c0b7e84
c0d6f4c
29fcbf2
777f126
bb46862
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -232,6 +232,8 @@ set( | |
| DictionaryWriter.cpp | ||
| DictionaryWriter.hpp | ||
| ErrorCode.hpp | ||
| FloatFormatEncoding.cpp | ||
| FloatFormatEncoding.hpp | ||
| JsonFileIterator.cpp | ||
|
Comment on lines
+235
to
237
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick Adding FloatFormatEncoding to writer sources: SGTM Good to see the encoding module compiled into the writer. If this module will be shared broadly (writer, reader, json constructor, etc.), consider extracting it into a tiny common target (e.g., clp_s::float_format) and linking both writer/reader to it to avoid repeated compilation. Not urgent given existing project patterns. 🤖 Prompt for AI Agents |
||
| JsonFileIterator.hpp | ||
| JsonParser.cpp | ||
|
|
@@ -274,6 +276,7 @@ if(CLP_BUILD_CLP_S_ARCHIVEWRITER) | |
| msgpack-cxx | ||
| nlohmann_json::nlohmann_json | ||
| simdjson::simdjson | ||
| ystdlib::error_handling | ||
| PRIVATE | ||
| Boost::url | ||
| clp_s::clp_dependencies | ||
|
|
@@ -299,6 +302,8 @@ set( | |
| DictionaryEntry.hpp | ||
| DictionaryReader.hpp | ||
| ErrorCode.hpp | ||
| FloatFormatEncoding.cpp | ||
| FloatFormatEncoding.hpp | ||
| JsonSerializer.hpp | ||
|
Comment on lines
+305
to
307
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick Adding FloatFormatEncoding to reader sources: SGTM Mirrors the writer change; necessary for decode/restore path. Same optional note as above: consider a small shared target if this module expands or is reused elsewhere. 🤖 Prompt for AI Agents |
||
| PackedStreamReader.cpp | ||
| PackedStreamReader.hpp | ||
|
|
@@ -335,6 +340,7 @@ if(CLP_BUILD_CLP_S_ARCHIVEREADER) | |
| clp_s::io | ||
| msgpack-cxx | ||
| nlohmann_json::nlohmann_json | ||
| ystdlib::error_handling | ||
| PRIVATE | ||
| Boost::url | ||
| clp_s::clp_dependencies | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.