Skip to content

fix(package): Add StatusIntEnum class to match the behavior of IntEnum in Python 3.11. #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haiqi96 merged 11 commits into from
Aug 5, 2025
Merged

fix(package): Add StatusIntEnum class to match the behavior of IntEnum in Python 3.11. #1133

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
10ab065
refactor
haiqi96 Jul 25, 2025
a7e68c2
Remove unnecessary change
haiqi96 Jul 25, 2025
d3b72a4
Revert one change
haiqi96 Jul 28, 2025
470713a
Merge branch 'main' into slight_refactor_2
haiqi96 Jul 28, 2025
0c65d5a
Merge branch 'main' into slight_refactor_2
haiqi96 Jul 29, 2025
e99fc82
Merge branch 'main' into slight_refactor_2
haiqi96 Jul 29, 2025
adcbf75
fix
haiqi96 Aug 1, 2025
fed9010
review comments
haiqi96 Aug 3, 2025
365d4d3
Merge branch 'main' into slight_refactor_2
haiqi96 Aug 3, 2025
53ce262
Merge branch 'main' into slight_refactor_2
haiqi96 Aug 4, 2025
bf219c3
Merge branch 'main' into slight_refactor_2
haiqi96 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions components/job-orchestration/job_orchestration/scheduler/constants.py
View file
Open in desktop

@junhaoliao junhaoliao Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of overriding individual classes' __str__ method, can we add a mixin like

class IntEnumStrMixin:
    """
    Delegates __str__ to int.__str__, matching the behavior of IntEnum
    in Python 3.11+.
    TODO: Remove this when our minimum supported Python version is 3.11+.
    """

    def __str__(self):
        return int.__str__(self.__getattribute__("value"))

class CompressionJobStatus(IntEnumStrMixin, IntEnum):
    PENDING = 0
    RUNNING = auto()
    SUCCEEDED = auto()
    FAILED = auto()

alternatively, we can also extend the IntEnum class into a custom class and let the existing enum classes extend from it.

@haiqi96 haiqi96 Aug 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated my code. let me know if you agree with the current approach. If you don't see any issues, I will then update the PR description.

Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,36 @@ class CompressionJobStatus(IntEnum):
SUCCEEDED = auto()
FAILED = auto()

def __str__(self) -> str:
return str(self.value)
Comment thread
haiqi96 marked this conversation as resolved.
Resolved

def to_str(self) -> str:
return str(self.name)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

class CompressionJobCompletionStatus(IntEnum):
SUCCEEDED = 0
FAILED = auto()

def __str__(self) -> str:
return str(self.value)

def to_str(self) -> str:
return str(self.name)


class CompressionTaskStatus(IntEnum):
PENDING = 0
RUNNING = auto()
SUCCEEDED = auto()
FAILED = auto()

def __str__(self) -> str:
return str(self.value)

def to_str(self) -> str:
return str(self.name)


# When adding new states always add them to the end of this enum
# and make necessary changes in the UI, Query Scheduler, and Reducer
Expand Down