Skip to content

feat(new-webui): Enable configuration override in Fastify dotenv settings (fixes #1010). #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junhaoliao merged 1 commit into from
Jun 16, 2025
Merged

feat(new-webui): Enable configuration override in Fastify dotenv settings (fixes #1010). #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/log-viewer-webui/server/src/fastify-v2/plugins/external/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export const autoConfig = {
".env",
".env.local",
],
override: true,
},
Comment on lines +68 to 69

@coderabbitai coderabbitai Bot Jun 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

override: true can unintentionally mask deployment-time variables

Setting override: true is useful for local overrides but it also forces the values from the listed .env* files to clobber anything already present in process.env, including variables injected by the container or CI/CD pipeline. If you want stricter control in production, consider gating the flag:

-        override: true,
+        override: process.env.NODE_ENV !== "production",

or split the config so the production build omits this option.

To verify the context of override: true in your Fastify env plugin, let’s inspect the surrounding lines in the file:

🏁 Script executed:

#!/bin/bash
set -e
file="components/log-viewer-webui/server/src/fastify-v2/plugins/external/env.ts"

echo "Context around override:"
rg -n "override:" -A3 "$file"

Length of output: 329

Let’s pull in the surrounding plugin setup to confirm exactly how override: true is applied:

#!/bin/bash
set -e
file="components/log-viewer-webui/server/src/fastify-v2/plugins/external/env.ts"

echo "== Imports & plugin registration (first 90 lines) =="
head -n90 "$file"

Enable override only outside of production

Loading .env* files with override: true will overwrite any environment variables injected at deploy time (for example by Docker or CI/CD). To avoid masking critical production values, gate the flag on the NODE_ENV:

File: components/log-viewer-webui/server/src/fastify-v2/plugins/external/env.ts
Lines: 68–69

-        override: true,
+        override: process.env.NODE_ENV !== "production",

This ensures you still get local overrides during development without clobbering production-injected variables.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
override: true,
},
override: process.env.NODE_ENV !== "production",
},
🤖 Prompt for AI Agents 
In components/log-viewer-webui/server/src/fastify-v2/plugins/external/env.ts
around lines 68 to 69, the override: true setting causes environment variables
from .env files to overwrite deployment-time variables, which can mask critical
production values. Modify the code to enable override: true only when NODE_ENV
is not 'production', so local overrides work during development but production
environment variables remain intact.


// Source for the configuration data
Expand Down