Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clp-s: Reported uncompressed size can be incorrect after archive-splitting #469

Closed
gibber9809 opened this issue Jul 3, 2024 · 0 comments · Fixed by #463
Closed

clp-s: Reported uncompressed size can be incorrect after archive-splitting #469

gibber9809 opened this issue Jul 3, 2024 · 0 comments · Fixed by #463
Labels
bug Something isn't working

Comments

@gibber9809
Copy link
Contributor

Bug

In clp-s when an archive split happens while JsonFileIterator is partway through a buffer full of JSON data the full size of the buffer can be attributed to the total size of the first archive instead of being split correctly between the archives before and after the split.

CLP version

v0.1.1

Environment

ubuntu focal container

Reproduction steps

  1. Compress a two line archive using an archive split threshold of 1 byte
  2. Observe that the size of the second archive is reported as 0 bytes
@gibber9809 gibber9809 added the bug Something isn't working label Jul 3, 2024
@gibber9809 gibber9809 linked a pull request Jul 3, 2024 that will close this issue
clp-s: Correctly report uncompressed size of archives during archive-splitting (fixes #469). #463
Merged
gibber9809 added a commit that referenced this issue Jul 3, 2024
@gibber9809
clp-s: Correctly report uncompressed size of archives during archive-…
3c1f0ad 
…splitting (fixes #469). (#463)
jackluo923 pushed a commit to jackluo923/clp that referenced this issue Dec 4, 2024
@gibber9809
clp-s: Correctly report uncompressed size of archives during archive-…
a9c9abe 
…splitting (fixes y-scope#469). (y-scope#463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@gibber9809